Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808880/?format=api
{ "id": 808880, "url": "http://patchwork.ozlabs.org/api/patches/808880/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-18-hjl.tools@gmail.com/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901180029.9527-18-hjl.tools@gmail.com>", "list_archive_url": null, "date": "2017-09-01T17:59:48", "name": "[17/58] Mark internal dirent functions with attribute_hidden [BZ #18822]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5690e27a971fccfa72513d22a87cf9ddb9266d5e", "submitter": { "id": 4387, "url": "http://patchwork.ozlabs.org/api/people/4387/?format=api", "name": "H.J. Lu", "email": "hjl.tools@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-18-hjl.tools@gmail.com/mbox/", "series": [ { "id": 1088, "url": "http://patchwork.ozlabs.org/api/series/1088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=1088", "date": "2017-09-01T18:00:21", "name": "Hide internal functions in libc.so", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1088/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808880/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808880/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84073-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84073-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"lFLIJTaC\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRxd2N50z9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 04:05:57 +1000 (AEST)", "(qmail 87228 invoked by alias); 1 Sep 2017 18:01:00 -0000", "(qmail 87151 invoked by uid 89); 1 Sep 2017 18:01:00 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=B6VPKFkvGYGObqzL265q6MOJ4fWircM\n\teqsSuCsoNAHSA9tRE0XFr9Us6IdxgjWxKAxRgiVhWLpw2UVP1s+NdOWQwbuW4UW/\n\tDEqUvByoQW6WVrybspLWrcwJQs25qTW/McY5RWAxWrq6XDJRbka2ytqI+thfwGgK\n\t4g2Mzl+Y40rA=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=JPCfHnZhL4ehrOmbaKu4sUAUqhY=; b=lFLIJ\n\tTaCApxRZf06UySZte4b3Psqny6gGXEvcBoUwBvOXraygtrcVM6ihQWZnfkN/bEQx\n\tugT78iQ/FOx6BSjYmWGlR/7iIiV+sOTr8zz3ElqalsFhgccFNTZoEAZTCjTOBg3p\n\txV6Yrf/k/83RFqmlLSgf9zCa6mkOad7cyd2wKg=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=", "X-HELO": "mga02.intel.com", "X-ExtLoop1": "1", "From": "\"H.J. Lu\" <hjl.tools@gmail.com>", "To": "libc-alpha@sourceware.org", "Subject": "[PATCH 17/58] Mark internal dirent functions with attribute_hidden\n\t[BZ #18822]", "Date": "Fri, 1 Sep 2017 10:59:48 -0700", "Message-Id": "<20170901180029.9527-18-hjl.tools@gmail.com>", "In-Reply-To": "<20170901180029.9527-1-hjl.tools@gmail.com>", "References": "<20170901180029.9527-1-hjl.tools@gmail.com>" }, "content": "Mark internal dirent functions with attribute_hidden to allow direct\naccess within libc.so and libc.a without using GOT nor PLT. __readdir64\nis hidden with libc_hidden_proto and libc_hidden_def since the exported\nreaddir64 is an alias of __readdir64.\n\n\t[BZ #18822]\n\t* include/dirent.h (__opendir): Always add attribute_hidden.\n\t(__fdopendir): Likewise.\n\t(__closedir): Likewise.\n\t(__readdir): Likewise.\n\t(__readdir64): Add libc_hidden_proto.\n\t* sysdeps/mach/hurd/readdir64.c (__readdir64): Add libc_hidden_def.\n\t* sysdeps/unix/sysv/linux/i386/readdir64.c (__readdir64): Likewise.\n\t* sysdeps/unix/sysv/linux/readdir64.c (__readdir64): Likewise.\n\t* sysdeps/unix/sysv/linux/wordsize-64/readdir.c (__GI___readdir64):\n\tNew alias.\n---\n include/dirent.h | 13 +++++--------\n sysdeps/mach/hurd/readdir64.c | 1 +\n sysdeps/unix/sysv/linux/i386/readdir64.c | 1 +\n sysdeps/unix/sysv/linux/readdir64.c | 1 +\n sysdeps/unix/sysv/linux/wordsize-64/readdir.c | 1 +\n 5 files changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/dirent.h b/include/dirent.h\nindex bebcd52cdb..26868eeb61 100644\n--- a/include/dirent.h\n+++ b/include/dirent.h\n@@ -15,12 +15,13 @@ struct scandir_cancel_struct\n };\n \n /* Now define the internal interfaces. */\n-extern DIR *__opendir (const char *__name);\n+extern DIR *__opendir (const char *__name) attribute_hidden;\n extern DIR *__opendirat (int dfd, const char *__name) attribute_hidden;\n-extern DIR *__fdopendir (int __fd);\n-extern int __closedir (DIR *__dirp);\n-extern struct dirent *__readdir (DIR *__dirp);\n+extern DIR *__fdopendir (int __fd) attribute_hidden;\n+extern int __closedir (DIR *__dirp) attribute_hidden;\n+extern struct dirent *__readdir (DIR *__dirp) attribute_hidden;\n extern struct dirent64 *__readdir64 (DIR *__dirp);\n+libc_hidden_proto (__readdir64)\n extern int __readdir_r (DIR *__dirp, struct dirent *__entry,\n \t\t\tstruct dirent **__result);\n extern int __readdir64_r (DIR *__dirp, struct dirent64 *__entry,\n@@ -75,10 +76,6 @@ libc_hidden_proto (__scandirat)\n libc_hidden_proto (scandirat64)\n \n # if IS_IN (rtld)\n-extern __typeof (__closedir) __closedir attribute_hidden;\n-extern __typeof (__fdopendir) __fdopendir attribute_hidden;\n-extern __typeof (__readdir) __readdir attribute_hidden;\n-extern __typeof (__readdir64) __readdir64 attribute_hidden;\n extern __typeof (__rewinddir) __rewinddir attribute_hidden;\n # endif\n # endif\ndiff --git a/sysdeps/mach/hurd/readdir64.c b/sysdeps/mach/hurd/readdir64.c\nindex f422fcff04..bad0bcb559 100644\n--- a/sysdeps/mach/hurd/readdir64.c\n+++ b/sysdeps/mach/hurd/readdir64.c\n@@ -98,4 +98,5 @@ __readdir64 (DIR *dirp)\n return dp;\n }\n \n+libc_hidden_def (__readdir64)\n weak_alias (__readdir64, readdir64)\ndiff --git a/sysdeps/unix/sysv/linux/i386/readdir64.c b/sysdeps/unix/sysv/linux/i386/readdir64.c\nindex de8669feff..8c235f9831 100644\n--- a/sysdeps/unix/sysv/linux/i386/readdir64.c\n+++ b/sysdeps/unix/sysv/linux/i386/readdir64.c\n@@ -27,6 +27,7 @@\n #undef __GETDENTS\n #undef DIRENT_TYPE\n \n+libc_hidden_def (__readdir64)\n versioned_symbol (libc, __readdir64, readdir64, GLIBC_2_2);\n \n #if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2)\ndiff --git a/sysdeps/unix/sysv/linux/readdir64.c b/sysdeps/unix/sysv/linux/readdir64.c\nindex 224f53db88..6d154fe988 100644\n--- a/sysdeps/unix/sysv/linux/readdir64.c\n+++ b/sysdeps/unix/sysv/linux/readdir64.c\n@@ -4,4 +4,5 @@\n \n #include <sysdeps/posix/readdir.c>\n \n+libc_hidden_def (__readdir64)\n weak_alias (__readdir64, readdir64)\ndiff --git a/sysdeps/unix/sysv/linux/wordsize-64/readdir.c b/sysdeps/unix/sysv/linux/wordsize-64/readdir.c\nindex e197d93b00..0d5798849d 100644\n--- a/sysdeps/unix/sysv/linux/wordsize-64/readdir.c\n+++ b/sysdeps/unix/sysv/linux/wordsize-64/readdir.c\n@@ -3,5 +3,6 @@\n #include <sysdeps/posix/readdir.c>\n #undef __readdir64\n strong_alias (__readdir, __readdir64)\n+strong_alias (__readdir, __GI___readdir64)\n #undef readdir64\n weak_alias (__readdir, readdir64)\n", "prefixes": [ "17/58" ] }