Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808878/?format=api
{ "id": 808878, "url": "http://patchwork.ozlabs.org/api/patches/808878/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-20-hjl.tools@gmail.com/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901180029.9527-20-hjl.tools@gmail.com>", "list_archive_url": null, "date": "2017-09-01T17:59:50", "name": "[19/58] Mark internal stdlib functions with attribute_hidden [BZ #18822]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "057b009d1712b366c73d13034f0ad6aa6d6b47a7", "submitter": { "id": 4387, "url": "http://patchwork.ozlabs.org/api/people/4387/?format=api", "name": "H.J. Lu", "email": "hjl.tools@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-20-hjl.tools@gmail.com/mbox/", "series": [ { "id": 1088, "url": "http://patchwork.ozlabs.org/api/series/1088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=1088", "date": "2017-09-01T18:00:21", "name": "Hide internal functions in libc.so", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1088/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808878/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808878/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84071-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84071-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"thMVinmz\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRxB3NkNz9s3w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 04:05:34 +1000 (AEST)", "(qmail 86787 invoked by alias); 1 Sep 2017 18:00:58 -0000", "(qmail 86735 invoked by uid 89); 1 Sep 2017 18:00:57 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=V8ulla8Cqzu6F7Hhsaq+DuXX8NEfIJh\n\tU6FFfq0FxF5s4eAXUDfltf53JbGNP+spW2S3nPgfpYy9rcfaWFt/VZFY7gaJHMDs\n\t9k4MY0MYQVfkLf7ZvC4Bz9fIVjTVWxuptCQ+jxWC4Eo5Lk7g0NyfbjbLFde17Ph0\n\t/eNblrxNwDus=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=JoWy8oOu/HrSjgorJA6P4znL1HE=; b=thMVi\n\tnmzoLdW6XMJjOq29BPV9NPrXCxHBYrQ4oqSPQiw9B5jt8sC6z7nMNIqc/ogZjJfQ\n\th+bolLN7OpoytQOqIlcH01dwLz7A3xY6yZJSb6g1FkXKh0HPynmGef0IRdIxR8kp\n\tfjPucn3MYovkAPm/aq+blFtTnt14VAfth4BwVk=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=", "X-HELO": "mga02.intel.com", "X-ExtLoop1": "1", "From": "\"H.J. Lu\" <hjl.tools@gmail.com>", "To": "libc-alpha@sourceware.org", "Subject": "[PATCH 19/58] Mark internal stdlib functions with attribute_hidden\n\t[BZ #18822]", "Date": "Fri, 1 Sep 2017 10:59:50 -0700", "Message-Id": "<20170901180029.9527-20-hjl.tools@gmail.com>", "In-Reply-To": "<20170901180029.9527-1-hjl.tools@gmail.com>", "References": "<20170901180029.9527-1-hjl.tools@gmail.com>" }, "content": "Mark internal stdlib functions with attribute_hidden to allow direct\naccess within libc.so and libc.a without using GOT nor PLT. __realpath\nis hidden with libc_hidden_proto and libc_hidden_def since the exported\nrealpath is an alias of __realpath.\n\n\t[BZ #18822]\n\t* include/stdlib.h (__random): Add attribute_hidden.\n\t(__random_r): Likewise.\n\t(__srandom_r): Likewise.\n\t(__initstate_r): Likewise.\n\t(__setstate_r): Likewise.\n\t(__erand48_r): Likewise.\n\t(__nrand48_r): Likewise.\n\t(__jrand48_r): Likewise.\n\t(__srand48_r): Likewise.\n\t(__seed48_r): Likewise.\n\t(__lcong48_r): Likewise.\n\t(__drand48_iterate): Likewise.\n\t(__setenv): Likewise.\n\t(__unsetenv): Likewise.\n\t(__clearenv): Likewise.\n\t(__ptsname_r): Likewise.\n\t(__posix_openpt): Likewise.\n\t(__add_to_environ): Likewise.\n\t(__ecvt_r): Likewise.\n\t(__fcvt_r): Likewise.\n\t(__qecvt_r): Likewise.\n\t(__qfcvt_r): Likewise.\n\t(__realpath): Add libc_hidden_proto.\n\t* stdlib/canonicalize.c (__realpath): Add libc_hidden_def.\n---\n include/stdlib.h | 57 ++++++++++++++++++++++++++++++---------------------\n stdlib/canonicalize.c | 1 +\n 2 files changed, 35 insertions(+), 23 deletions(-)", "diff": "diff --git a/include/stdlib.h b/include/stdlib.h\nindex d0dcbf81c3..61a15cb340 100644\n--- a/include/stdlib.h\n+++ b/include/stdlib.h\n@@ -40,56 +40,65 @@ libc_hidden_proto (__qsort_r)\n libc_hidden_proto (lrand48_r)\n libc_hidden_proto (wctomb)\n \n-extern long int __random (void);\n+extern long int __random (void) attribute_hidden;\n extern void __srandom (unsigned int __seed);\n extern char *__initstate (unsigned int __seed, char *__statebuf,\n \t\t\t size_t __statelen);\n extern char *__setstate (char *__statebuf);\n-extern int __random_r (struct random_data *__buf, int32_t *__result);\n-extern int __srandom_r (unsigned int __seed, struct random_data *__buf);\n+extern int __random_r (struct random_data *__buf, int32_t *__result)\n+ attribute_hidden;\n+extern int __srandom_r (unsigned int __seed, struct random_data *__buf)\n+ attribute_hidden;\n extern int __initstate_r (unsigned int __seed, char *__statebuf,\n-\t\t\t size_t __statelen, struct random_data *__buf);\n-extern int __setstate_r (char *__statebuf, struct random_data *__buf);\n+\t\t\t size_t __statelen, struct random_data *__buf)\n+ attribute_hidden;\n+extern int __setstate_r (char *__statebuf, struct random_data *__buf)\n+ attribute_hidden;\n extern int __rand_r (unsigned int *__seed);\n extern int __erand48_r (unsigned short int __xsubi[3],\n-\t\t\tstruct drand48_data *__buffer, double *__result);\n+\t\t\tstruct drand48_data *__buffer, double *__result)\n+ attribute_hidden;\n extern int __nrand48_r (unsigned short int __xsubi[3],\n \t\t\tstruct drand48_data *__buffer,\n-\t\t\tlong int *__result);\n+\t\t\tlong int *__result) attribute_hidden;\n extern int __jrand48_r (unsigned short int __xsubi[3],\n \t\t\tstruct drand48_data *__buffer,\n-\t\t\tlong int *__result);\n+\t\t\tlong int *__result) attribute_hidden;\n extern int __srand48_r (long int __seedval,\n-\t\t\tstruct drand48_data *__buffer);\n+\t\t\tstruct drand48_data *__buffer) attribute_hidden;\n extern int __seed48_r (unsigned short int __seed16v[3],\n-\t\t struct drand48_data *__buffer);\n+\t\t struct drand48_data *__buffer) attribute_hidden;\n extern int __lcong48_r (unsigned short int __param[7],\n-\t\t\tstruct drand48_data *__buffer);\n+\t\t\tstruct drand48_data *__buffer) attribute_hidden;\n \n /* Internal function to compute next state of the generator. */\n extern int __drand48_iterate (unsigned short int __xsubi[3],\n-\t\t\t struct drand48_data *__buffer);\n+\t\t\t struct drand48_data *__buffer)\n+ attribute_hidden;\n \n /* Global state for non-reentrant functions. Defined in drand48-iter.c. */\n extern struct drand48_data __libc_drand48_data attribute_hidden;\n \n-extern int __setenv (const char *__name, const char *__value, int __replace);\n-extern int __unsetenv (const char *__name);\n-extern int __clearenv (void);\n+extern int __setenv (const char *__name, const char *__value, int __replace)\n+ attribute_hidden;\n+extern int __unsetenv (const char *__name) attribute_hidden;\n+extern int __clearenv (void) attribute_hidden;\n extern char *__mktemp (char *__template) __THROW __nonnull ((1));\n extern char *__canonicalize_file_name (const char *__name);\n extern char *__realpath (const char *__name, char *__resolved);\n-extern int __ptsname_r (int __fd, char *__buf, size_t __buflen);\n+libc_hidden_proto (__realpath)\n+extern int __ptsname_r (int __fd, char *__buf, size_t __buflen)\n+ attribute_hidden;\n # ifndef _ISOMAC\n extern int __ptsname_internal (int fd, char *buf, size_t buflen,\n \t\t\t struct stat64 *stp) attribute_hidden;\n # endif\n extern int __getpt (void);\n-extern int __posix_openpt (int __oflag);\n+extern int __posix_openpt (int __oflag) attribute_hidden;\n \n extern int __add_to_environ (const char *name, const char *value,\n-\t\t\t const char *combines, int replace);\n-\n+\t\t\t const char *combines, int replace)\n+ attribute_hidden;\n extern void _quicksort (void *const pbase, size_t total_elems,\n \t\t\tsize_t size, __compar_d_fn_t cmp, void *arg);\n \n@@ -253,10 +262,10 @@ extern char *__fcvt (double __value, int __ndigit, int *__restrict __decpt,\n extern char *__gcvt (double __value, int __ndigit, char *__buf);\n extern int __ecvt_r (double __value, int __ndigit, int *__restrict __decpt,\n \t\t int *__restrict __sign, char *__restrict __buf,\n-\t\t size_t __len);\n+\t\t size_t __len) attribute_hidden;\n extern int __fcvt_r (double __value, int __ndigit, int *__restrict __decpt,\n \t\t int *__restrict __sign, char *__restrict __buf,\n-\t\t size_t __len);\n+\t\t size_t __len) attribute_hidden;\n extern char *__qecvt (long double __value, int __ndigit,\n \t\t int *__restrict __decpt, int *__restrict __sign);\n extern char *__qfcvt (long double __value, int __ndigit,\n@@ -264,10 +273,12 @@ extern char *__qfcvt (long double __value, int __ndigit,\n extern char *__qgcvt (long double __value, int __ndigit, char *__buf);\n extern int __qecvt_r (long double __value, int __ndigit,\n \t\t int *__restrict __decpt, int *__restrict __sign,\n-\t\t char *__restrict __buf, size_t __len);\n+\t\t char *__restrict __buf, size_t __len)\n+ attribute_hidden;\n extern int __qfcvt_r (long double __value, int __ndigit,\n \t\t int *__restrict __decpt, int *__restrict __sign,\n-\t\t char *__restrict __buf, size_t __len);\n+\t\t char *__restrict __buf, size_t __len)\n+ attribute_hidden;\n \n # if IS_IN (libc)\n # undef MB_CUR_MAX\ndiff --git a/stdlib/canonicalize.c b/stdlib/canonicalize.c\nindex c3d892c862..4ff7e0feb8 100644\n--- a/stdlib/canonicalize.c\n+++ b/stdlib/canonicalize.c\n@@ -218,6 +218,7 @@ error:\n free (rpath);\n return NULL;\n }\n+libc_hidden_def (__realpath)\n versioned_symbol (libc, __realpath, realpath, GLIBC_2_3);\n \n \n", "prefixes": [ "19/58" ] }