Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808855/?format=api
{ "id": 808855, "url": "http://patchwork.ozlabs.org/api/patches/808855/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-7-hjl.tools@gmail.com/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901180029.9527-7-hjl.tools@gmail.com>", "list_archive_url": null, "date": "2017-09-01T17:59:37", "name": "[06/58] Mark internal unistd functions with attribute_hidden [BZ #18822]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "94c4676619c8db33690095592fb18f07f4bf58f4", "submitter": { "id": 4387, "url": "http://patchwork.ozlabs.org/api/people/4387/?format=api", "name": "H.J. Lu", "email": "hjl.tools@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-7-hjl.tools@gmail.com/mbox/", "series": [ { "id": 1088, "url": "http://patchwork.ozlabs.org/api/series/1088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=1088", "date": "2017-09-01T18:00:21", "name": "Hide internal functions in libc.so", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1088/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808855/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808855/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84052-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84052-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"oU7p65i4\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRsb2KfNz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 04:02:27 +1000 (AEST)", "(qmail 84347 invoked by alias); 1 Sep 2017 18:00:47 -0000", "(qmail 84112 invoked by uid 89); 1 Sep 2017 18:00:46 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=hrVS4auAN3a3rpL3cNcTtN10dzr3vgN\n\toPBf4MqiSm7FHUm96qhfkjjLZ7U93vwZbTNjiqbCVVmq4X2APrlIZf4igvrBGy3F\n\ts5MNwET+Q35eJBF6zr9GdFiMp2acU7MD4xWG1p6OBVn1+IXnWyiShqFnOzozHpuR\n\td0IyBFjGl/SI=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=VEAAOUMAK1Y7dd90lwjrB4R0QfM=; b=oU7p6\n\t5i4fz7GcLrjf7Egv1i/ylFmqhhLhPHmo1e76LVc08V/dIJa5m1/tQNuv978n59bh\n\tXH7m+ea6xW1KiaoEVpAXe9LmjSYRrXol8pD8fTo5CAXA2kUwrtPmqQHgDodEGKTj\n\tFvBpcDEOIfaFVcuS/FCmc/naOOn3++UXprvaj0=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=", "X-HELO": "mga02.intel.com", "X-ExtLoop1": "1", "From": "\"H.J. Lu\" <hjl.tools@gmail.com>", "To": "libc-alpha@sourceware.org", "Subject": "[PATCH 06/58] Mark internal unistd functions with attribute_hidden\n\t[BZ #18822]", "Date": "Fri, 1 Sep 2017 10:59:37 -0700", "Message-Id": "<20170901180029.9527-7-hjl.tools@gmail.com>", "In-Reply-To": "<20170901180029.9527-1-hjl.tools@gmail.com>", "References": "<20170901180029.9527-1-hjl.tools@gmail.com>" }, "content": "Mark internal unistd functions with attribute_hidden to allow direct\naccess to them within libc.so and libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* include/unistd.h (__access): Add attribute_hidden.\n\t(__lseek64): Likewise.\n\t(__libc_pread64): Likewise.\n\t(__pipe2): Likewise.\n\t(__sleep): Likewise.\n\t(__chdir): Likewise.\n\t(__fchdir): Likewise.\n\t(__getcwd): Likewise.\n\t(__rmdir): Likewise.\n\t(__execvpe): Likewise.\n\t(__execve): Likewise.\n\t(__setsid): Likewise.\n\t(__getuid): Likewise.\n\t(__geteuid): Likewise.\n\t(__getgid): Likewise.\n\t(__getegid): Likewise.\n\t(__getgroups): Likewise.\n\t(__group_member): Likewise.\n\t(__ttyname_r): Likewise.\n\t(__isatty): Likewise.\n\t(__readlink): Likewise.\n\t(__unlink): Likewise.\n\t(__gethostname): Likewise.\n\t(__profil): Likewise.\n\t(__getdtablesize): Likewise.\n\t(__brk): Likewise.\n\t(__ftruncate): Likewise.\n\t(__ftruncate64): Likewise.\n---\n include/unistd.h | 60 ++++++++++++++++++++++++++++++--------------------------\n 1 file changed, 32 insertions(+), 28 deletions(-)", "diff": "diff --git a/include/unistd.h b/include/unistd.h\nindex a5625ed7f4..4dc445e048 100644\n--- a/include/unistd.h\n+++ b/include/unistd.h\n@@ -23,9 +23,10 @@ libc_hidden_proto (tcgetpgrp)\n libc_hidden_proto (readlinkat)\n \n /* Now define the internal interfaces. */\n-extern int __access (const char *__name, int __type);\n+extern int __access (const char *__name, int __type) attribute_hidden;\n extern int __euidaccess (const char *__name, int __type);\n-extern __off64_t __lseek64 (int __fd, __off64_t __offset, int __whence);\n+extern __off64_t __lseek64 (int __fd, __off64_t __offset, int __whence)\n+ attribute_hidden;\n extern __off_t __lseek (int __fd, __off_t __offset, int __whence);\n libc_hidden_proto (__lseek)\n extern __off_t __libc_lseek (int __fd, __off_t __offset, int __whence);\n@@ -39,7 +40,7 @@ extern ssize_t __pread64 (int __fd, void *__buf, size_t __nbytes,\n \t\t\t __off64_t __offset);\n libc_hidden_proto (__pread64);\n extern ssize_t __libc_pread64 (int __fd, void *__buf, size_t __nbytes,\n-\t\t\t __off64_t __offset);\n+\t\t\t __off64_t __offset) attribute_hidden;\n extern ssize_t __pwrite (int __fd, const void *__buf, size_t __n,\n \t\t\t __off_t __offset);\n libc_hidden_proto (__pwrite)\n@@ -58,8 +59,8 @@ libc_hidden_proto (__libc_write)\n libc_hidden_proto (write)\n extern int __pipe (int __pipedes[2]);\n libc_hidden_proto (__pipe)\n-extern int __pipe2 (int __pipedes[2], int __flags);\n-extern unsigned int __sleep (unsigned int __seconds);\n+extern int __pipe2 (int __pipedes[2], int __flags) attribute_hidden;\n+extern unsigned int __sleep (unsigned int __seconds) attribute_hidden;\n extern int __chown (const char *__file,\n \t\t __uid_t __owner, __gid_t __group);\n libc_hidden_proto (__chown)\n@@ -67,12 +68,12 @@ extern int __fchown (int __fd,\n \t\t __uid_t __owner, __gid_t __group);\n extern int __lchown (const char *__file, __uid_t __owner,\n \t\t __gid_t __group);\n-extern int __chdir (const char *__path);\n-extern int __fchdir (int __fd);\n-extern char *__getcwd (char *__buf, size_t __size);\n-extern int __rmdir (const char *__path);\n+extern int __chdir (const char *__path) attribute_hidden;\n+extern int __fchdir (int __fd) attribute_hidden;\n+extern char *__getcwd (char *__buf, size_t __size) attribute_hidden;\n+extern int __rmdir (const char *__path) attribute_hidden;\n extern int __execvpe (const char *file, char *const argv[],\n-\t\t char *const envp[]);\n+\t\t char *const envp[]) attribute_hidden;\n \n /* Get the canonical absolute name of the named directory, and put it in SIZE\n bytes of BUF. Returns NULL if the directory couldn't be determined or\n@@ -91,7 +92,7 @@ libc_hidden_proto (__dup2)\n extern int __dup3 (int __fd, int __fd2, int flags);\n libc_hidden_proto (__dup3)\n extern int __execve (const char *__path, char *const __argv[],\n-\t\t char *const __envp[]);\n+\t\t char *const __envp[]) attribute_hidden;\n extern long int __pathconf (const char *__path, int __name);\n extern long int __fpathconf (int __fd, int __name);\n extern long int __sysconf (int __name);\n@@ -99,14 +100,14 @@ libc_hidden_proto (__sysconf)\n extern __pid_t __getpid (void);\n libc_hidden_proto (__getpid)\n extern __pid_t __getppid (void);\n-extern __pid_t __setsid (void);\n-extern __uid_t __getuid (void);\n-extern __uid_t __geteuid (void);\n-extern __gid_t __getgid (void);\n-extern __gid_t __getegid (void);\n-extern int __getgroups (int __size, __gid_t __list[]);\n+extern __pid_t __setsid (void) attribute_hidden;\n+extern __uid_t __getuid (void) attribute_hidden;\n+extern __uid_t __geteuid (void) attribute_hidden;\n+extern __gid_t __getgid (void) attribute_hidden;\n+extern __gid_t __getegid (void) attribute_hidden;\n+extern int __getgroups (int __size, __gid_t __list[]) attribute_hidden;\n libc_hidden_proto (__getpgid)\n-extern int __group_member (__gid_t __gid);\n+extern int __group_member (__gid_t __gid) attribute_hidden;\n extern int __setuid (__uid_t __uid);\n extern int __setreuid (__uid_t __ruid, __uid_t __euid);\n extern int __setgid (__gid_t __gid);\n@@ -123,17 +124,20 @@ libc_hidden_proto (__setresuid)\n libc_hidden_proto (__setresgid)\n extern __pid_t __vfork (void);\n libc_hidden_proto (__vfork)\n-extern int __ttyname_r (int __fd, char *__buf, size_t __buflen);\n-extern int __isatty (int __fd);\n+extern int __ttyname_r (int __fd, char *__buf, size_t __buflen)\n+ attribute_hidden;\n+extern int __isatty (int __fd) attribute_hidden;\n extern int __link (const char *__from, const char *__to);\n extern int __symlink (const char *__from, const char *__to);\n-extern ssize_t __readlink (const char *__path, char *__buf, size_t __len);\n-extern int __unlink (const char *__name);\n-extern int __gethostname (char *__name, size_t __len);\n+extern ssize_t __readlink (const char *__path, char *__buf, size_t __len)\n+ attribute_hidden;\n+extern int __unlink (const char *__name) attribute_hidden;\n+extern int __gethostname (char *__name, size_t __len) attribute_hidden;\n extern int __profil (unsigned short int *__sample_buffer, size_t __size,\n-\t\t size_t __offset, unsigned int __scale);\n-extern int __getdtablesize (void);\n-extern int __brk (void *__addr);\n+\t\t size_t __offset, unsigned int __scale)\n+ attribute_hidden;\n+extern int __getdtablesize (void) attribute_hidden;\n+extern int __brk (void *__addr) attribute_hidden;\n extern int __close (int __fd);\n libc_hidden_proto (__close)\n extern int __libc_close (int __fd);\n@@ -145,8 +149,8 @@ extern __pid_t __fork (void);\n libc_hidden_proto (__fork)\n extern int __getpagesize (void) __attribute__ ((__const__));\n libc_hidden_proto (__getpagesize)\n-extern int __ftruncate (int __fd, __off_t __length);\n-extern int __ftruncate64 (int __fd, __off64_t __length);\n+extern int __ftruncate (int __fd, __off_t __length) attribute_hidden;\n+extern int __ftruncate64 (int __fd, __off64_t __length) attribute_hidden;\n extern int __truncate (const char *path, __off_t __length);\n extern void *__sbrk (intptr_t __delta);\n libc_hidden_proto (__sbrk)\n", "prefixes": [ "06/58" ] }