Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808849/?format=api
{ "id": 808849, "url": "http://patchwork.ozlabs.org/api/patches/808849/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-4-hjl.tools@gmail.com/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901180029.9527-4-hjl.tools@gmail.com>", "list_archive_url": null, "date": "2017-09-01T17:59:34", "name": "[03/58] Mark __internal_statvfs[64] with attribute_hidden [BZ #18822]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "36a10e8c5fdb2723fdfe96a517d9ae02d46279d6", "submitter": { "id": 4387, "url": "http://patchwork.ozlabs.org/api/people/4387/?format=api", "name": "H.J. Lu", "email": "hjl.tools@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20170901180029.9527-4-hjl.tools@gmail.com/mbox/", "series": [ { "id": 1088, "url": "http://patchwork.ozlabs.org/api/series/1088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=1088", "date": "2017-09-01T18:00:21", "name": "Hide internal functions in libc.so", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1088/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808849/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808849/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84046-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84046-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"v+mOcSaZ\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRrP6r64z9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 04:01:25 +1000 (AEST)", "(qmail 83875 invoked by alias); 1 Sep 2017 18:00:45 -0000", "(qmail 82932 invoked by uid 89); 1 Sep 2017 18:00:39 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=YTtTYix7/AfomAU8GDRzaCijxmjCb1p\n\tjpI+M71ATCjf/OwLynQ2QgjeQOUlgc/EE9cJLLEQNtLi6WCMwjOepsVkggLPXO3G\n\txP07t6Ln80JANzmq074hiddgkYRjNBM9WMa01yLut84L0FwxNd+1oGFr14bI0o7o\n\tgNlQ5cvskNP4=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=17IdAo/jTRC+Tw5SmNmO/y2wf1A=; b=v+mOc\n\tSaZYuk7EhpRJw8MtWrffIqU2CX641ryxiHdWxMwVKge3wkAzTbwnHvZDH7MsG0YW\n\tjgHapbmyc5JsyX2Lp80f1wzYFGpP2nSGqvgEJNkVUe2mFg1yVY/0P2nI+VSt2PwS\n\tHYE9v83WhvryqwNIJWiubhcdY6nLXKvxRptxRI=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-26.2 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3,\n\tSPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=H*m:gmail", "X-HELO": "mga02.intel.com", "X-ExtLoop1": "1", "From": "\"H.J. Lu\" <hjl.tools@gmail.com>", "To": "libc-alpha@sourceware.org", "Subject": "[PATCH 03/58] Mark __internal_statvfs[64] with attribute_hidden [BZ\n\t#18822]", "Date": "Fri, 1 Sep 2017 10:59:34 -0700", "Message-Id": "<20170901180029.9527-4-hjl.tools@gmail.com>", "In-Reply-To": "<20170901180029.9527-1-hjl.tools@gmail.com>", "References": "<20170901180029.9527-1-hjl.tools@gmail.com>" }, "content": "Mark __internal_statvfs[64] with attribute_hidden to allow direct access\nto them within libc.so and libc.a without using GOT nor PLT.\n\n\t[BZ #18822]\n\t* sysdeps/unix/sysv/linux/fstatvfs.c: Include \"internal_statvfs.h\"\n\tinstead of <sys/statvfs.h>.\n\t(__internal_statvfs): Removed.\n\t* sysdeps/unix/sysv/linux/fstatvfs64.c Include \"internal_statvfs.h\"\n\tinstead of <sys/statvfs.h>.\n\t(__internal_statvfs64): Removed.\n\t* sysdeps/unix/sysv/linux/internal_statvfs.c: Include\n\t\"internal_statvfs.h\" instead of <sys/statvfs.h>.\n\t* sysdeps/unix/sysv/linux/internal_statvfs.h: New file.\n\t* sysdeps/unix/sysv/linux/statvfs.c Include \"internal_statvfs.h\"\n\tinstead of <sys/statvfs.h>.\n\t(__internal_statvfs): Removed.\n\t* sysdeps/unix/sysv/linux/statvfs64.c Include \"internal_statvfs.h\"\n\tinstead of <sys/statvfs.h>.\n\t(__internal_statvfs64): Removed.\n---\n sysdeps/unix/sysv/linux/fstatvfs.c | 6 +-----\n sysdeps/unix/sysv/linux/fstatvfs64.c | 7 +------\n sysdeps/unix/sysv/linux/internal_statvfs.c | 2 +-\n sysdeps/unix/sysv/linux/internal_statvfs.h | 26 ++++++++++++++++++++++++++\n sysdeps/unix/sysv/linux/statvfs.c | 6 +-----\n sysdeps/unix/sysv/linux/statvfs64.c | 7 +------\n 6 files changed, 31 insertions(+), 23 deletions(-)\n create mode 100644 sysdeps/unix/sysv/linux/internal_statvfs.h", "diff": "diff --git a/sysdeps/unix/sysv/linux/fstatvfs.c b/sysdeps/unix/sysv/linux/fstatvfs.c\nindex e07a5b9f3d..1b2f279291 100644\n--- a/sysdeps/unix/sysv/linux/fstatvfs.c\n+++ b/sysdeps/unix/sysv/linux/fstatvfs.c\n@@ -19,11 +19,7 @@\n #include <stddef.h>\n #include <sys/stat.h>\n #include <sys/statfs.h>\n-#include <sys/statvfs.h>\n-\n-extern void __internal_statvfs (const char *name, struct statvfs *buf,\n-\t\t\t\tstruct statfs *fsbuf, int fd);\n-\n+#include \"internal_statvfs.h\"\n \n int\n __fstatvfs (int fd, struct statvfs *buf)\ndiff --git a/sysdeps/unix/sysv/linux/fstatvfs64.c b/sysdeps/unix/sysv/linux/fstatvfs64.c\nindex 02a0d7ee42..c923208ea8 100644\n--- a/sysdeps/unix/sysv/linux/fstatvfs64.c\n+++ b/sysdeps/unix/sysv/linux/fstatvfs64.c\n@@ -20,14 +20,9 @@\n #include <string.h>\n #include <sys/stat.h>\n #include <sys/statfs.h>\n-#include <sys/statvfs.h>\n+#include \"internal_statvfs.h\"\n #include <kernel-features.h>\n \n-\n-extern void __internal_statvfs64 (const char *name, struct statvfs64 *buf,\n-\t\t\t\t struct statfs64 *fsbuf, int fd);\n-\n-\n /* Return information about the filesystem on which FD resides. */\n int\n __fstatvfs64 (int fd, struct statvfs64 *buf)\ndiff --git a/sysdeps/unix/sysv/linux/internal_statvfs.c b/sysdeps/unix/sysv/linux/internal_statvfs.c\nindex 9a17ca5c17..0a8dc35e16 100644\n--- a/sysdeps/unix/sysv/linux/internal_statvfs.c\n+++ b/sysdeps/unix/sysv/linux/internal_statvfs.c\n@@ -26,7 +26,7 @@\n #include <sys/mount.h>\n #include <sys/stat.h>\n #include <sys/statfs.h>\n-#include <sys/statvfs.h>\n+#include \"internal_statvfs.h\"\n #include \"linux_fsinfo.h\"\n #include <kernel-features.h>\n \ndiff --git a/sysdeps/unix/sysv/linux/internal_statvfs.h b/sysdeps/unix/sysv/linux/internal_statvfs.h\nnew file mode 100644\nindex 0000000000..1762bbc6c6\n--- /dev/null\n+++ b/sysdeps/unix/sysv/linux/internal_statvfs.h\n@@ -0,0 +1,26 @@\n+/* Internal statvfs/statvfs64 function prototypes.\n+ Copyright (C) 2017 Free Software Foundation, Inc.\n+ This file is part of the GNU C Library.\n+\n+ The GNU C Library is free software; you can redistribute it and/or\n+ modify it under the terms of the GNU Lesser General Public\n+ License as published by the Free Software Foundation; either\n+ version 2.1 of the License, or (at your option) any later version.\n+\n+ The GNU C Library is distributed in the hope that it will be useful,\n+ but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ Lesser General Public License for more details.\n+\n+ You should have received a copy of the GNU Lesser General Public\n+ License along with the GNU C Library; if not, see\n+ <http://www.gnu.org/licenses/>. */\n+\n+#include <sys/statvfs.h>\n+\n+extern void __internal_statvfs (const char *name, struct statvfs *buf,\n+\t\t\t\tstruct statfs *fsbuf, int fd)\n+ attribute_hidden;\n+extern void __internal_statvfs64 (const char *name, struct statvfs64 *buf,\n+\t\t\t\t struct statfs64 *fsbuf, int fd)\n+ attribute_hidden;\ndiff --git a/sysdeps/unix/sysv/linux/statvfs.c b/sysdeps/unix/sysv/linux/statvfs.c\nindex 744336e33b..1edf1acca9 100644\n--- a/sysdeps/unix/sysv/linux/statvfs.c\n+++ b/sysdeps/unix/sysv/linux/statvfs.c\n@@ -19,11 +19,7 @@\n #include <stddef.h>\n #include <sys/stat.h>\n #include <sys/statfs.h>\n-#include <sys/statvfs.h>\n-\n-extern void __internal_statvfs (const char *name, struct statvfs *buf,\n-\t\t\t\tstruct statfs *fsbuf, int fd);\n-\n+#include \"internal_statvfs.h\"\n \n int\n __statvfs (const char *file, struct statvfs *buf)\ndiff --git a/sysdeps/unix/sysv/linux/statvfs64.c b/sysdeps/unix/sysv/linux/statvfs64.c\nindex a89f720b38..005495fa20 100644\n--- a/sysdeps/unix/sysv/linux/statvfs64.c\n+++ b/sysdeps/unix/sysv/linux/statvfs64.c\n@@ -21,14 +21,9 @@\n #include <string.h>\n #include <sys/stat.h>\n #include <sys/statfs.h>\n-#include <sys/statvfs.h>\n+#include \"internal_statvfs.h\"\n #include <kernel-features.h>\n \n-\n-extern void __internal_statvfs64 (const char *name, struct statvfs64 *buf,\n-\t\t\t\t struct statfs64 *fsbuf, int fd);\n-\n-\n /* Return information about the filesystem on which FILE resides. */\n int\n __statvfs64 (const char *file, struct statvfs64 *buf)\n", "prefixes": [ "03/58" ] }