Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808831/?format=api
{ "id": 808831, "url": "http://patchwork.ozlabs.org/api/patches/808831/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/d64777dcf9079a8f997416b148b9cffbc14e0c49.1504228916.git.alistair.francis@xilinx.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<d64777dcf9079a8f997416b148b9cffbc14e0c49.1504228916.git.alistair.francis@xilinx.com>", "list_archive_url": null, "date": "2017-09-01T16:51:15", "name": "[v3,3/7] Convert single line fprintf(.../n) to warn_report()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1d15887c51def7a472acb3edb905f09b60f24f9d", "submitter": { "id": 47878, "url": "http://patchwork.ozlabs.org/api/people/47878/?format=api", "name": "Alistair Francis", "email": "alistair.francis@xilinx.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/d64777dcf9079a8f997416b148b9cffbc14e0c49.1504228916.git.alistair.francis@xilinx.com/mbox/", "series": [ { "id": 1078, "url": "http://patchwork.ozlabs.org/api/series/1078/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1078", "date": "2017-09-01T16:51:00", "name": "More warning reporting fixed", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/1078/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808831/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808831/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=xilinx.onmicrosoft.com\n\theader.i=@xilinx.onmicrosoft.com header.b=\"ECP3i6oE\"; \n\tdkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkQR46wxpz9t2x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 02:57:51 +1000 (AEST)", "from localhost ([::1]:50083 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnpGP-0008Fs-BS\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 12:57:49 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:50990)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <alistai@xilinx.com>) id 1dnpDi-0005pP-Gu\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 12:55:08 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <alistai@xilinx.com>) id 1dnpDf-00065T-Az\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 12:55:02 -0400", "from mail-sn1nam01on0050.outbound.protection.outlook.com\n\t([104.47.32.50]:9768\n\thelo=NAM01-SN1-obe.outbound.protection.outlook.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <alistai@xilinx.com>) id 1dnpDf-00065C-26\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 12:54:59 -0400", "from BY2PR02CA0008.namprd02.prod.outlook.com (10.163.44.146) by\n\tBN3PR02MB1128.namprd02.prod.outlook.com (10.162.168.146) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10; Fri, 1 Sep 2017 16:54:55 +0000", "from SN1NAM02FT019.eop-nam02.prod.protection.outlook.com\n\t(2a01:111:f400:7e44::206) by BY2PR02CA0008.outlook.office365.com\n\t(2a01:111:e400:5261::18) with Microsoft SMTP Server (version=TLS1_2, \n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via\n\tFrontend Transport; Fri, 1 Sep 2017 16:54:54 +0000", "from xsj-pvapsmtpgw01 (149.199.60.83) by\n\tSN1NAM02FT019.mail.protection.outlook.com (10.152.72.130) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11\n\tvia Frontend Transport; Fri, 1 Sep 2017 16:54:53 +0000", "from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01)\n\tby xsj-pvapsmtpgw01 with esmtp (Exim 4.63)\n\t(envelope-from <alistair.francis@xilinx.com>)\n\tid 1dnpDZ-0002aM-7N; Fri, 01 Sep 2017 09:54:53 -0700", "from [127.0.0.1] (helo=localhost)\n\tby xsj-pvapsmtp01 with smtp (Exim 4.63)\n\t(envelope-from <alistair.francis@xilinx.com>)\n\tid 1dnpDZ-0003eO-4D; Fri, 01 Sep 2017 09:54:53 -0700", "from xsj-pvapsmtp01 (smtp2.xilinx.com [149.199.38.66])\n\tby xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id\n\tv81GspmY028968; Fri, 1 Sep 2017 09:54:51 -0700", "from [172.19.2.220] (helo=localhost.localdomain)\n\tby xsj-pvapsmtp01 with esmtp (Exim 4.63)\n\t(envelope-from <alistair.francis@xilinx.com>)\n\tid 1dnpDX-0003dX-C8; Fri, 01 Sep 2017 09:54:51 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=xilinx.onmicrosoft.com; s=selector1-xilinx-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=ULf3fR2veRHyjzzXcEHwNaf8AuktwVuJrkSrYN1XS+g=;\n\tb=ECP3i6oEU3zLxNF7SgZBJSLnPpJ7Bh/1wBqwFGimn1J7EYYkjdzEGuIQrNi33BT9167G1OZqOS/GWRKfbLARThlOTGyVvsmagSZF9m6vUORh5xKBm5+Wzf1rAxXezHRjN9DMrbs/0vK12pI5j4YBN0PcWY1v+FGaLxyGGU/5qUQ=", "Received-SPF": "Pass (protection.outlook.com: domain of xilinx.com designates\n\t149.199.60.83 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=149.199.60.83; helo=xsj-pvapsmtpgw01;", "From": "Alistair Francis <alistair.francis@xilinx.com>", "To": "<qemu-devel@nongnu.org>", "Date": "Fri, 1 Sep 2017 09:51:15 -0700", "Message-ID": "<d64777dcf9079a8f997416b148b9cffbc14e0c49.1504228916.git.alistair.francis@xilinx.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<cover.1504228916.git.alistair.francis@xilinx.com>", "References": "<cover.1504228916.git.alistair.francis@xilinx.com>", "X-RCIS-Action": "ALLOW", "X-TM-AS-Product-Ver": "IMSS-7.1.0.1224-8.1.0.1062-23296.003", "X-TM-AS-User-Approved-Sender": "Yes;Yes", "X-EOPAttributedMessage": "0", "X-MS-Office365-Filtering-HT": "Tenant", "X-Forefront-Antispam-Report": "CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(199003)(189002)(106466001)(4326008)(626005)(2351001)(33646002)(8936002)(39060400002)(118296001)(47776003)(50226002)(6916009)(50986999)(356003)(76176999)(2950100002)(36386004)(63266004)(77096006)(54906002)(81166006)(9786002)(8676002)(2906002)(110136004)(5003940100001)(81156014)(36756003)(478600001)(48376002)(50466002)(305945005)(189998001)(7416002)(575784001)(6666003)(5660300001)(107986001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR02MB1128; H:xsj-pvapsmtpgw01;\n\tFPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en;", "X-Microsoft-Exchange-Diagnostics": [ "1; SN1NAM02FT019;\n\t1:DplZ94Ys1KF8T1TycEFUA8pxs1JwwMJmk3kZh7+Hrkj3VWxF7c3kQEZJCB5/B9OqRQO0jN/cMlDtEPi6Aebqy+1K7pJG0LOzgHPO7tckYu6oMLZiPrUsclu5OTR2pPOQ", "1; BN3PR02MB1128;\n\t3:TeD3SKWqF2LfegpDawH/Xk7hMD5vTzOUK3aDfuVNMgYaLsT1cyO+XiJqznhJS7kUopeuXb2RMnhKU5xflvxTRX/e1P31RtxWzx1IgZlaHGm8FQViCP2jJempVGykE/Z4HJ2ouo5U26eGwTcWIZhejDz8ezKwz7b/yDnfmWUdL+2iVkWR6lVo3su+5c14ouOY9dpU90IlsUKOnDd0R6aXn47KUN6mohTnf3p7sVsfeC2rqNhCY5sZmwzyc6z5wRTTdomtsRknqm96h1WlFJ2U5JZrx8r6N1CEEvGzki/f7WhSHj9alf8ZM1VuDXVwJD+LCi97noH4bvyxO2V5Kkdi0tEq5WM7urnoC3Qo2M7P7So=;\n\t25:zcTdEjKXz0QtezSl2FymZDTZleW+bk4s+jjQQfArqNiVYzufJbufmczfKOW90AIv6h49UAlXbpveCM9xP8lM+F9s7VPgNtbM0FfTqioKKUq/o49AwcuqvKcTfTVmd8DEaK64DnXZtXugQ0CgQJeWTKAlaB1AlaU4CQwRzOhaBUxPEabm1Texc4bVF1rJdIbynHOW7ABJrkpOd03wTkDJoz1KsC6M9T7yLGSw2ipJeseV6GHBGUGkB2wS9MX3hDuABQqSo9q33oUaYUfjcTq8ktDAEgh71AgIS5UfEVlMib+5I3X26CAaujVMe90O05S63Thbnf47UZo7T6aKFFh6fw==", "1; BN3PR02MB1128;\n\t31:A5+WRwHLNR5hABb7jGoFCrQnBBL7aS+drJaykydNWGrhdPW06S+RGadBBRAeNSKZJsYIotzw52VGeipUQEpzILqTXkHcyoxYrzxU35aB6/zd3Aea/hTLGMLByxPppGcX/RJ9oYse4BxaZ+FT/m33Qlq3naKx+jClFd9ejbntfnR+gQxYxld1jCcGmELtubprfAVEPpgRQrimn+NJ3D9ETfAmDa/STmsWtxLWicZi4mg=;\n\t20:PIYxCz3Mav7Yoq/sp40EWqqs0mWXS2PuyO/OxYlB2WGkoms7oXECQkSljcBCdvmIe40m4bhsRbpW6TeMgccH7lJ1t+V3rbx+fqTAK6Kk2ZWfhKn/0pwsgOcx5qQrKUL30WKnFkils5O6wjIbIq+1haPts7DLim1oFElRfawmt93Q/HqdlVkn0g/KA/RfpRGR7Wa3wZoKs+aSkXtIklkV7EVZsY4a8gHeH37mMXufrXEx91PKtikjjEXlSutIxKMhRUa3g92v1LCKHuYm3TM7/F4LgtmyHF8c0ovN2RJ8uSdRUubSOnyJ/tVtIpTbfluCa5K0dbniaUMhi6dmGVG6Xr0UwcI1JEex37Jtxiyf0IzXhJI1Tdsse/d6/x2Ulrcbjm56HmmOtCN1/aed6NX4q6DF6FbiMuXSaY8rX23bGQ2l5a5kZ02L8OcMk8xt2a4v+grMnjelFOQL6gTUIqMQgXBnoB9QicpgQzMQVFEkiVXA9D5JvghAjh0qin4nYlFV", "1; BN3PR02MB1128;\n\t4:XBdCGdf5eLLt+01HYeDg87KIskpHNCdyHz9b6EUyGqy2gwFT+x/v//OwM79bAlx1C6XSdfUidHzfd3m7g4iOpU1XGQ3Y8/9uqhLgKy4WDv99PCGggHxEDtbBPBEBd1HoFyXXciWuO8J2crQP2jyl5dWe3tXrsv7u7zGd0nKaXmkFtBQLIbHZ57UEmZCU/NnJ22e9i5qX+r0fLv8RYqOHdbotHIQTrdFl/Sbm/wYiAQWYJ5mMpyZB+R4Q7wkCu8AmcZCugmSooVFsai748Z9GWdZx12/9SlyUT7b5P/2tirZeo7hZ02loNktp45tBIK6oEckJx3NP44FC9wzeAVri5A==", "=?us-ascii?Q?1; BN3PR02MB1128;\n\t23:gaB/QcFietl6hizjwqegQu9nA6PmsnqsmbfM2xi+p?=\n\tfZ6/eH4ni+AnL1IXAG9OTmVARQZOpZJJZVkNtxdV4KFHWFYO0l79Tg7mpeRTBpNTpdIAhwTOHNOOr9JP9DlCD003Ord48n127n5iqlc5QmiVdEYVoz4Pk56GgcOR2CSz+Gptd9QicMJ6AcbJBxh80TPmsEcrmuilDeEz+Wb7HR8XRhlo3yk2hXRtyQplD4ckBC0ztkZd4DtiEXSNHfDGeHI/NigbKVvY11VCQeHHQvdfBOsFcU4dTqAYH+19vryPJzQeA/H9/SSaDVGn0DeskpJZbgbLJ9s+LEdRg+/5soreCk/L9eiOhg40kHblRSAa+aJrihgB8kMkTKKWJGrJJAxRcXqUoLBkFIk5woC4ZjenK65goASVTfEJQVedwBIE9ag6HUc73SXmkw0ykxlkQARlLl4gKcxVMEnYnXPauWXsMl9ONtYQUEF4M63MeP2jPaMPywtvsdDJDdGgI/Z613AHHb6itSMqACoa0xS46xDxvaGL0G4hYX1vGxQwF8ffwaC46251Ipzm9SGvuKKdhYhl6EiaIYbHFFUqQVWu6kypHstWe5AyDdRd6FKNc67V70oYv+t47sCAU8Q+eA7feKJD1aQZrbAcvh/U12FOH++NFJaK28yT8P4xsdRd4G7ODxHQa9aGF+qbh6LkyNx82gZPigmwNtUPIG9tO3L9BCrmyjpE9XIOEJgLbCiBTm9sU+EdplBR4AwqajPU+r6+lq3J1HfcOnc7jauXKumJa05TsZwKMLRuJ8JVG+cU6q8bZOWYzvEUW5FkeQyJ0GZKyo1ASmjFoaiBqAvBoIkEtUxG3Q9XSDsvfLsTef66BR9C8xEYqWUy1NJBY7a5Yl2ILuLJBRNnV7MNuPW9CfzBpVjQTyixfKhqNHrLFkbc+kYl8+N01Z8Cg4WTmiCcyU84Nxgg2hwhVxJ8q/Ug5hgFo+c/iSAlfTcwZPgNMTI5tYghL4Z1w6rEdVEhN2XglhU3TFlPuX3WQbM3EiaV0Kl/j3cISjYfibmV3i4OwI+S8yt8BY=", "1; BN3PR02MB1128;\n\t6:f/XWhVl5zBVGocwgc7B/4lbORO8/MyZHW1p6Avm4rSoLdSnvt2vqurl8kV6z1QIxlFwrZrioqrrBR+aG/I1s/J/FyW5WluK2v01+p3vUg+J4pLZlemdmwwirOIdkHYE8a9gkSeN9GZBq6yNAy9vzmfIYtnbWsKjUC3SoLSTSNkIqb+7rj7XFLOW2RSLtr+4i98g0cAixHb5O3H0CyeH4KvVaqjd356EJ6G5wYk9xfa1L09r+765ZZJnBHGqoiAY5RKhR6qDpuwE3/IalRZkfHT7IfSbU50HLUMksZMH+4JSt8D6+fvkhC+1KiqGaRnvyUNYUd6evrw3XIOooQpz1WA==;\n\t5:oSZLRd8M/bOo0ijDZtdwC83b5yz5bUHY6gomUvHiMuu+Y1UsLSADV1Q24I5RG4Q8RiPfE1vJSsWp+IcB1TnTSf3Ja+9XdDfinYkTZj4sPUcFYc0+oqOudnSb0+MkqSLo0jZGcDV7bkBPF01QweRiZA==;\n\t24:3iw7ZP3eLmCyhf9Q5weKZBq6zJopwiAeXoHo9atmiCprPmTOnMp7VnCUGyAZwyFyxj568b/i5srTFTGvXThF4t2IF+tridF4bA/QXYLoU2s=;\n\t7:WAwTxmjNqU+heIQKkCc353um3uw4lBe9gkz7dvZsCwOUXkQ+sQnFmVQIycKWfwr3IZ8QKL5CZyiCFvCaThn9ihQCrwh1SFSO5kK3PHPbX+hq8se3MieU77VP86pW5jkUGj7Q1WYlgAcPTJTJnieayeofbXFkWbEHT8HbQs/GMEUPyGk64QP5ZAcWOPJarzP45Vq2UeF+kKS4et1ilj+by4Z3EdViXBbkOvoJ6Vq/j2Y=" ], "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "973e2d84-3255-4c71-13f4-08d4f15a2b77", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BN3PR02MB1128; ", "X-MS-TrafficTypeDiagnostic": "BN3PR02MB1128:", "X-Exchange-Antispam-Report-Test": "UriScan:(192813158149592)(104084551191319); ", "X-Microsoft-Antispam-PRVS": "<BN3PR02MB11283E2603E1F1F7AC054125DC920@BN3PR02MB1128.namprd02.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(13018025)(13016025)(100000703101)(100105400095)(93006095)(93004095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BN3PR02MB1128; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BN3PR02MB1128; ", "X-Forefront-PRVS": "0417A3FFD2", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "xilinx.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "01 Sep 2017 16:54:53.7313\n\t(UTC)", "X-MS-Exchange-CrossTenant-Id": "657af505-d5df-48d0-8300-c31994686c5c", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=657af505-d5df-48d0-8300-c31994686c5c; \n\tIp=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01]", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN3PR02MB1128", "X-detected-operating-system": "by eggs.gnu.org: Windows 7 or 8 [fuzzy]", "X-Received-From": "104.47.32.50", "Subject": "[Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n) to\n\twarn_report()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, James Hogan <james.hogan@imgtec.com>,\n\tEduardo Habkost <ehabkost@redhat.com>,\n\t\"Michael S. Tsirkin\" <mst@redhat.com>,\n\tJason Wang <jasowang@redhat.com>, armbru@redhat.com,\n\tMax Reitz <mreitz@redhat.com>, Igor Mammedov <imammedo@redhat.com>,\n\tGerd Hoffmann <kraxel@redhat.com>,\n\tStefan Hajnoczi <stefanha@redhat.com>, pbonzini@redhat.com,\n\tYongbok Kim <yongbok.kim@imgtec.com>, alistair23@gmail.com,\n\talistair.francis@xilinx.com, Michael Roth <mdroth@linux.vnet.ibm.com>,\n\tAurelien Jarno <aurelien@aurel32.net>,\n\tRichard Henderson <rth@twiddle.net>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Convert all the single line uses of fprintf(stderr, \"warning:\"...\"\\n\"...\nto use warn_report() instead. This helps standardise on a single\nmethod of printing warnings to the user.\n\nAll of the warnings were changed using this command:\n find ./* -type f -exec sed -i \\\n 's|fprintf(.*\".*warning[,:] \\(.*\\)\\\\n\"\\(.*\\));|warn_report(\"\\1\"\\2);|Ig' \\\n {} +\n\nSome of the lines were manually edited to reduce the line length to below\n80 charecters.\n\nThe #include lines were manually updated to allow the code to compile.\n\nSigned-off-by: Alistair Francis <alistair.francis@xilinx.com>\nCc: Kevin Wolf <kwolf@redhat.com>\nCc: Max Reitz <mreitz@redhat.com>\nCc: \"Michael S. Tsirkin\" <mst@redhat.com>\nCc: Igor Mammedov <imammedo@redhat.com>\nCc: Paolo Bonzini <pbonzini@redhat.com>\nCc: Richard Henderson <rth@twiddle.net>\nCc: Eduardo Habkost <ehabkost@redhat.com>\nCc: Gerd Hoffmann <kraxel@redhat.com>\nCc: Jason Wang <jasowang@redhat.com>\nCc: Michael Roth <mdroth@linux.vnet.ibm.com>\nCc: James Hogan <james.hogan@imgtec.com>\nCc: Aurelien Jarno <aurelien@aurel32.net>\nCc: Yongbok Kim <yongbok.kim@imgtec.com>\nCc: Stefan Hajnoczi <stefanha@redhat.com>\nReviewed-by: Markus Armbruster <armbru@redhat.com>\n---\n\n block/vvfat.c | 4 +++-\n hw/acpi/core.c | 3 ++-\n hw/i386/pc.c | 2 +-\n hw/misc/applesmc.c | 2 +-\n hw/usb/hcd-ehci.c | 5 +++--\n hw/virtio/virtio-balloon.c | 3 ++-\n net/hub.c | 3 ++-\n net/socket.c | 7 +++++--\n qga/vss-win32.c | 2 +-\n target/mips/kvm.c | 4 ++--\n trace/simple.c | 3 ++-\n ui/keymaps.c | 2 +-\n ui/spice-display.c | 2 +-\n 13 files changed, 26 insertions(+), 16 deletions(-)", "diff": "diff --git a/block/vvfat.c b/block/vvfat.c\nindex a9e207f7f0..d682f0a9dc 100644\n--- a/block/vvfat.c\n+++ b/block/vvfat.c\n@@ -32,6 +32,7 @@\n #include \"qapi/qmp/qbool.h\"\n #include \"qapi/qmp/qstring.h\"\n #include \"qemu/cutils.h\"\n+#include \"qemu/error-report.h\"\n \n #ifndef S_IWGRP\n #define S_IWGRP 0\n@@ -3028,7 +3029,8 @@ DLOG(checkpoint());\n if (memcmp(direntries + k,\n array_get(&(s->directory), dir_index + k),\n sizeof(direntry_t))) {\n- fprintf(stderr, \"Warning: tried to write to write-protected file\\n\");\n+ warn_report(\"tried to write to write-protected \"\n+ \"file\");\n return -1;\n }\n }\ndiff --git a/hw/acpi/core.c b/hw/acpi/core.c\nindex 95fcac95a2..2a1b79c838 100644\n--- a/hw/acpi/core.c\n+++ b/hw/acpi/core.c\n@@ -28,6 +28,7 @@\n #include \"qapi/opts-visitor.h\"\n #include \"qapi-visit.h\"\n #include \"qapi-event.h\"\n+#include \"qemu/error-report.h\"\n \n struct acpi_table_header {\n uint16_t _length; /* our length, not actual part of the hdr */\n@@ -221,7 +222,7 @@ static void acpi_table_install(const char unsigned *blob, size_t bloblen,\n }\n \n if (!has_header && changed_fields == 0) {\n- fprintf(stderr, \"warning: ACPI table: no headers are specified\\n\");\n+ warn_report(\"ACPI table: no headers are specified\");\n }\n \n /* recalculate checksum */\ndiff --git a/hw/i386/pc.c b/hw/i386/pc.c\nindex c882f8c2ea..ef5f30e644 100644\n--- a/hw/i386/pc.c\n+++ b/hw/i386/pc.c\n@@ -1310,7 +1310,7 @@ void pc_acpi_init(const char *default_dsdt)\n \n filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);\n if (filename == NULL) {\n- fprintf(stderr, \"WARNING: failed to find %s\\n\", default_dsdt);\n+ warn_report(\"failed to find %s\", default_dsdt);\n } else {\n QemuOpts *opts = qemu_opts_create(qemu_find_opts(\"acpi\"), NULL, 0,\n &error_abort);\ndiff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c\nindex 7896812304..7be8b5f13c 100644\n--- a/hw/misc/applesmc.c\n+++ b/hw/misc/applesmc.c\n@@ -331,7 +331,7 @@ static void applesmc_isa_realize(DeviceState *dev, Error **errp)\n s->iobase + APPLESMC_ERR_PORT);\n \n if (!s->osk || (strlen(s->osk) != 64)) {\n- fprintf(stderr, \"WARNING: Using AppleSMC with invalid key\\n\");\n+ warn_report(\"Using AppleSMC with invalid key\");\n s->osk = default_osk;\n }\n \ndiff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c\nindex 604912cb3e..46fd30b075 100644\n--- a/hw/usb/hcd-ehci.c\n+++ b/hw/usb/hcd-ehci.c\n@@ -32,6 +32,7 @@\n #include \"hw/usb/ehci-regs.h\"\n #include \"hw/usb/hcd-ehci.h\"\n #include \"trace.h\"\n+#include \"qemu/error-report.h\"\n \n #define FRAME_TIMER_FREQ 1000\n #define FRAME_TIMER_NS (NANOSECONDS_PER_SECOND / FRAME_TIMER_FREQ)\n@@ -348,7 +349,7 @@ static void ehci_trace_sitd(EHCIState *s, hwaddr addr,\n static void ehci_trace_guest_bug(EHCIState *s, const char *message)\n {\n trace_usb_ehci_guest_bug(message);\n- fprintf(stderr, \"ehci warning: %s\\n\", message);\n+ warn_report(\"%s\", message);\n }\n \n static inline bool ehci_enabled(EHCIState *s)\n@@ -1728,7 +1729,7 @@ static int ehci_state_fetchsitd(EHCIState *ehci, int async)\n /* siTD is not active, nothing to do */;\n } else {\n /* TODO: split transfers are not implemented */\n- fprintf(stderr, \"WARNING: Skipping active siTD\\n\");\n+ warn_report(\"Skipping active siTD\");\n }\n \n ehci_set_fetch_addr(ehci, async, sitd.next);\ndiff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c\nindex a705e0ec55..37cde38982 100644\n--- a/hw/virtio/virtio-balloon.c\n+++ b/hw/virtio/virtio-balloon.c\n@@ -26,6 +26,7 @@\n #include \"qapi/visitor.h\"\n #include \"qapi-event.h\"\n #include \"trace.h\"\n+#include \"qemu/error-report.h\"\n \n #include \"hw/virtio/virtio-bus.h\"\n #include \"hw/virtio/virtio-access.h\"\n@@ -292,7 +293,7 @@ static void virtio_balloon_receive_stats(VirtIODevice *vdev, VirtQueue *vq)\n s->stats_vq_offset = offset;\n \n if (qemu_gettimeofday(&tv) < 0) {\n- fprintf(stderr, \"warning: %s: failed to get time of day\\n\", __func__);\n+ warn_report(\"%s: failed to get time of day\", __func__);\n goto out;\n }\n \ndiff --git a/net/hub.c b/net/hub.c\nindex 32d8cf5cd4..afe941ae7a 100644\n--- a/net/hub.c\n+++ b/net/hub.c\n@@ -18,6 +18,7 @@\n #include \"clients.h\"\n #include \"hub.h\"\n #include \"qemu/iov.h\"\n+#include \"qemu/error-report.h\"\n \n /*\n * A hub broadcasts incoming packets to all its ports except the source port.\n@@ -330,7 +331,7 @@ void net_hub_check_clients(void)\n }\n }\n if (has_host_dev && !has_nic) {\n- fprintf(stderr, \"Warning: vlan %d with no nics\\n\", hub->id);\n+ warn_report(\"vlan %d with no nics\", hub->id);\n }\n if (has_nic && !has_host_dev) {\n fprintf(stderr,\ndiff --git a/net/socket.c b/net/socket.c\nindex 18af2ab5f3..daea750644 100644\n--- a/net/socket.c\n+++ b/net/socket.c\n@@ -448,8 +448,11 @@ static NetSocketState *net_socket_fd_init(NetClientState *peer,\n case SOCK_STREAM:\n return net_socket_fd_init_stream(peer, model, name, fd, is_connected);\n default:\n- /* who knows ... this could be a eg. a pty, do warn and continue as stream */\n- fprintf(stderr, \"qemu: warning: socket type=%d for fd=%d is not SOCK_DGRAM or SOCK_STREAM\\n\", so_type, fd);\n+ /* who knows ... this could be a eg. a pty, do warn and continue as\n+ * stream\n+ */\n+ warn_report(\"socket type=%d for fd=%d is not SOCK_DGRAM or \"\n+ \"SOCK_STREAM\", so_type, fd);\n return net_socket_fd_init_stream(peer, model, name, fd, is_connected);\n }\n return NULL;\ndiff --git a/qga/vss-win32.c b/qga/vss-win32.c\nindex a80933c98b..b748b9ff57 100644\n--- a/qga/vss-win32.c\n+++ b/qga/vss-win32.c\n@@ -61,7 +61,7 @@ static bool vss_check_os_version(void)\n return false;\n }\n if (wow64) {\n- fprintf(stderr, \"Warning: Running under WOW64\\n\");\n+ warn_report(\"Running under WOW64\");\n }\n #endif\n return !wow64;\ndiff --git a/target/mips/kvm.c b/target/mips/kvm.c\nindex 3317905e71..a23aa438d2 100644\n--- a/target/mips/kvm.c\n+++ b/target/mips/kvm.c\n@@ -95,11 +95,11 @@ void kvm_mips_reset_vcpu(MIPSCPU *cpu)\n CPUMIPSState *env = &cpu->env;\n \n if (!kvm_mips_fpu_cap && env->CP0_Config1 & (1 << CP0C1_FP)) {\n- fprintf(stderr, \"Warning: KVM does not support FPU, disabling\\n\");\n+ warn_report(\"KVM does not support FPU, disabling\");\n env->CP0_Config1 &= ~(1 << CP0C1_FP);\n }\n if (!kvm_mips_msa_cap && env->CP0_Config3 & (1 << CP0C3_MSAP)) {\n- fprintf(stderr, \"Warning: KVM does not support MSA, disabling\\n\");\n+ warn_report(\"KVM does not support MSA, disabling\");\n env->CP0_Config3 &= ~(1 << CP0C3_MSAP);\n }\n \ndiff --git a/trace/simple.c b/trace/simple.c\nindex a221a3f703..e82018d923 100644\n--- a/trace/simple.c\n+++ b/trace/simple.c\n@@ -15,6 +15,7 @@\n #include \"qemu/timer.h\"\n #include \"trace/control.h\"\n #include \"trace/simple.h\"\n+#include \"qemu/error-report.h\"\n \n /** Trace file header event ID, picked to avoid conflict with real event IDs */\n #define HEADER_EVENT_ID (~(uint64_t)0)\n@@ -405,7 +406,7 @@ bool st_init(void)\n \n thread = trace_thread_create(writeout_thread);\n if (!thread) {\n- fprintf(stderr, \"warning: unable to initialize simple trace backend\\n\");\n+ warn_report(\"unable to initialize simple trace backend\");\n return false;\n }\n \ndiff --git a/ui/keymaps.c b/ui/keymaps.c\nindex fa00b82027..7fa21f81b2 100644\n--- a/ui/keymaps.c\n+++ b/ui/keymaps.c\n@@ -141,7 +141,7 @@ static kbd_layout_t *parse_keyboard_layout(const name2keysym_t *table,\n int keysym;\n keysym = get_keysym(table, keyname);\n if (keysym == 0) {\n- /* fprintf(stderr, \"Warning: unknown keysym %s\\n\", line);*/\n+ /* warn_report(\"unknown keysym %s\", line);*/\n } else {\n const char *rest = line + offset + 1;\n int keycode = strtol(rest, NULL, 0);\ndiff --git a/ui/spice-display.c b/ui/spice-display.c\nindex 042292cc90..0963c7825f 100644\n--- a/ui/spice-display.c\n+++ b/ui/spice-display.c\n@@ -850,7 +850,7 @@ static void qemu_spice_gl_unblock_bh(void *opaque)\n \n static void qemu_spice_gl_block_timer(void *opaque)\n {\n- fprintf(stderr, \"WARNING: spice: no gl-draw-done within one second\\n\");\n+ warn_report(\"spice: no gl-draw-done within one second\");\n }\n \n static void spice_gl_refresh(DisplayChangeListener *dcl)\n", "prefixes": [ "v3", "3/7" ] }