Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808756/?format=api
{ "id": 808756, "url": "http://patchwork.ozlabs.org/api/patches/808756/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-43-armbru@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901153758.8628-43-armbru@redhat.com>", "list_archive_url": null, "date": "2017-09-01T15:37:53", "name": "[PULL,v2,42/47] qapi: Avoid unnecessary use of enum lookup table's sentinel", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c8880cb173041cbf66ba5371fa67e93627cfbb0a", "submitter": { "id": 2645, "url": "http://patchwork.ozlabs.org/api/people/2645/?format=api", "name": "Markus Armbruster", "email": "armbru@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901153758.8628-43-armbru@redhat.com/mbox/", "series": [ { "id": 1049, "url": "http://patchwork.ozlabs.org/api/series/1049/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1049", "date": "2017-09-01T15:37:14", "name": "[PULL,v2,01/47] qapi: Fix error handling code on alternate conflict", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/1049/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808756/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808756/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkP3p5Tpbz9t3p\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 01:56:06 +1000 (AEST)", "from localhost ([::1]:46566 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnoIe-0007FG-1u\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 11:56:04 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:51597)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1dno1O-0006fz-UL\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:19 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1dno1M-0001k0-RQ\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:14 -0400", "from mx1.redhat.com ([209.132.183.28]:36759)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1dno1M-0001is-Kf\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:38:12 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AA65B404322\n\tfor <qemu-devel@nongnu.org>; Fri, 1 Sep 2017 15:38:11 +0000 (UTC)", "from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 7344281FB6\n\tfor <qemu-devel@nongnu.org>; Fri, 1 Sep 2017 15:38:11 +0000 (UTC)", "by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid BE2531132F4B; Fri, 1 Sep 2017 17:37:58 +0200 (CEST)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com AA65B404322", "From": "Markus Armbruster <armbru@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 1 Sep 2017 17:37:53 +0200", "Message-Id": "<20170901153758.8628-43-armbru@redhat.com>", "In-Reply-To": "<20170901153758.8628-1-armbru@redhat.com>", "References": "<20170901153758.8628-1-armbru@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 01 Sep 2017 15:38:11 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL v2 42/47] qapi: Avoid unnecessary use of enum\n\tlookup table's sentinel", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Currently, the FOO_lookup[] generated for QAPI enum types are\nterminated by a NULL sentinel.\n\nA future patch will generate enums with \"holes\". NULL-termination\nwill cease to work then.\n\nTo prepare for that, replace \"have we reached the sentinel?\"\npredicates by \"have we reached the FOO__MAX value?\" predicates.\n\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\nMessage-Id: <1503564371-26090-12-git-send-email-armbru@redhat.com>\nReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n monitor.c | 4 ++--\n tests/test-qobject-input-visitor.c | 2 +-\n tests/test-string-input-visitor.c | 2 +-\n ui/input-legacy.c | 2 +-\n 4 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/monitor.c b/monitor.c\nindex 135ec2de8f..86438f4b75 100644\n--- a/monitor.c\n+++ b/monitor.c\n@@ -3249,7 +3249,7 @@ void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str)\n }\n len = strlen(str);\n readline_set_completion_index(rs, len);\n- for (i = 0; NetClientDriver_lookup[i]; i++) {\n+ for (i = 0; i < NET_CLIENT_DRIVER__MAX; i++) {\n add_completion_option(rs, str, NetClientDriver_lookup[i]);\n }\n }\n@@ -3537,7 +3537,7 @@ void watchdog_action_completion(ReadLineState *rs, int nb_args, const char *str)\n return;\n }\n readline_set_completion_index(rs, strlen(str));\n- for (i = 0; WatchdogExpirationAction_lookup[i]; i++) {\n+ for (i = 0; i < WATCHDOG_EXPIRATION_ACTION__MAX; i++) {\n add_completion_option(rs, str, WatchdogExpirationAction_lookup[i]);\n }\n }\ndiff --git a/tests/test-qobject-input-visitor.c b/tests/test-qobject-input-visitor.c\nindex bcf02617dc..5bbfb65a02 100644\n--- a/tests/test-qobject-input-visitor.c\n+++ b/tests/test-qobject-input-visitor.c\n@@ -382,7 +382,7 @@ static void test_visitor_in_enum(TestInputVisitorData *data,\n Visitor *v;\n EnumOne i;\n \n- for (i = 0; EnumOne_lookup[i]; i++) {\n+ for (i = 0; i < ENUM_ONE__MAX; i++) {\n EnumOne res = -1;\n \n v = visitor_input_test_init(data, \"%s\", EnumOne_lookup[i]);\ndiff --git a/tests/test-string-input-visitor.c b/tests/test-string-input-visitor.c\nindex 79313a7f7a..e7a7b80c92 100644\n--- a/tests/test-string-input-visitor.c\n+++ b/tests/test-string-input-visitor.c\n@@ -279,7 +279,7 @@ static void test_visitor_in_enum(TestInputVisitorData *data,\n Visitor *v;\n EnumOne i;\n \n- for (i = 0; EnumOne_lookup[i]; i++) {\n+ for (i = 0; i < ENUM_ONE__MAX; i++) {\n EnumOne res = -1;\n \n v = visitor_input_test_init(data, EnumOne_lookup[i]);\ndiff --git a/ui/input-legacy.c b/ui/input-legacy.c\nindex 7159747404..a5f1e829c3 100644\n--- a/ui/input-legacy.c\n+++ b/ui/input-legacy.c\n@@ -61,7 +61,7 @@ int index_from_key(const char *key, size_t key_length)\n {\n int i;\n \n- for (i = 0; QKeyCode_lookup[i] != NULL; i++) {\n+ for (i = 0; i < Q_KEY_CODE__MAX; i++) {\n if (!strncmp(key, QKeyCode_lookup[i], key_length) &&\n !QKeyCode_lookup[i][key_length]) {\n break;\n", "prefixes": [ "PULL", "v2", "42/47" ] }