Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808698/?format=api
{ "id": 808698, "url": "http://patchwork.ozlabs.org/api/patches/808698/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170901140234.7840-3-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901140234.7840-3-sassmann@kpanic.de>", "list_archive_url": null, "date": "2017-09-01T14:02:34", "name": "[2/2] Revert \"i40e: remove WQ_UNBOUND and the task limit of our workqueue\"", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "68d4e80c38ba737adfe3b914ebd561565c7bd7e0", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170901140234.7840-3-sassmann@kpanic.de/mbox/", "series": [ { "id": 1036, "url": "http://patchwork.ozlabs.org/api/series/1036/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=1036", "date": "2017-09-01T14:02:34", "name": "i40e: fix firmware update", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1036/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808698/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808698/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=kpanic.de", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=none smtp.mailfrom=sassmann@kpanic.de" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkLg41t7dz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 00:07:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 20CB188EC3;\n\tFri, 1 Sep 2017 14:07:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cJoXjEig-JD9; Fri, 1 Sep 2017 14:07:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6C71B88EA3;\n\tFri, 1 Sep 2017 14:07:57 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E2C911C0306\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Sep 2017 14:07:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DB0B488201\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Sep 2017 14:07:55 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ZeIFzKxsfQ05 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Sep 2017 14:07:55 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 14749881FA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Sep 2017 14:07:54 +0000 (UTC)", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DEEC77F350;\n\tFri, 1 Sep 2017 14:02:47 +0000 (UTC)", "from w541.redhat.com (ovpn-116-204.ams2.redhat.com [10.36.116.204])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9DB5981F80;\n\tFri, 1 Sep 2017 14:02:46 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "from auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]); Fri, 01 Sep 2017 14:02:48 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com DEEC77F350", "DKIM-Filter": "OpenDKIM Filter v2.11.0 mx1.redhat.com DEEC77F350", "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 1 Sep 2017 16:02:34 +0200", "Message-Id": "<20170901140234.7840-3-sassmann@kpanic.de>", "In-Reply-To": "<20170901140234.7840-1-sassmann@kpanic.de>", "References": "<20170901140234.7840-1-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH 2/2] Revert \"i40e: remove WQ_UNBOUND and\n\tthe task limit of our workqueue\"", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This reverts commit 4d5957cbdecdbb77d24c1465caadd801c07afa4a.\n\nDue to this workqueue change the eeprom check right after flashing\nfirmware fails, although the flash itself completed successfully.\nThe error observed looks like this\ni40e 0000:88:00.0: eeprom check failed (-62), Tx/Rx traffic disabled\nThe NIC is fully operational after the flash and even after a cold boot\nany follow-up eeprom checks succeed.\n\nThis needs to be investigated, but for now it should be more important\nto make sure the firmware update works as expected.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 6498da8806cb..069b6683e1b0 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -12160,14 +12160,12 @@ static int __init i40e_init_module(void)\n \t\ti40e_driver_string, i40e_driver_version_str);\n \tpr_info(\"%s: %s\\n\", i40e_driver_name, i40e_copyright);\n \n-\t/* There is no need to throttle the number of active tasks because\n-\t * each device limits its own task using a state bit for scheduling\n-\t * the service task, and the device tasks do not interfere with each\n-\t * other, so we don't set a max task limit. We must set WQ_MEM_RECLAIM\n-\t * since we need to be able to guarantee forward progress even under\n-\t * memory pressure.\n+\t/* we will see if single thread per module is enough for now,\n+\t * it can't be any worse than using the system workqueue which\n+\t * was already single threaded\n \t */\n-\ti40e_wq = alloc_workqueue(\"%s\", WQ_MEM_RECLAIM, 0, i40e_driver_name);\n+\ti40e_wq = alloc_workqueue(\"%s\", WQ_UNBOUND | WQ_MEM_RECLAIM, 1,\n+\t\t\t\t i40e_driver_name);\n \tif (!i40e_wq) {\n \t\tpr_err(\"%s: Failed to create workqueue\\n\", i40e_driver_name);\n \t\treturn -ENOMEM;\n", "prefixes": [ "2/2" ] }