Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 808608,
    "url": "http://patchwork.ozlabs.org/api/patches/808608/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504258863-2058-2-git-send-email-claudiu.manoil@nxp.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1504258863-2058-2-git-send-email-claudiu.manoil@nxp.com>",
    "list_archive_url": null,
    "date": "2017-09-01T09:41:01",
    "name": "[net,1/3] gianfar: Fix Tx flow control deactivation",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "0e0f68b3f18f00eed9db33de089e6881182d14fd",
    "submitter": {
        "id": 68115,
        "url": "http://patchwork.ozlabs.org/api/people/68115/?format=api",
        "name": "Claudiu Manoil",
        "email": "claudiu.manoil@nxp.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504258863-2058-2-git-send-email-claudiu.manoil@nxp.com/mbox/",
    "series": [
        {
            "id": 987,
            "url": "http://patchwork.ozlabs.org/api/series/987/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=987",
            "date": "2017-09-01T09:41:00",
            "name": "gianfar: Tx flow control fix (adjust_link)",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/987/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/808608/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/808608/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "spf=fail (sender IP is 192.88.158.2)\n\tsmtp.mailfrom=nxp.com; kernel.org; dkim=none (message not signed)\n\theader.d=none; kernel.org; dmarc=fail action=none header.from=nxp.com;"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkDlH5Kg6z9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  1 Sep 2017 19:41:15 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751843AbdIAJlN (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 1 Sep 2017 05:41:13 -0400",
            "from mail-sn1nam02on0069.outbound.protection.outlook.com\n\t([104.47.36.69]:23590\n\t\"EHLO NAM02-SN1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751823AbdIAJlK (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tFri, 1 Sep 2017 05:41:10 -0400",
            "from BN3PR03CA0112.namprd03.prod.outlook.com (10.174.66.30) by\n\tCY4PR03MB3318.namprd03.prod.outlook.com (10.171.246.151) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10; Fri, 1 Sep 2017 09:41:08 +0000",
            "from BY2FFO11FD029.protection.gbl (2a01:111:f400:7c0c::170) by\n\tBN3PR03CA0112.outlook.office365.com (2603:10b6:400:4::30) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.13.10 via Frontend Transport; Fri, 1 Sep 2017 09:41:08 +0000",
            "from az84smr01.freescale.net (192.88.158.2) by\n\tBY2FFO11FD029.mail.protection.outlook.com (10.1.14.212) with\n\tMicrosoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11\n\tvia Frontend Transport; Fri, 1 Sep 2017 09:41:07 +0000",
            "from fsr-ub1664-016.ea.freescale.net\n\t(fsr-ub1664-016.ea.freescale.net [10.171.71.216])\n\tby az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id\n\tv819f4Jx024510; Fri, 1 Sep 2017 02:41:06 -0700"
        ],
        "Received-SPF": "Fail (protection.outlook.com: domain of nxp.com does not\n\tdesignate 192.88.158.2 as permitted sender)\n\treceiver=protection.outlook.com; \n\tclient-ip=192.88.158.2; helo=az84smr01.freescale.net;",
        "From": "Claudiu Manoil <claudiu.manoil@nxp.com>",
        "To": "<netdev@vger.kernel.org>",
        "CC": "\"David S . Miller\" <davem@davemloft.net>, <stable@kernel.org>",
        "Subject": "[net 1/3] gianfar: Fix Tx flow control deactivation",
        "Date": "Fri, 1 Sep 2017 12:41:01 +0300",
        "Message-ID": "<1504258863-2058-2-git-send-email-claudiu.manoil@nxp.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1504258863-2058-1-git-send-email-claudiu.manoil@nxp.com>",
        "References": "<1504258863-2058-1-git-send-email-claudiu.manoil@nxp.com>",
        "X-EOPAttributedMessage": "0",
        "X-Matching-Connectors": "131487324678516371;\n\t(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()",
        "X-Forefront-Antispam-Report": "CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI;\n\tSFV:NSPM;\n\tSFS:(10009020)(979002)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(47776003)(6666003)(2950100002)(5003940100001)(104016004)(77096006)(626005)(50226002)(2906002)(85426001)(305945005)(4326008)(36756003)(110136004)(5660300001)(54906002)(575784001)(86362001)(498600001)(53936002)(105606002)(106466001)(69596002)(8676002)(189998001)(81166006)(2351001)(81156014)(68736007)(97736004)(6916009)(50466002)(50986999)(76176999)(356003)(8936002)(48376002)(33646002)(969003)(989001)(999001)(1009001)(1019001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB3318;\n\tH:az84smr01.freescale.net; FPR:; SPF:Fail;\n\tPTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; ",
        "X-Microsoft-Exchange-Diagnostics": [
            "1; BY2FFO11FD029;\n\t1:1+iRWwgBb4esDhcqzAfYu8wEMvfWhVhAuZyuuEuxm/4ns5qbcK4OiIVPD2an3iVMJ2Bm7bzmFsBjHeeZFc/CT+D4BQFmoHN4tx9qwE2MkzC5zNKz3DaOu/ZHuYUBVPOA",
            "1; CY4PR03MB3318;\n\t3:jIwVhuMjgGTQtsZSXBVd2SjuBHsx8gIbez3GHv16CZSVPq2Z8nzintt/uWZuaHIwLG8+CUmK+EpVZmfjEjN62RUYaWu65s9qrQ/3pwqd0mXwDE4tM4R2F5H0kd1EaVc8Ug23gXGEEBjiiQL1vT1bkhy72HC66mrtPqnwY1cdRSwZsW7A7pk0ZRelaLzRMlOlkprAF63OPn1OEbItHicZkqrWYzax44Kuu4avN0PH3x9XCiWty6Lb13U0765g/ZvtpCNXb39x1bN6aJ2oyPgSevIFmPcFmrnIYiW/l0jis44E8DQxyR8pW3d7iPd1wM6lGgRk4/wcPHX93rcnclV0pw==;\n\t25:FntQia8kxuuXcnbg13x6MMZXG7Gbj2q2I50LEp+oAVioO2Vs/7KLPsNIezP/UjvN8zA9FmqLSpOh7Uw64fSim9OyqlceKta1IAEabgz/eSF9Xue877350Fa3Uwr9T2tSDhfMYrc6upDnCyLHaXuJBn/pNkn8CG0WFClDIVrZUjtNwvOqDQfhrh0TCTS0ukgc8QGf3AJpMSPR2zkHy6MuYi65oFabb7AR8rgp1JatYAwaGxX/HOz7JW89c07owNQOn3aQa1vLe27XgVjGSp/8dOQ5t9y7GJWayGfnK+IUmJI8+hQXTUjiHP8C/UIzR8lSGg377i+orF34jygZGaVvKA==;\n\t31:OZ7OgdvaIZnABlEKUy/sQIcj4Zlbww70qiXSmez2Ay79Pdheo96GL33PAopLuOEzJWYIO8+Dl+b+UawJK2dfV0/P3q4wk1H9Owt7WxesHEC3KQy4zSSyE4BXCpeoyaDei0BJ9ECB/X8Jf+1tAPFnN1WqRPh77d8IbeufQLELY8R96ANYnQcm/k25huzAVuxQz+1Wyf0ERj4ryhfJY7U6IjP/rFHJEAnqBy+x0Q5K5gs=",
            "1; CY4PR03MB3318;\n\t4:aZZFuWQYCCRGE1LWlu/duLbDFmWAnrwDhnceOqoBtlefxtOININN+AsfgBNeJ6iP38B2fcp0VYyucoOs7Fnh23xrNvJzDqf5sGYFXOtRepT5QVtlfUog2dDt9dH+DeGVi6MWaYuEPs+5W71DQWPUNFVC8Vqw322iAWNdAaG0Rxjvs1c4FwK4UD6sXBKg85ZoGGchRC+AWNLSlW9O7QNLU+cu1CW8n746Ot9W1nxDHSDngD3KEmPgubqo9HSNRrrvtZVpRBb8+aK3MsCLC6h9bnSL0Otna48zUudaRxe/2S4=",
            "1; CY4PR03MB3318;\n\t23:oPPTXqsc8XJKJ9ApRXF1tVy9CP6rGgU1jWaTq1wT/Jtxq49+UolDIkbZMsP3bU3E5jRw76++uLVAtLl1PcjRddmHKF2nx9TrENSbYFuJX0GYcxa8EuuA/cu7fxLMeZfYzL2fADaBvIzd1wWZnz9zQ88LKCGiQi9psEr+ehtuBiXvUm9iqc+diWAHoiNRc9xf6iqj9slNhHabfYVZ4g+OTdKpgacld6/8w1jFwly8w1AlCC55XYAF8y6aarNxuKdVnsJ1PRXlZrk2HnDTNNATEfHFDmFn8EDgdbFGBssBHXN/K4R68issdDStUSlS+scMbPyNg+uX5tYgwfkLTX5Ldh/qNzy5wfE/Ymk0fXNHGh0g727PK0214fAgNQyS9pDf7VXHnkqTaVEA5E4PWZKCB92ir39Yh8F00GiPfEoLSoQ7c2v0g6iA+lwya7RQ/HKuvzhGwqwQLhTP8hbd68i6txxdQSRFgzvq0x+BkmAHoON6yUHibl6OLxaocjq48r+tNli/3sDldNWYNZoCvc78NtY0bXMhOa36t5WAUdnu0DxsRg6y+q9pUYnOAo/AoKXBfEluTyVMGN2KmiJ6HNTy0R5uhR1eUWzgCUT5uWK0Hfs5IxxDJCzYpdSCzAO6mFDOM3D2D3pcKaJ8+pyfdIRxheOxcB0yQt9IbgLpWDKrksYyQmj85EzrF3TImvR3uklaRwF0w8YPsTRkveO/w3n9t0pD76GIHS8RrlFWGQWFGzEAaK/C92jm32gXWsHKpBkjtgxii5mnyZyiucL+jFcpiqy0pn6opmDqJEOG35dCEdmZFX/LQY00EQyDJnxHtfdfjwQyWpp833cVRd8Fgrxl8I97WlImJ+ibVMjn9ndJn5N/ym8fjMQDivfb2S7SPjeVHazJfcKtzrfB4AJhGWT6TlWcPgEreuoGGKbcY050GMD9o7NgnV2Horu/buCKN99oed9RRhEs4JS+D8xr9SQgdtNKAWT1kdjM+G2u3U/FMO+9uJbLog4PtZri4ulSiBkxoQJvDey0tQsVAjphF+qCH1D7ebxhvUAMPWo8MD57DjXlwl5dVorQ/MSDbpqbyBEsTH9ePnYIiAEO4zIcGJZl9snsep9EyoVAUg73MYnHdtlCN/qTHsJqPqIbSvWd8QkFouDKNforqwUM/AYBzj7wV6gh79uncpl76JKtv5MqtQLx3SfHax7+3mP/43wdlS3NDok+b5EgJJGnZVC0nJU5ssxXd+70uvAZOHM9HI8DKNg=",
            "1; CY4PR03MB3318;\n\t6:7w7SzAAAzEyZyiFJ7xnSC6r+eTZ8ci1FGvWlNiakeC3sEpPkseyP9KircVdAeOvsGZx8tCcaCjekjpcczkHNZ7u0+nDkY0MjJm1DThGYfocGQXf3RWiAHte1TFW8BczmbJcfGsiXgCCKHo6jqXgPjB1ay2bmdyvtddomAOOZypSY2b9Lx1dm06Nudaz86er3hntsEY6G25qAbYyzVlW3BDzhxqkeIrfeDVcCj5tetq0+sZvfAz07b0J5pce7nLKunFPeAxnxFDSkiDXF6ZdZBhryDy1Mop3E6RIFJiREyKIQ9vLdI06t+5GYLhMLs/aQJWfSMLqqEEhI7OLg0Pgkhw==;\n\t5:1o0Ky5KhECqYPcNwffddUom+0P6IekOKgM17aYgCMnVZ+ISA5MLTYyTfHsq22BXcLCF08d6Irx/APuhPgoQvc3oXXZ0W6dw++nKuFN52seE7lazeE16zxRyIFONonziI7PbSP4mpkx4r9n/IRlVH5g==;\n\t24:LOqKf/Stl3912tI6w5AUSgDTJz1wLJFgD0nvOTpDhsSJohxo0DSnb4VJhns30823lpE6Pw6YQg8ftHFzxUP4xtu2mC6PAh9lDMLEdtJpwXE=;\n\t7:2lMeUWXZeuM+uXbIBXYD4R/TaLfCKIrPwEnCUk6aWkZ5afFnBZuoQNp4XNbKztSiD+PQ6SYaeCCzMY5gqiqzmKE6mjbI+w1vh+xDPUUuYoUeYAXh/KgF3neGmuVu8qBSZThBdbLfrYDDYSDucU/YwVqxyE84X81t3AlROU3+hZ5fMepfyGRplYRMs+SnKY+KbG1Kzq9tY9W//SHd/FR+6CS7PDN1NPyiPvif9/itxbQ="
        ],
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-Office365-Filtering-Correlation-Id": "1908fd46-0d54-4fc0-8d33-08d4f11d9262",
        "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CY4PR03MB3318; ",
        "X-MS-TrafficTypeDiagnostic": "CY4PR03MB3318:",
        "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197);",
        "X-Microsoft-Antispam-PRVS": "<CY4PR03MB331867C3CAB620903B34D5C996920@CY4PR03MB3318.namprd03.prod.outlook.com>",
        "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(8121501046)(5005006)(13018025)(13016025)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6055026)(6096035)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123563025)(20161123559100)(20161123556025)(20161123561025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY4PR03MB3318; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY4PR03MB3318; ",
        "X-Forefront-PRVS": "0417A3FFD2",
        "SpamDiagnosticOutput": "1:99",
        "SpamDiagnosticMetadata": "NSPM",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "01 Sep 2017 09:41:07.7112\n\t(UTC)",
        "X-MS-Exchange-CrossTenant-Id": "5afe0b00-7697-4969-b663-5eab37d5f47e",
        "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;\n\tIp=[192.88.158.2]; Helo=[az84smr01.freescale.net]",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR03MB3318",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Indeed, the wrong register is checked for the Tx flow control bit,\nit should have been maccfg1 not maccfg2.\nThis went unnoticed for so long probably because the impact is\nhardly visible, not to mention the tangled code from adjust_link().\nFirst, link flow control (i.e. handling of Rx/Tx link level pause frames)\nis disabled by default (needs to be enabled via 'ethtool -A').\nSecondly, maccfg2 always returns 0 for tx_flow_oldval (except for a few\nold boards), which results in Tx flow control remaining always on\nonce activated.\n\nFixes: 45b679c9a3ccd9e34f28e6ec677b812a860eb8eb -\n\t\"gianfar: Implement PAUSE frame generation support\"\n\nCc: stable@kernel.org\n\nSigned-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>\n---\n drivers/net/ethernet/freescale/gianfar.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c\nindex c4b4b0a..5be52d8 100644\n--- a/drivers/net/ethernet/freescale/gianfar.c\n+++ b/drivers/net/ethernet/freescale/gianfar.c\n@@ -3687,7 +3687,7 @@ static noinline void gfar_update_link_state(struct gfar_private *priv)\n \t\tu32 tempval1 = gfar_read(&regs->maccfg1);\n \t\tu32 tempval = gfar_read(&regs->maccfg2);\n \t\tu32 ecntrl = gfar_read(&regs->ecntrl);\n-\t\tu32 tx_flow_oldval = (tempval & MACCFG1_TX_FLOW);\n+\t\tu32 tx_flow_oldval = (tempval1 & MACCFG1_TX_FLOW);\n \n \t\tif (phydev->duplex != priv->oldduplex) {\n \t\t\tif (!(phydev->duplex))\n",
    "prefixes": [
        "net",
        "1/3"
    ]
}