Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808600/?format=api
{ "id": 808600, "url": "http://patchwork.ozlabs.org/api/patches/808600/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170901092121.4596-1-zajec5@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901092121.4596-1-zajec5@gmail.com>", "list_archive_url": null, "date": "2017-09-01T09:21:21", "name": "net: phy: broadcom: force master mode for BCM54210E and B50212E", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "62fc57e86d022c0a7d57221f6fe0372523e8cfd8", "submitter": { "id": 5824, "url": "http://patchwork.ozlabs.org/api/people/5824/?format=api", "name": "Rafał Miłecki", "email": "zajec5@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170901092121.4596-1-zajec5@gmail.com/mbox/", "series": [ { "id": 982, "url": "http://patchwork.ozlabs.org/api/series/982/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=982", "date": "2017-09-01T09:21:21", "name": "net: phy: broadcom: force master mode for BCM54210E and B50212E", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/982/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808600/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808600/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sKhjkJby\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkDJp4XkYz9s7C\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 1 Sep 2017 19:21:46 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751768AbdIAJVo (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 1 Sep 2017 05:21:44 -0400", "from mail-lf0-f65.google.com ([209.85.215.65]:33170 \"EHLO\n\tmail-lf0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751457AbdIAJVm (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 1 Sep 2017 05:21:42 -0400", "by mail-lf0-f65.google.com with SMTP id y15so1144715lfd.0\n\tfor <netdev@vger.kernel.org>; Fri, 01 Sep 2017 02:21:42 -0700 (PDT)", "from linux-samsung.lan\n\t(ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233])\n\tby smtp.gmail.com with ESMTPSA id\n\te67sm414822lff.23.2017.09.01.02.21.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 02:21:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=/BcrwrhIstFusOKP8KBS/HoWd4eFBfImJLEhFEHZ6vo=;\n\tb=sKhjkJbyio0HKq17cENj+tjiTV9Qs9TzBty2p54EjywqFrEVBAKOjVjHZJ//MuuM2h\n\teVAe0WQnf0PuPkWs1atlVrs3RiJ45TtbM2E+PMOKDFQs9XSP7jqEzAQM2/kr7Nukllmz\n\tVKFxCzAtPTR8ji+1lduhZY04t6PVQ1ZGOxyZafsFz6cT/afesadSuVJujkvmmHpedzQt\n\tJXoympcC8xzE3L4IPFRxBwY4BDsm7W8lL6j9vJq/oB0QKExfjUmdHg+KyA2GeFXDFBVN\n\tdyLnW7S7ozTqbwz7IJKM9OBmPbume8rtJ4a9+s06V3hNzR+mI4bK2wn0n6tfqa27Rx4b\n\tTO3Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=/BcrwrhIstFusOKP8KBS/HoWd4eFBfImJLEhFEHZ6vo=;\n\tb=s/CT16mHlfEWj1t9jI6aTo3KviDtUNyv6+4Q0S4P7MdpLOiTKhza/3zXpWUppgSstr\n\t68R+W+fyBJvgOg2sBk/PCsFwcXlKCBjfXC7kav+gzMGhiZufW7uuM/HpMREBNdy4ropT\n\tuX1p6OxZbwTNjAcJaGfMc4qJ9N0qxSwLNQfLF1amBeTCMTANDPcV9qhQrKQ2+gS0hset\n\tiAodiStuHvgk6AU3ilvGs0+Ym7hqofzkbdCM65g8gtiaCbq+NRmmzFmv7pde+5WqiUqp\n\tVxWg6bdcY/d6EufO2StQwzJ787THWLzwuML3h2GbEp3UNlf/3rCbfrJEdbtNJA9KaRzo\n\tkMAA==", "X-Gm-Message-State": "AHPjjUgrkQlFOCagqydfxiE5WjeHJVit42mqGfkJ1mQNLEETxN4ZNNgh\n\tyMfNYU/6rRRqpw==", "X-Google-Smtp-Source": "ADKCNb5f5uRwqbTmwIa+GH0ONSjQJJ2ubOXuSxRyMGI+OZR6JC1j8bcn0CVndJnmfjOSt0v/oyph3Q==", "X-Received": "by 10.25.209.133 with SMTP id i127mr604249lfg.125.1504257701218; \n\tFri, 01 Sep 2017 02:21:41 -0700 (PDT)", "From": "=?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>", "To": "\"David S . Miller\" <davem@davemloft.net>, netdev@vger.kernel.org", "Cc": "Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>,\n\tHauke Mehrtens <hauke@hauke-m.de>, \n\tbcm-kernel-feedback-list@broadcom.com, =?utf-8?b?UmFmYcWCIE1p?=\n\t=?utf-8?b?xYJlY2tp?= <rafal@milecki.pl>", "Subject": "[PATCH] net: phy: broadcom: force master mode for BCM54210E and\n\tB50212E", "Date": "Fri, 1 Sep 2017 11:21:21 +0200", "Message-Id": "<20170901092121.4596-1-zajec5@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Rafał Miłecki <rafal@milecki.pl>\n\nFirst of all let me explain that the code we use for BCM54210E is also\nexecuted for the B50212E. They are very similar so it probably makes\nsense but it may be worth noting. The IDs are:\n0x600d84a1: BCM54210E (rev B0)\n0x600d84a2: BCM54210E (rev B1)\n0x600d84a5: B50212E (rev B0)\n0x600d84a6: B50212E (rev B1)\n\nI got a report that a board with BCM47189 SoC and B50212E B1 PHY doesn't\nwork well with Intel's I217-LM and I218-LM:\nhttp://ark.intel.com/products/60019/Intel-Ethernet-Connection-I217-LM\nhttp://ark.intel.com/products/71307/Intel-Ethernet-Connection-I218-LM\nI was told there are massive ping loss.\n\nA solution to this problem is setting master mode in the 1000BASE-T\nregister. I noticed a similar fix is present in the tg3 driver. One\nthing I'm not sure if this is needed for BCM54210E. It shouldn't hurt\nhowever since both are so similar.\n\nSigned-off-by: Rafał Miłecki <rafal@milecki.pl>\n---\nDavid: I'm not 100% sure if this is the best fix, so let's give others\n(Florian?) a moment to look at it / review it, please.\n---\n drivers/net/phy/broadcom.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c\nindex 1e9ad30a35c8..2569db0923b0 100644\n--- a/drivers/net/phy/broadcom.c\n+++ b/drivers/net/phy/broadcom.c\n@@ -43,6 +43,10 @@ static int bcm54210e_config_init(struct phy_device *phydev)\n \tval &= ~BCM54810_SHD_CLK_CTL_GTXCLK_EN;\n \tbcm_phy_write_shadow(phydev, BCM54810_SHD_CLK_CTL, val);\n \n+\tval = phy_read(phydev, MII_CTRL1000);\n+\tval |= CTL1000_AS_MASTER | CTL1000_ENABLE_MASTER;\n+\tphy_write(phydev, MII_CTRL1000, val);\n+\n \treturn 0;\n }\n \n", "prefixes": [] }