Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808469/?format=api
{ "id": 808469, "url": "http://patchwork.ozlabs.org/api/patches/808469/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504222183-61202-31-git-send-email-keescook@chromium.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504222183-61202-31-git-send-email-keescook@chromium.org>", "list_archive_url": null, "date": "2017-08-31T23:29:42", "name": "[30/31] appletalk: Remove unneeded synchronization", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "4881722540b0c34adcbc95e76b8911819c367d7e", "submitter": { "id": 10641, "url": "http://patchwork.ozlabs.org/api/people/10641/?format=api", "name": "Kees Cook", "email": "keescook@chromium.org" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504222183-61202-31-git-send-email-keescook@chromium.org/mbox/", "series": [ { "id": 923, "url": "http://patchwork.ozlabs.org/api/series/923/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=923", "date": "2017-08-31T23:29:25", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/923/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808469/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808469/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Zgz0Ig35\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjzQ36H7dz9s7p\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 1 Sep 2017 09:40:27 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751965AbdHaXjZ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 31 Aug 2017 19:39:25 -0400", "from mail-pg0-f41.google.com ([74.125.83.41]:34199 \"EHLO\n\tmail-pg0-f41.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751907AbdHaXjX (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 31 Aug 2017 19:39:23 -0400", "by mail-pg0-f41.google.com with SMTP id t193so3252857pgc.1\n\tfor <netdev@vger.kernel.org>; Thu, 31 Aug 2017 16:39:23 -0700 (PDT)", "from www.outflux.net\n\t(173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133])\n\tby smtp.gmail.com with ESMTPSA id\n\te190sm925209pfa.41.2017.08.31.16.39.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 31 Aug 2017 16:39:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=m2B41u6h9gWbjjyxZ/l3jlI5tETm55bX6Tqmwkndzik=;\n\tb=Zgz0Ig35vfG9oMGBbCxs/cCwBdiFr8Cy/WPb7xz+ZGfVD1Opy3dEoteDzN+FrcGZ25\n\tMKt5luUKgnjIkgeKmJ7IEnFkvd/aEU1hjEz51FvqQFTrn9lviXApi7EyZUTy3nEI61TK\n\tQ8/AQU4jOvboh2FN9i+6FvU+pY9D/Jcem6CVk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=m2B41u6h9gWbjjyxZ/l3jlI5tETm55bX6Tqmwkndzik=;\n\tb=BcqLEHc6ndMeYx5PjFaGicij5VDwUJqlwSHTNweTO8cE2lavXyCZQm6n98/V87aRMH\n\tnxV4b11Gsw/G2FIu/XHA+NjTlPMPcxoAp09a2XnxxKw/DnUV+78XI5dlI0r0LFWVjilB\n\t3Cv940UGfifwIeXFnoPRfV6HIVwtkTOkiM/uj/GS/ropkdxsU7cL2dejU6l9ab/BgANL\n\tbaEG9aK6r7WXO/NMiRZblVZXL8k/5Ovlh5j+Z7YTLVYc5Bsh9q3sAZqmhKoNYRGvK4VH\n\t8O8ctDh915c/+Mq8ZUgDv1owKiC31WY9y4z9QSuZaCzBXAM2GQmnR4EVPe77h18d5Fts\n\tl6iA==", "X-Gm-Message-State": "AHPjjUgMm5ScOVED+2pd2v2vsIGKFAT5RcpXTG3tGt8dRI8m9YBIGhza\n\tSTbd2mO1XErRk6EU", "X-Google-Smtp-Source": "ADKCNb7nADRF2gQaMmkQrT2BU0uTQGInsNeuBvebdQT7n0aRCj3lvP92L9fhPKPp11DB5htxjewmFw==", "X-Received": "by 10.99.109.12 with SMTP id i12mr139786pgc.347.1504222763251;\n\tThu, 31 Aug 2017 16:39:23 -0700 (PDT)", "From": "Kees Cook <keescook@chromium.org>", "To": "Thomas Gleixner <tglx@linutronix.de>", "Cc": "Kees Cook <keescook@chromium.org>,\n\tDavid Howells <dhowells@redhat.com>, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH 30/31] appletalk: Remove unneeded synchronization", "Date": "Thu, 31 Aug 2017 16:29:42 -0700", "Message-Id": "<1504222183-61202-31-git-send-email-keescook@chromium.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504222183-61202-1-git-send-email-keescook@chromium.org>", "References": "<1504222183-61202-1-git-send-email-keescook@chromium.org>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "The use of del_timer_sync() will make sure a timer is not rescheduled.\nAs such, there is no need to add external signals to kill timers. In\npreparation for switching the timer callback argument to the timer\npointer, this drops the .data argument since it doesn't serve a meaningful\npurpose here.\n\nCc: David Howells <dhowells@redhat.com>\nCc: netdev@vger.kernel.org\nSigned-off-by: Kees Cook <keescook@chromium.org>\n---\n drivers/net/appletalk/ltpc.c | 6 ------\n 1 file changed, 6 deletions(-)", "diff": "diff --git a/drivers/net/appletalk/ltpc.c b/drivers/net/appletalk/ltpc.c\nindex e4aa374caa4d..cc3dc9337eae 100644\n--- a/drivers/net/appletalk/ltpc.c\n+++ b/drivers/net/appletalk/ltpc.c\n@@ -880,14 +880,10 @@ static void ltpc_poll(unsigned long l)\n \t\t}\n \t\tltpc_poll_counter--;\n \t}\n- \n-\tif (!dev)\n-\t\treturn; /* we've been downed */\n \n \t/* poll 20 times per second */\n \tidle(dev);\n \tltpc_timer.expires = jiffies + HZ/20;\n-\t\n \tadd_timer(<pc_timer);\n }\n \n@@ -1252,8 +1248,6 @@ static void __exit ltpc_cleanup(void)\n \tif(debug & DEBUG_VERBOSE) printk(\"unregister_netdev\\n\");\n \tunregister_netdev(dev_ltpc);\n \n-\tltpc_timer.data = 0; /* signal the poll routine that we're done */\n-\n \tdel_timer_sync(<pc_timer);\n \n \tif(debug & DEBUG_VERBOSE) printk(\"freeing irq\\n\");\n", "prefixes": [ "30/31" ] }