Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 808434,
    "url": "http://patchwork.ozlabs.org/api/patches/808434/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/1504213298-27431-1-git-send-email-linux@leemhuis.info/",
    "project": {
        "id": 12,
        "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api",
        "name": "Linux CIFS Client",
        "link_name": "linux-cifs-client",
        "list_id": "linux-cifs.vger.kernel.org",
        "list_email": "linux-cifs@vger.kernel.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": "",
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1504213298-27431-1-git-send-email-linux@leemhuis.info>",
    "list_archive_url": null,
    "date": "2017-08-31T21:01:38",
    "name": "RFC: Revert move default dialect from CIFS to to SMB3\"",
    "commit_ref": null,
    "pull_url": null,
    "state": "new",
    "archived": false,
    "hash": "4bac0ba91c13d09e770328bc6636cd382a530ab9",
    "submitter": {
        "id": 72269,
        "url": "http://patchwork.ozlabs.org/api/people/72269/?format=api",
        "name": "Thorsten Leemhuis",
        "email": "linux@leemhuis.info"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/1504213298-27431-1-git-send-email-linux@leemhuis.info/mbox/",
    "series": [
        {
            "id": 911,
            "url": "http://patchwork.ozlabs.org/api/series/911/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=911",
            "date": "2017-08-31T21:01:38",
            "name": "RFC: Revert move default dialect from CIFS to to SMB3\"",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/911/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/808434/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/808434/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<linux-cifs-owner@vger.kernel.org>",
        "X-Original-To": "incoming@patchwork.ozlabs.org",
        "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjwLW3fd8z9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 07:22:11 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751412AbdHaVWK (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 31 Aug 2017 17:22:10 -0400",
            "from wp227.webpack.hosteurope.de ([80.237.132.234]:42416 \"EHLO\n\twp227.webpack.hosteurope.de\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751110AbdHaVWJ (ORCPT\n\t<rfc822;linux-cifs@vger.kernel.org>);\n\tThu, 31 Aug 2017 17:22:09 -0400",
            "from ip4d15e3ad.dynamic.kabel-deutschland.de ([77.21.227.173]\n\thelo=truhe.fritz.box); authenticated\n\tby wp227.webpack.hosteurope.de running ExIM with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n\tid 1dnWap-0007Gj-A1; Thu, 31 Aug 2017 23:01:39 +0200"
        ],
        "X-Greylist": "delayed 1228 seconds by postgrey-1.27 at vger.kernel.org;\n\tThu, 31 Aug 2017 17:22:09 EDT",
        "From": "Thorsten Leemhuis <linux@leemhuis.info>",
        "To": "Steve French <smfrench@gmail.com>",
        "Cc": "Linus Torvalds <torvalds@linux-foundation.org>,\n\tLinux Kernel Mailing List <linux-kernel@vger.kernel.org>,\n\tlinux-cifs@vger.kernel.org, Pavel Shilovsky <pshilov@microsoft.com>",
        "Subject": "RFC: Revert move default dialect from CIFS to to SMB3\"",
        "Date": "Thu, 31 Aug 2017 23:01:38 +0200",
        "Message-Id": "<1504213298-27431-1-git-send-email-linux@leemhuis.info>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "X-bounce-key": "webpack.hosteurope.de; linux@leemhuis.info; 1504214529;\n\t783c7259; ",
        "X-HE-SMSGID": "1dnWap-0007Gj-A1",
        "Sender": "linux-cifs-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<linux-cifs.vger.kernel.org>",
        "X-Mailing-List": "linux-cifs@vger.kernel.org"
    },
    "content": "This reverts commit eef914a9eb5eb83e60eb498315a491cd1edc13a1 (\n[SMB3] Improve security, move default dialect to SMB3 from old CIFS), \nas it confuses users: https://bugzilla.kernel.org/show_bug.cgi?id=196599\n\nIt was a patch to improve security by switching to SMB3 by default and\nsupport SMB1 (aka CIFS) only when explicitly requested, as the latter\nis not considered secure anymore (see below for details). This is one of\nthe rare cases where regressions are unavoidable and accepted in Linux.\nBut that's bad enough already, so we at least should make it easy for\npeople to get an idea why something suddenly stopped working with a\nnewer kernel version. That's not the case, because due to eef914a9eb5e\na mount of a server that only supports CIFS/SMB1 with mount.cifs fails\nwith a misleading message:\n\n> mount error(112): Host is down > Refer to the mount.cifs(8) manual\n> page (e.g. man mount.cifs)\n\nThe corresponding message in the kernel log is just as unhelpful:\n\n> CIFS VFS: cifs_mount failed w/return code = -112\n\nThis needs to be improved. Hence remove this for now, as the world won't\nend suddenly if this gets delayed one or two cycles and resubmitted in\na way that leads to a more helpful error message.\n\nFor completeness, here are parts from the original patch description:\n\n> Due to recent publicity about security vulnerabilities in the much\n> older CIFS dialect, move the default dialect to the widely accepted\n> (and quite secure) SMB3.0 dialect from the old default of the CIFS\n> dialect.\n>\n> We do not want to be encouraging use of less secure dialects, and\n> both Microsoft and CERT now strongly recommend not using the older\n> CIFS dialect (SMB Security Best Practices \"recommends disabling\n> SMBv1\").\n>\n> SMB3 is both secure and widely available: in Windows 8 and later,\n> Samba and Macs.\n>\n> Users can still choose to explicitly mount with the less secure\n> dialect (for old servers) by choosing \"vers=1.0\" on the cifs mount\n\nSigned-off-by: Thorsten Leemhuis <linux@leemhuis.info>\nCC: Steve French <smfrench@gmail.com>\nCC: Pavel Shilovsky <pshilov@microsoft.com>\n---\n fs/cifs/connect.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c\nindex 59647eb..6ab261cd 100644\n--- a/fs/cifs/connect.c\n+++ b/fs/cifs/connect.c\n@@ -1272,9 +1272,9 @@ static int cifs_parse_security_flavors(char *value,\n \n \tvol->actimeo = CIFS_DEF_ACTIMEO;\n \n-\t/* FIXME: add autonegotiation for SMB3 or later rather than just SMB3 */\n-\tvol->ops = &smb30_operations; /* both secure and accepted widely */\n-\tvol->vals = &smb30_values;\n+\t/* FIXME: add autonegotiation -- for now, SMB1 is default */\n+\tvol->ops = &smb1_operations;\n+\tvol->vals = &smb1_values;\n \n \tvol->echo_interval = SMB_ECHO_INTERVAL_DEFAULT;\n \n",
    "prefixes": []
}