Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 808401,
    "url": "http://patchwork.ozlabs.org/api/patches/808401/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170831203013.9219-2-edumazet@google.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170831203013.9219-2-edumazet@google.com>",
    "list_archive_url": null,
    "date": "2017-08-31T20:30:12",
    "name": "[net-next,1/2] net: prepare (struct ubuf_info)->refcnt conversion",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "2f9a92b43ce53992cb557c7bd682e84f7f16d46b",
    "submitter": {
        "id": 13357,
        "url": "http://patchwork.ozlabs.org/api/people/13357/?format=api",
        "name": "Eric Dumazet",
        "email": "edumazet@google.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170831203013.9219-2-edumazet@google.com/mbox/",
    "series": [
        {
            "id": 902,
            "url": "http://patchwork.ozlabs.org/api/series/902/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=902",
            "date": "2017-08-31T20:30:11",
            "name": "net: ubuf_info.refcnt conversion",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/902/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/808401/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/808401/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"FUbvkh1y\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjvBp5GK5z9s83\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  1 Sep 2017 06:30:26 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751309AbdHaUaZ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 31 Aug 2017 16:30:25 -0400",
            "from mail-pf0-f169.google.com ([209.85.192.169]:33430 \"EHLO\n\tmail-pf0-f169.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751053AbdHaUaW (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 31 Aug 2017 16:30:22 -0400",
            "by mail-pf0-f169.google.com with SMTP id n73so2123185pfj.0\n\tfor <netdev@vger.kernel.org>; Thu, 31 Aug 2017 13:30:22 -0700 (PDT)",
            "from localhost ([2620:15c:2cb:201:df6:9252:fc0d:50b2])\n\tby smtp.gmail.com with ESMTPSA id\n\tn62sm555249pga.90.2017.08.31.13.30.20\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 31 Aug 2017 13:30:20 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=BBn1n43D+1pYpsqO/qwMoKuKyWSf2m3yJtjG5lbMtVI=;\n\tb=FUbvkh1yHWxwH4i62Njh/6UaWbcgK8GjNzCCs1dBMWc7nlumb0iQ7CDwaDeklIbr1B\n\tZjzaQFFvXk3xcwtW2pROy/iRCWkXbdfKspr/3iUCqmnaIaqskNh6tDBhAfTjNwCdW++W\n\tq6nY+Jvfv3NFtWsi8zH91I61G8AkJZyO6vmEZ9Enp4e8k53HwO9gEsHFWS1flj7Ai0Ep\n\t7LcQcW1LDGynvfgZXiX2ylILZib49JJ4xTsLvUipZwJ5pNa2+FjIEC8b6fx986Pkc5rV\n\tjbYPv/QIPNy5GQNaMClg7dKypjGVZVjpJKwHcQ5CAD6pzBWvkj6KbpwZ+R4sNBq+4zEt\n\t6/1w==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=BBn1n43D+1pYpsqO/qwMoKuKyWSf2m3yJtjG5lbMtVI=;\n\tb=ag5un+J57K1DNABlxBcZqCnvvImO6Hvu5rwZpaSRX7MWQx0r6arx7mmit1pNxttlpf\n\t6YXk+3TGieNuDOHFkvIZZQCsOsr9LQUubJ+S4gxhCPy/+9+YBueCN4ZQQj4VDRQUWoji\n\tN+vrQyKH16iXfQSC7rsDBRYBDeG321xaPVZ2ecMXk775KE6Z/flhME7H+/+GpbAWw89a\n\tt0nXfPaAUQ3+wI75Cir6fHrH514Ac4ePL3ht4HMJRBefpo+WxMR8b2WeYHkNRZsN9Xc6\n\tjYs3WaJFsHCqWlmkKIkPViRCCRlot3eww/DIe5L63LNNiaPwoLmKorNywv7B9iLV3/9s\n\t8qUw==",
        "X-Gm-Message-State": "AHYfb5g1mK3cpcLx1Lr/wAG797GM1THTrSFmJab7HrUc8bgnKRfrUlY2\n\t/k5/t8n1lfcx7PUz",
        "X-Google-Smtp-Source": "ADKCNb4A7+++DsrxgiWB0WbcTF0Baek9iyDvMtg70ylnZxbZIFTD3JMOBLHfLH06dmxrY/vsSx//LA==",
        "X-Received": "by 10.84.137.106 with SMTP id 97mr2779336plm.304.1504211421361; \n\tThu, 31 Aug 2017 13:30:21 -0700 (PDT)",
        "From": "Eric Dumazet <edumazet@google.com>",
        "To": "\"David S . Miller\" <davem@davemloft.net>",
        "Cc": "netdev <netdev@vger.kernel.org>, Willem de Bruijn <willemb@google.com>,\n\tEric Dumazet <edumazet@google.com>, Eric Dumazet <eric.dumazet@gmail.com>",
        "Subject": "[PATCH net-next 1/2] net: prepare (struct ubuf_info)->refcnt\n\tconversion",
        "Date": "Thu, 31 Aug 2017 13:30:12 -0700",
        "Message-Id": "<20170831203013.9219-2-edumazet@google.com>",
        "X-Mailer": "git-send-email 2.14.1.581.gf28d330327-goog",
        "In-Reply-To": "<20170831203013.9219-1-edumazet@google.com>",
        "References": "<20170831203013.9219-1-edumazet@google.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "In order to convert this atomic_t refcnt to refcount_t,\nwe need to init the refcount to one to not trigger\na 0 -> 1 transition.\n\nThis also removes one atomic operation in fast path.\n\nSigned-off-by: Eric Dumazet <edumazet@google.com>\n---\n net/core/skbuff.c | 3 ++-\n net/ipv4/tcp.c    | 2 --\n 2 files changed, 2 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/net/core/skbuff.c b/net/core/skbuff.c\nindex 917da73d3ab3b82163cf0a9ee944da09cb5a391f..65b9ca3945f8fd2b1bef4aef5dd774be04e5d128 100644\n--- a/net/core/skbuff.c\n+++ b/net/core/skbuff.c\n@@ -963,7 +963,7 @@ struct ubuf_info *sock_zerocopy_alloc(struct sock *sk, size_t size)\n \tuarg->len = 1;\n \tuarg->bytelen = size;\n \tuarg->zerocopy = 1;\n-\tatomic_set(&uarg->refcnt, 0);\n+\tatomic_set(&uarg->refcnt, 1);\n \tsock_hold(sk);\n \n \treturn uarg;\n@@ -1005,6 +1005,7 @@ struct ubuf_info *sock_zerocopy_realloc(struct sock *sk, size_t size,\n \t\t\tuarg->len++;\n \t\t\tuarg->bytelen = bytelen;\n \t\t\tatomic_set(&sk->sk_zckey, ++next);\n+\t\t\tsock_zerocopy_get(uarg);\n \t\t\treturn uarg;\n \t\t}\n \t}\ndiff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c\nindex 21ca2df274c5130a13d31a391a1408d779af34af..fff4d7bc3b8b46174e7bd0a04d7c212307e55cb5 100644\n--- a/net/ipv4/tcp.c\n+++ b/net/ipv4/tcp.c\n@@ -1190,8 +1190,6 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)\n \t\t\tgoto out_err;\n \t\t}\n \n-\t\t/* skb may be freed in main loop, keep extra ref on uarg */\n-\t\tsock_zerocopy_get(uarg);\n \t\tif (!(sk_check_csum_caps(sk) && sk->sk_route_caps & NETIF_F_SG))\n \t\t\tuarg->zerocopy = 0;\n \t}\n",
    "prefixes": [
        "net-next",
        "1/2"
    ]
}