Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808306/?format=api
{ "id": 808306, "url": "http://patchwork.ozlabs.org/api/patches/808306/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/alpine.DEB.2.20.1708311639420.24662@digraph.polyomino.org.uk/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<alpine.DEB.2.20.1708311639420.24662@digraph.polyomino.org.uk>", "list_archive_url": null, "date": "2017-08-31T16:40:02", "name": "Simplify NAN definitions [committed]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "46962a13d0734d3192f1fabcb5f39b1f88bb7bd0", "submitter": { "id": 4349, "url": "http://patchwork.ozlabs.org/api/people/4349/?format=api", "name": "Joseph Myers", "email": "joseph@codesourcery.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/alpine.DEB.2.20.1708311639420.24662@digraph.polyomino.org.uk/mbox/", "series": [ { "id": 871, "url": "http://patchwork.ozlabs.org/api/series/871/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=871", "date": "2017-08-31T16:40:02", "name": "Simplify NAN definitions [committed]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/871/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808306/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808306/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-83950-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-83950-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"fbTNw4ZO\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjp5S4cfSz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 1 Sep 2017 02:40:28 +1000 (AEST)", "(qmail 9815 invoked by alias); 31 Aug 2017 16:40:22 -0000", "(qmail 9800 invoked by uid 89); 31 Aug 2017 16:40:21 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:subject:message-id:mime-version\n\t:content-type; q=dns; s=default; b=UkYxliEUTwlc7fsBFnd6GL+RzjBP+\n\tGQddm1G2UCTsjETCXrzB+2nd+Q94W/m8LkKkt5sanR+YrFBdRx8RVnzAGxZgyxNM\n\toISJyDuEnsLHSlZMj3nPplgPJSx5I1Fgd/qK9pEhXeOabVoGN5i0C0jbncIxMID9\n\t/SrK6Ci3s21+8E=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:subject:message-id:mime-version\n\t:content-type; s=default; bh=DTIkLJJWt8vyRNWYCCvGL4vfYcA=; b=fbT\n\tNw4ZOty/rBGAkSbYPdYTXCtouHPxlp0IKXO804FgDXs2pLUXBhhfiR6eI362P3dZ\n\tnwkZ30N5wvoJG74O6jXX6ooe84FU8wEvYOmL55azOVAhMvrXSCLcoiMkih1dLjbk\n\tAF7eCyHzuIxIgSp7pAm8rSjoZH5yAuqF3CGaEPsg=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-24.5 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=", "X-HELO": "relay1.mentorg.com", "Date": "Thu, 31 Aug 2017 16:40:02 +0000", "From": "Joseph Myers <joseph@codesourcery.com>", "To": "<libc-alpha@sourceware.org>", "Subject": "Simplify NAN definitions [committed]", "Message-ID": "<alpine.DEB.2.20.1708311639420.24662@digraph.polyomino.org.uk>", "User-Agent": "Alpine 2.20 (DEB 67 2015-01-07)", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"US-ASCII\"", "X-ClientProxiedBy": "svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To\n\tsvr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)" }, "content": "Similar to my patches for HUGE_VAL and INFINITY. this patch eliminates\nthe bits/nan.h headers. __builtin_nanf (\"\") is used to define NAN for\nGCC 3.3 and later; the fallback is (0.0f / 0.0f), which is a constant\nexpression for a quiet NaN of type float, but raises a spurious\n\"invalid\" exception outside static initializers, which seems the best\nthat can be done purely in standard C. Again, if anyone actually uses\na compiler with its own incompatible extension for producing a\nconstant quiet NaN, we can add compiler conditionals.\n\nTested for x86_64.\n\n2017-08-31 Joseph Myers <joseph@codesourcery.com>\n\n\t* math/math.h [__USE_ISOC99] (NAN): Define directly here. Do not\n\tinclude <bits/nan.h>.\n\t* math/Makefile (headers): Remove bits/nan.h.\n\t* bits/nan.h: Remove.\n\t* sysdeps/ieee754/bits/nan.h: Likewise.\n\t* sysdeps/mips/bits/nan.h: Likewise.", "diff": "diff --git a/bits/nan.h b/bits/nan.h\ndeleted file mode 100644\nindex ab38168..0000000\n--- a/bits/nan.h\n+++ /dev/null\n@@ -1,5 +0,0 @@\n-#ifndef _MATH_H\n-#error \"Never use <bits/nan.h> directly; include <math.h> instead.\"\n-#endif\n-\n-/* This file should define `NAN' on machines that have such things. */\ndiff --git a/math/Makefile b/math/Makefile\nindex b9a06f0..0601f3a 100644\n--- a/math/Makefile\n+++ b/math/Makefile\n@@ -23,7 +23,6 @@ include ../Makeconfig\n \n # Installed header files.\n headers\t\t:= math.h bits/mathcalls.h bits/mathinline.h \\\n-\t\t bits/nan.h \\\n \t\t fpu_control.h complex.h bits/cmathcalls.h fenv.h \\\n \t\t bits/fenv.h bits/fenvinline.h bits/mathdef.h tgmath.h \\\n \t\t bits/math-finite.h bits/math-vector.h \\\ndiff --git a/math/math.h b/math/math.h\nindex 5f5a498..bbc1ab9 100644\n--- a/math/math.h\n+++ b/math/math.h\n@@ -65,8 +65,15 @@ __BEGIN_DECLS\n # define INFINITY HUGE_VALF\n # endif\n \n-/* Get machine-dependent NAN value (returned for some domain errors). */\n-# include <bits/nan.h>\n+/* IEEE Not A Number. */\n+# if __GNUC_PREREQ (3, 3)\n+# define NAN (__builtin_nanf (\"\"))\n+# else\n+/* This will raise an \"invalid\" exception outside static initializers,\n+ but is the best that can be done in ISO C while remaining a\n+ constant expression. */\n+# define NAN (0.0f / 0.0f)\n+# endif\n #endif /* __USE_ISOC99 */\n \n #if __GLIBC_USE (IEC_60559_BFP_EXT)\ndiff --git a/sysdeps/ieee754/bits/nan.h b/sysdeps/ieee754/bits/nan.h\ndeleted file mode 100644\nindex b6e14f5..0000000\n--- a/sysdeps/ieee754/bits/nan.h\n+++ /dev/null\n@@ -1,52 +0,0 @@\n-/* `NAN' constant for IEEE 754 machines.\n- Copyright (C) 1992-2017 Free Software Foundation, Inc.\n- This file is part of the GNU C Library.\n-\n- The GNU C Library is free software; you can redistribute it and/or\n- modify it under the terms of the GNU Lesser General Public\n- License as published by the Free Software Foundation; either\n- version 2.1 of the License, or (at your option) any later version.\n-\n- The GNU C Library is distributed in the hope that it will be useful,\n- but WITHOUT ANY WARRANTY; without even the implied warranty of\n- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n- Lesser General Public License for more details.\n-\n- You should have received a copy of the GNU Lesser General Public\n- License along with the GNU C Library; if not, see\n- <http://www.gnu.org/licenses/>. */\n-\n-#ifndef _MATH_H\n-# error \"Never use <bits/nan.h> directly; include <math.h> instead.\"\n-#endif\n-\n-\n-/* IEEE Not A Number. */\n-\n-#if __GNUC_PREREQ(3,3)\n-\n-# define NAN\t(__builtin_nanf (\"\"))\n-\n-#elif defined __GNUC__\n-\n-# define NAN \\\n- (__extension__\t\t\t\t\t\t\t \\\n- ((union { unsigned __l __attribute__ ((__mode__ (__SI__))); float __d; }) \\\n- { __l: 0x7fc00000UL }).__d)\n-\n-#else\n-\n-# include <endian.h>\n-\n-# if __BYTE_ORDER == __BIG_ENDIAN\n-# define __qnan_bytes\t\t{ 0x7f, 0xc0, 0, 0 }\n-# endif\n-# if __BYTE_ORDER == __LITTLE_ENDIAN\n-# define __qnan_bytes\t\t{ 0, 0, 0xc0, 0x7f }\n-# endif\n-\n-static union { unsigned char __c[4]; float __d; } __qnan_union\n- __attribute__ ((__unused__)) = { __qnan_bytes };\n-# define NAN\t(__qnan_union.__d)\n-\n-#endif\t/* GCC. */\ndiff --git a/sysdeps/mips/bits/nan.h b/sysdeps/mips/bits/nan.h\ndeleted file mode 100644\nindex a4a1ef9..0000000\n--- a/sysdeps/mips/bits/nan.h\n+++ /dev/null\n@@ -1,67 +0,0 @@\n-/* `NAN' constant for IEEE 754 machines. MIPS version.\n- Copyright (C) 1992-2017 Free Software Foundation, Inc.\n- This file is part of the GNU C Library.\n-\n- The GNU C Library is free software; you can redistribute it and/or\n- modify it under the terms of the GNU Lesser General Public\n- License as published by the Free Software Foundation; either\n- version 2.1 of the License, or (at your option) any later version.\n-\n- The GNU C Library is distributed in the hope that it will be useful,\n- but WITHOUT ANY WARRANTY; without even the implied warranty of\n- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n- Lesser General Public License for more details.\n-\n- You should have received a copy of the GNU Lesser General Public\n- License along with the GNU C Library; if not, see\n- <http://www.gnu.org/licenses/>. */\n-\n-#ifndef _MATH_H\n-# error \"Never use <bits/nan.h> directly; include <math.h> instead.\"\n-#endif\n-\n-\n-/* IEEE Not A Number. */\n-/* In legacy-NaN mode MIPS has the qNaN and sNaN patterns reversed\n- compared to most other architectures. IEEE 754-1985 left the\n- definition of this open to implementations, and for MIPS the top bit\n- of the mantissa must be SET to indicate a sNaN. In 2008-NaN mode\n- MIPS aligned to IEEE 754-2008. */\n-\n-#if __GNUC_PREREQ(3,3)\n-\n-# define NAN\t(__builtin_nanf (\"\"))\n-\n-#elif defined __GNUC__\n-\n-/* No 2008-NaN mode support in any GCC version before 4.9. */\n-\n-# define NAN \\\n- (__extension__\t\t\t\t\t\t\t \\\n- ((union { unsigned __l __attribute__ ((__mode__ (__SI__))); float __d; }) \\\n- { __l: 0x7fbfffffUL }).__d)\n-\n-#else\n-\n-# include <endian.h>\n-\n-# if __BYTE_ORDER == __BIG_ENDIAN\n-# ifdef __mips_nan2008\n-# define __qnan_bytes\t\t{ 0x7f, 0xc0, 0, 0 }\n-# else\n-# define __qnan_bytes\t\t{ 0x7f, 0xbf, 0xff, 0xff }\n-# endif\n-# endif\n-# if __BYTE_ORDER == __LITTLE_ENDIAN\n-# ifdef __mips_nan2008\n-# define __qnan_bytes\t\t{ 0, 0, 0xc0, 0x7f }\n-# else\n-# define __qnan_bytes\t\t{ 0xff, 0xff, 0xbf, 0x7f }\n-# endif\n-# endif\n-\n-static union { unsigned char __c[4]; float __d; } __qnan_union\n- __attribute__ ((__unused__)) = { __qnan_bytes };\n-# define NAN\t(__qnan_union.__d)\n-\n-#endif\t/* GCC. */\n", "prefixes": [] }