Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808303/?format=api
{ "id": 808303, "url": "http://patchwork.ozlabs.org/api/patches/808303/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170831162557.24904-1-naveen.n.rao@linux.vnet.ibm.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170831162557.24904-1-naveen.n.rao@linux.vnet.ibm.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170831162557.24904-1-naveen.n.rao@linux.vnet.ibm.com/", "date": "2017-08-31T16:25:57", "name": "powerpc/signal: Properly handle return value from uprobe_deny_signal()", "commit_ref": "46725b17f1c6c815a41429259b3f070c01e71bc1", "pull_url": null, "state": "accepted", "archived": false, "hash": "81b89dd1db5b569bb76e707b547fadfd53a5ad7e", "submitter": { "id": 15185, "url": "http://patchwork.ozlabs.org/api/people/15185/?format=api", "name": "Naveen N. Rao", "email": "naveen.n.rao@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170831162557.24904-1-naveen.n.rao@linux.vnet.ibm.com/mbox/", "series": [ { "id": 868, "url": "http://patchwork.ozlabs.org/api/series/868/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=868", "date": "2017-08-31T16:25:57", "name": "powerpc/signal: Properly handle return value from uprobe_deny_signal()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/868/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808303/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808303/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjnsh6D6Vz9s7M\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 1 Sep 2017 02:30:16 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjnsh5J3hzDqYl\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 1 Sep 2017 02:30:16 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjnr62W0jzDqGX\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 1 Sep 2017 02:28:54 +1000 (AEST)", "from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7VGPAK2125630\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 31 Aug 2017 12:28:52 -0400", "from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cphwwyhvm-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linuxppc-dev@lists.ozlabs.org>; Thu, 31 Aug 2017 12:28:51 -0400", "from localhost\n\tby e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linuxppc-dev@lists.ozlabs.org> from\n\t<naveen.n.rao@linux.vnet.ibm.com>; Fri, 1 Sep 2017 02:28:49 +1000", "from d23relay06.au.ibm.com (202.81.31.225)\n\tby e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 1 Sep 2017 02:28:47 +1000", "from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])\n\tby d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv7VGSkj438666468\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 1 Sep 2017 02:28:46 +1000", "from d23av01.au.ibm.com (localhost [127.0.0.1])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv7VGSkVf018713\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 1 Sep 2017 02:28:46 +1000", "from naverao1-tp.ibm.com ([9.124.220.181])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv7VGSeii018587; Fri, 1 Sep 2017 02:28:42 +1000" ], "From": "\"Naveen N. Rao\" <naveen.n.rao@linux.vnet.ibm.com>", "To": "Michael Ellerman <mpe@ellerman.id.au>", "Subject": "[PATCH] powerpc/signal: Properly handle return value from\n\tuprobe_deny_signal()", "Date": "Thu, 31 Aug 2017 21:55:57 +0530", "X-Mailer": "git-send-email 2.14.1", "X-TM-AS-MML": "disable", "x-cbid": "17083116-0040-0000-0000-0000035245D2", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17083116-0041-0000-0000-00000CD04B27", "Message-Id": "<20170831162557.24904-1-naveen.n.rao@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-31_07:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310243", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Richard Weinberger <richard@nod.at>, linuxppc-dev@lists.ozlabs.org,\n\tAnton Blanchard <anton@samba.org>,\n\tSrikar Dronamraju <srikar@linux.vnet.ibm.com>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "When a uprobe is installed on an instruction that we currently do not\nemulate, we copy the instruction into a xol buffer and single step\nthat instruction. If that instruction generates a fault, we abort the\nsingle stepping before invoking the signal handler. Once the signal\nhandler is done, the uprobe trap is hit again since the instruction is\nretried and the process repeats.\n\nWe use uprobe_deny_signal() to detect if the xol instruction triggered\na signal. If so, we clear TIF_SIGPENDING and set TIF_UPROBE so that the\nsignal is not handled until after the single stepping is aborted. In\nthis case, uprobe_deny_signal() returns true and get_signal() ends up\nreturning 0. However, in do_signal(), we are not looking at the return\nvalue, but depending on ksig.sig for further action, all with an\nuninitialized ksig that is not touched in this scenario. Fix the same\nby initializing ksig.sig to 0.\n\nFixes: 129b69df9c907 (\"powerpc: Use get_signal() signal_setup_done()\")\n\nReported-by: Anton Blanchard <anton@samba.org>\nSigned-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>\n---\n arch/powerpc/kernel/signal.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c\nindex e9436c5e1e09..3d7539b90010 100644\n--- a/arch/powerpc/kernel/signal.c\n+++ b/arch/powerpc/kernel/signal.c\n@@ -103,7 +103,7 @@ static void check_syscall_restart(struct pt_regs *regs, struct k_sigaction *ka,\n static void do_signal(struct task_struct *tsk)\n {\n \tsigset_t *oldset = sigmask_to_save();\n-\tstruct ksignal ksig;\n+\tstruct ksignal ksig = { .sig = 0 };\n \tint ret;\n \tint is32 = is_32bit_task();\n \n", "prefixes": [] }