Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808270/?format=api
{ "id": 808270, "url": "http://patchwork.ozlabs.org/api/patches/808270/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170831144743.GA21261@amd/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170831144743.GA21261@amd>", "list_archive_url": null, "date": "2017-08-31T14:47:43", "name": "wl1251: add a missing spin_lock_init()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d3ec4da85ea0c3c7b2b5d03f2577c911f4405396", "submitter": { "id": 2109, "url": "http://patchwork.ozlabs.org/api/people/2109/?format=api", "name": "Pavel Machek", "email": "pavel@ucw.cz" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170831144743.GA21261@amd/mbox/", "series": [ { "id": 843, "url": "http://patchwork.ozlabs.org/api/series/843/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=843", "date": "2017-08-31T14:47:43", "name": "wl1251: add a missing spin_lock_init()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/843/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808270/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808270/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjlbg6nGXz9s7c\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 1 Sep 2017 00:47:59 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751463AbdHaOrr (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 31 Aug 2017 10:47:47 -0400", "from atrey.karlin.mff.cuni.cz ([195.113.26.193]:43820 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751011AbdHaOrp (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 31 Aug 2017 10:47:45 -0400", "by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid 02FF3825CB; Thu, 31 Aug 2017 16:47:43 +0200 (CEST)" ], "Date": "Thu, 31 Aug 2017 16:47:43 +0200", "From": "Pavel Machek <pavel@ucw.cz>", "To": "Kalle Valo <kvalo@codeaurora.org>,\n\tLinus Torvalds <torvalds@linux-foundation.org>", "Cc": "David Miller <davem@davemloft.net>, xiyou.wangcong@gmail.com,\n\ttorvalds@linux-foundation.org, akpm@linux-foundation.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-wireless@vger.kernel.org", "Subject": "[PATCH] wl1251: add a missing spin_lock_init()", "Message-ID": "<20170831144743.GA21261@amd>", "References": "<87pobdt8qc.fsf@kamboji.qca.qualcomm.com>\n\t<20170830.101143.2305098064824357647.davem@davemloft.net>\n\t<87val5rmh8.fsf@kamboji.qca.qualcomm.com>\n\t<20170830.105447.125174575140677062.davem@davemloft.net>\n\t<87fuc8s5v9.fsf@kamboji.qca.qualcomm.com>\n\t<20170831065204.GA17812@amd>\n\t<87y3q0q7ln.fsf@kamboji.qca.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"7JfCtLOvnd9MIVvH\"", "Content-Disposition": "inline", "In-Reply-To": "<87y3q0q7ln.fsf@kamboji.qca.qualcomm.com>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Cong Wang <xiyou.wangcong@gmail.com>\n\nwl1251: add a missing spin_lock_init()\n \nThis fixes the following kernel warning:\n \n [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745\n [ 5668.771850] lock: 0xce63ef20, .magic: 00000000, .owner: <none>/-1,\n .owner_cpu: 0\n [ 5668.772277] CPU: 0 PID: 9745 Comm: kworker/u2:3 Tainted: G W\n 4.12.0-03002-gec979a4-dirty #40\n [ 5668.772796] Hardware name: Nokia RX-51 board\n [ 5668.773071] Workqueue: phy1 wl1251_irq_work\n [ 5668.773345] [<c010c9e4>] (unwind_backtrace) from [<c010a274>]\n (show_stack+0x10/0x14)\n [ 5668.773803] [<c010a274>] (show_stack) from [<c01545a4>]\n (do_raw_spin_lock+0x6c/0xa0)\n [ 5668.774230] [<c01545a4>] (do_raw_spin_lock) from [<c06ca578>]\n (_raw_spin_lock_irqsave+0x10/0x18)\n [ 5668.774658] [<c06ca578>] (_raw_spin_lock_irqsave) from [<c048c010>]\n (wl1251_op_tx+0x38/0x5c)\n [ 5668.775115] [<c048c010>] (wl1251_op_tx) from [<c06a12e8>]\n (ieee80211_tx_frags+0x188/0x1c0)\n [ 5668.775543] [<c06a12e8>] (ieee80211_tx_frags) from [<c06a138c>]\n (__ieee80211_tx+0x6c/0x130)\n [ 5668.775970] [<c06a138c>] (__ieee80211_tx) from [<c06a3dbc>]\n (ieee80211_tx+0xdc/0x104)\n [ 5668.776367] [<c06a3dbc>] (ieee80211_tx) from [<c06a4af0>]\n (__ieee80211_subif_start_xmit+0x454/0x8c8)\n [ 5668.776824] [<c06a4af0>] (__ieee80211_subif_start_xmit) from\n [<c06a4f94>] (ieee80211_subif_start_xmit+0x30/0x2fc)\n [ 5668.777343] [<c06a4f94>] (ieee80211_subif_start_xmit) from\n [<c0578848>] (dev_hard_start_xmit+0x80/0x118)\n...\n \n by adding the missing spin_lock_init().\n \nReported-by: Pavel Machek <pavel@ucw.cz>\nCc: Kalle Valo <kvalo@codeaurora.org>\nSigned-off-by: Cong Wang <xiyou.wangcong@gmail.com>\nAcked-by: Pavel Machek <pavel@ucw.cz>\nSigned-off-by: Kalle Valo <kvalo@codeaurora.org>\nSigned-off-by: Pavel Machek <pavel@ucw.cz>\nCc: stable@kernel.org\n\n---\n\n> >> Yeah, you are right there. I did actually ponder which I tree should\n> >> commit it back in July but due to various reasons decided differently.\n> >\n> > Can we still get the fix to v4.13-final? :-).\n> \n> I'm not planning to submit pull requests to 4.13 anymore. If you think\n> this is so important that it needs to be applied in the last minute (I\n> don't) you could always try to convince Dave to take it directly.\n> \n> Or better yet, push it to the stable tree. If the merge window opens on\n> Sunday I suspect that the commit will be in Linus' tree sometime next\n> week. Then you can submit the request to the stable team to take it.\n\nI don't think we should use stable tree as an excuse for not fixing\nthe bugs in mainline. Original patch is from Jul 6, thats 7 weeks ago.\n\nDave, Linus -- can you still take the patch?\n\nThanks,\n\t\t\t\t\t\t\t\tPavel", "diff": "diff --git a/drivers/net/wireless/ti/wl1251/main.c b/drivers/net/wireless/ti/wl1251/main.c\nindex 08f0477..9915d83 100644\n--- a/drivers/net/wireless/ti/wl1251/main.c\n+++ b/drivers/net/wireless/ti/wl1251/main.c\n@@ -1571,6 +1571,7 @@ struct ieee80211_hw *wl1251_alloc_hw(void)\n \n \twl->state = WL1251_STATE_OFF;\n \tmutex_init(&wl->mutex);\n+\tspin_lock_init(&wl->wl_lock);\n \n \twl->tx_mgmt_frm_rate = DEFAULT_HW_GEN_TX_RATE;\n \twl->tx_mgmt_frm_mod = DEFAULT_HW_GEN_MODULATION_TYPE;\n", "prefixes": [] }