Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808236/?format=api
{ "id": 808236, "url": "http://patchwork.ozlabs.org/api/patches/808236/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504186749-8926-2-git-send-email-lipeng321@huawei.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504186749-8926-2-git-send-email-lipeng321@huawei.com>", "list_archive_url": null, "date": "2017-08-31T13:39:02", "name": "[net-next,1/8] net: hns3: add check when initialize", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "842bdae628097fb1e58c1bf5e888e05f8b046cc9", "submitter": { "id": 71468, "url": "http://patchwork.ozlabs.org/api/people/71468/?format=api", "name": "lipeng (Y)", "email": "lipeng321@huawei.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504186749-8926-2-git-send-email-lipeng321@huawei.com/mbox/", "series": [ { "id": 823, "url": "http://patchwork.ozlabs.org/api/series/823/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=823", "date": "2017-08-31T13:39:02", "name": "Bug fixes & Code improvements in HNS driver", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/823/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808236/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808236/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjjT11PTVz9sMN\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 23:12:05 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751547AbdHaNL1 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 31 Aug 2017 09:11:27 -0400", "from szxga05-in.huawei.com ([45.249.212.191]:5067 \"EHLO\n\tszxga05-in.huawei.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751001AbdHaNLY (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 31 Aug 2017 09:11:24 -0400", "from 172.30.72.60 (EHLO DGGEMS404-HUB.china.huawei.com)\n\t([172.30.72.60])\n\tby dggrg05-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id DGI62424; Thu, 31 Aug 2017 21:11:20 +0800 (CST)", "from linux-ioko.site (10.71.200.31) by\n\tDGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP\n\tServer id 14.3.301.0; Thu, 31 Aug 2017 21:11:09 +0800" ], "From": "Lipeng <lipeng321@huawei.com>", "To": "<davem@davemloft.net>", "CC": "<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,\n\t<linuxarm@huawei.com>, <yisen.zhuang@huawei.com>,\n\t<salil.mehta@huawei.com>, <lipeng321@huawei.com>", "Subject": "[PATCH net-next 1/8] net: hns3: add check when initialize", "Date": "Thu, 31 Aug 2017 21:39:02 +0800", "Message-ID": "<1504186749-8926-2-git-send-email-lipeng321@huawei.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1504186749-8926-1-git-send-email-lipeng321@huawei.com>", "References": "<1504186749-8926-1-git-send-email-lipeng321@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.71.200.31]", "X-CFilter-Loop": "Reflected", "X-Mirapoint-Virus-RAPID-Raw": "score=unknown(0),\n\trefid=str=0001.0A020204.59A80AF9.014C, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32", "X-Mirapoint-Loop-Id": "0bc0be39570d53390a651bd785594e3e", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "private waterline and and common packet buffer\n\nCommand HCLGE_OPC_RX_PRIV_WL_ALLOC configure waterline for TC's PFC,\nwhich has private buffer.Command HCLGE_OPC_RX_COM_THRD_ALLOC Control\neach TC's occupation in common packet buffer, also generate PFC for\nTC, which has not private buffer.When device do not support DCB,\ncommand HCLGE_OPC_RX_PRIV_WL_ALLOC and HCLGE_OPC_RX_COM_THRD_ALLOC\nshould not be used.\n\nThe current code does not support DCB feature, DCB feature will be added\nlater. The current code works well if device support DCB though it do\nnot enable DCB feature, but it works fail if device do not support DCB.\n\nSigned-off-by: Lipeng <lipeng321@huawei.com>\n---\n drivers/net/ethernet/hisilicon/hns3/hnae3.h | 1 +\n .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 41 ++++++++++++++++------\n 2 files changed, 31 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h b/drivers/net/ethernet/hisilicon/hns3/hnae3.h\nindex b2f28ae..e23e028 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hnae3.h\n+++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.h\n@@ -50,6 +50,7 @@\n \n #define HNAE3_DEV_INITED_B\t\t\t0x0\n #define HNAE_DEV_SUPPORT_ROCE_B\t\t\t0x1\n+#define HNAE_DEV_SUPPORT_DCB_B\t\t\t0x2\n \n #define ring_ptr_move_fw(ring, p) \\\n \t((ring)->p = ((ring)->p + 1) % (ring)->desc_num)\ndiff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\nindex bb45365..acc4016 100644\n--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c\n@@ -60,6 +60,16 @@ static int hclge_set_mta_filter_mode(struct hclge_dev *hdev,\n \t{0, }\n };\n \n+static const struct pci_device_id dcb_pci_tbl[] = {\n+\t{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_25GE_RDMA), 0},\n+\t{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_25GE_RDMA_MACSEC), 0},\n+\t{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_50GE_RDMA), 0},\n+\t{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_50GE_RDMA_MACSEC), 0},\n+\t{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_100G_RDMA_MACSEC), 0},\n+\t/* Required last entry */\n+\t{0, }\n+};\n+\n static const char hns3_nic_test_strs[][ETH_GSTRING_LEN] = {\n \t\"Mac Loopback test\",\n \t\"Serdes Loopback test\",\n@@ -1782,18 +1792,23 @@ int hclge_buffer_alloc(struct hclge_dev *hdev)\n \t\treturn ret;\n \t}\n \n-\tret = hclge_rx_priv_wl_config(hdev);\n-\tif (ret) {\n-\t\tdev_err(&hdev->pdev->dev,\n-\t\t\t\"could not configure rx private waterline %d\\n\", ret);\n-\t\treturn ret;\n-\t}\n+\tif (hnae_get_bit(hdev->ae_dev->flag,\n+\t\t\t HNAE_DEV_SUPPORT_DCB_B)) {\n+\t\tret = hclge_rx_priv_wl_config(hdev);\n+\t\tif (ret) {\n+\t\t\tdev_err(&hdev->pdev->dev,\n+\t\t\t\t\"could not configure rx private waterline %d\\n\",\n+\t\t\t\tret);\n+\t\t\treturn ret;\n+\t\t}\n \n-\tret = hclge_common_thrd_config(hdev);\n-\tif (ret) {\n-\t\tdev_err(&hdev->pdev->dev,\n-\t\t\t\"could not configure common threshold %d\\n\", ret);\n-\t\treturn ret;\n+\t\tret = hclge_common_thrd_config(hdev);\n+\t\tif (ret) {\n+\t\t\tdev_err(&hdev->pdev->dev,\n+\t\t\t\t\"could not configure common threshold %d\\n\",\n+\t\t\t\tret);\n+\t\t\treturn ret;\n+\t\t}\n \t}\n \n \tret = hclge_common_wl_config(hdev);\n@@ -4076,6 +4091,10 @@ static int hclge_init_ae_dev(struct hnae3_ae_dev *ae_dev)\n \tif (id)\n \t\thnae_set_bit(ae_dev->flag, HNAE_DEV_SUPPORT_ROCE_B, 1);\n \n+\tid = pci_match_id(dcb_pci_tbl, ae_dev->pdev);\n+\tif (id)\n+\t\thnae_set_bit(ae_dev->flag, HNAE_DEV_SUPPORT_DCB_B, 1);\n+\n \tret = hclge_pci_init(hdev);\n \tif (ret) {\n \t\tdev_err(&pdev->dev, \"PCI init failed\\n\");\n", "prefixes": [ "net-next", "1/8" ] }