Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808185/?format=api
{ "id": 808185, "url": "http://patchwork.ozlabs.org/api/patches/808185/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-22-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170831103432.6007-22-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2017-08-31T10:34:24", "name": "[PULL,21/29] msix: use DIV_ROUND_UP", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6957a939a39784e578965738eb56ff801441e1a5", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-22-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 788, "url": "http://patchwork.ozlabs.org/api/series/788/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=788", "date": "2017-08-31T10:34:03", "name": "[PULL,01/29] i386: use ROUND_UP macro", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/788/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808185/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808185/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjfLq1S3zz9t2f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 20:51:31 +1000 (AEST)", "from localhost ([::1]:54944 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnN3p-000685-T6\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:50:57 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:41722)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1dnMpc-0002mn-3V\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:36:17 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1dnMpb-0006Ms-9U\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:36:16 -0400", "from mx1.redhat.com ([209.132.183.28]:58668)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <marcandre.lureau@redhat.com>)\n\tid 1dnMpb-0006MW-3Q; Thu, 31 Aug 2017 06:36:15 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2D5AFC047B61;\n\tThu, 31 Aug 2017 10:36:14 +0000 (UTC)", "from localhost (ovpn-112-36.ams2.redhat.com [10.36.112.36])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C256060A98;\n\tThu, 31 Aug 2017 10:36:11 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 2D5AFC047B61", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 31 Aug 2017 12:34:24 +0200", "Message-Id": "<20170831103432.6007-22-marcandre.lureau@redhat.com>", "In-Reply-To": "<20170831103432.6007-1-marcandre.lureau@redhat.com>", "References": "<20170831103432.6007-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 31 Aug 2017 10:36:14 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 21/29] msix: use DIV_ROUND_UP", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-trivial@nongnu.org, peter.maydell@linaro.org, \"Michael S. Tsirkin\"\n\t<mst@redhat.com>, \tMarcel Apfelbaum <marcel@redhat.com>,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lurea?= =?utf-8?q?u?=\n\t<marcandre.lureau@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "I used the clang-tidy qemu-round check to generate the fix:\nhttps://github.com/elmarco/clang-tools-extra\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nReviewed-by: Richard Henderson <rth@twiddle.net>\n---\n hw/pci/msix.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/hw/pci/msix.c b/hw/pci/msix.c\nindex 5078d3dd19..c944c02135 100644\n--- a/hw/pci/msix.c\n+++ b/hw/pci/msix.c\n@@ -438,7 +438,7 @@ void msix_save(PCIDevice *dev, QEMUFile *f)\n }\n \n qemu_put_buffer(f, dev->msix_table, n * PCI_MSIX_ENTRY_SIZE);\n- qemu_put_buffer(f, dev->msix_pba, (n + 7) / 8);\n+ qemu_put_buffer(f, dev->msix_pba, DIV_ROUND_UP(n, 8));\n }\n \n /* Should be called after restoring the config space. */\n@@ -453,7 +453,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f)\n \n msix_clear_all_vectors(dev);\n qemu_get_buffer(f, dev->msix_table, n * PCI_MSIX_ENTRY_SIZE);\n- qemu_get_buffer(f, dev->msix_pba, (n + 7) / 8);\n+ qemu_get_buffer(f, dev->msix_pba, DIV_ROUND_UP(n, 8));\n msix_update_function_masked(dev);\n \n for (vector = 0; vector < n; vector++) {\n", "prefixes": [ "PULL", "21/29" ] }