Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808180/?format=api
{ "id": 808180, "url": "http://patchwork.ozlabs.org/api/patches/808180/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-18-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170831103432.6007-18-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2017-08-31T10:34:20", "name": "[PULL,17/29] virtio-serial: use DIV_ROUND_UP", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "65b161ac22e39b171701d43aa037ecb30bfc0e24", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-18-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 788, "url": "http://patchwork.ozlabs.org/api/series/788/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=788", "date": "2017-08-31T10:34:03", "name": "[PULL,01/29] i386: use ROUND_UP macro", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/788/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808180/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjfHD1V02z9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 20:48:24 +1000 (AEST)", "from localhost ([::1]:54929 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnN1K-0004Ir-8u\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:48:22 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:41524)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1dnMpJ-0002Y6-T7\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:36:01 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1dnMpI-0006Dx-TV\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:35:57 -0400", "from mx1.redhat.com ([209.132.183.28]:45731)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <marcandre.lureau@redhat.com>)\n\tid 1dnMpI-0006Dj-FM; Thu, 31 Aug 2017 06:35:56 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8788D883D2;\n\tThu, 31 Aug 2017 10:35:55 +0000 (UTC)", "from localhost (ovpn-112-36.ams2.redhat.com [10.36.112.36])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E846E92BAB;\n\tThu, 31 Aug 2017 10:35:54 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 8788D883D2", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 31 Aug 2017 12:34:20 +0200", "Message-Id": "<20170831103432.6007-18-marcandre.lureau@redhat.com>", "In-Reply-To": "<20170831103432.6007-1-marcandre.lureau@redhat.com>", "References": "<20170831103432.6007-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 31 Aug 2017 10:35:55 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 17/29] virtio-serial: use DIV_ROUND_UP", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, \"Michael S. Tsirkin\" <mst@redhat.com>,\n\tqemu-trivial@nongnu.org, Amit Shah <amit@kernel.org>, =?utf-8?q?Marc-?=\n\t=?utf-8?q?Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n\tPaolo Bonzini <pbonzini@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "I used the clang-tidy qemu-round check to generate the fix:\nhttps://github.com/elmarco/clang-tools-extra\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nReviewed-by: Richard Henderson <rth@twiddle.net>\nReviewed-by: Amit Shah <amit@kernel.org>\n---\n hw/char/virtio-serial-bus.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c\nindex f5bc173844..17a1bb008a 100644\n--- a/hw/char/virtio-serial-bus.c\n+++ b/hw/char/virtio-serial-bus.c\n@@ -663,7 +663,7 @@ static void virtio_serial_save_device(VirtIODevice *vdev, QEMUFile *f)\n \n /* The ports map */\n max_nr_ports = s->serial.max_virtserial_ports;\n- for (i = 0; i < (max_nr_ports + 31) / 32; i++) {\n+ for (i = 0; i < DIV_ROUND_UP(max_nr_ports, 32); i++) {\n qemu_put_be32s(f, &s->ports_map[i]);\n }\n \n@@ -798,7 +798,7 @@ static int virtio_serial_load_device(VirtIODevice *vdev, QEMUFile *f,\n qemu_get_be32s(f, &tmp);\n \n max_nr_ports = s->serial.max_virtserial_ports;\n- for (i = 0; i < (max_nr_ports + 31) / 32; i++) {\n+ for (i = 0; i < DIV_ROUND_UP(max_nr_ports, 32); i++) {\n qemu_get_be32s(f, &ports_map);\n \n if (ports_map != s->ports_map[i]) {\n@@ -863,7 +863,7 @@ static uint32_t find_free_port_id(VirtIOSerial *vser)\n unsigned int i, max_nr_ports;\n \n max_nr_ports = vser->serial.max_virtserial_ports;\n- for (i = 0; i < (max_nr_ports + 31) / 32; i++) {\n+ for (i = 0; i < DIV_ROUND_UP(max_nr_ports, 32); i++) {\n uint32_t map, zeroes;\n \n map = vser->ports_map[i];\n@@ -1075,7 +1075,7 @@ static void virtio_serial_device_realize(DeviceState *dev, Error **errp)\n vser->ovqs[i] = virtio_add_queue(vdev, 128, handle_output);\n }\n \n- vser->ports_map = g_malloc0(((vser->serial.max_virtserial_ports + 31) / 32)\n+ vser->ports_map = g_malloc0((DIV_ROUND_UP(vser->serial.max_virtserial_ports, 32))\n * sizeof(vser->ports_map[0]));\n /*\n * Reserve location 0 for a console port for backward compat\n", "prefixes": [ "PULL", "17/29" ] }