Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808173/?format=api
{ "id": 808173, "url": "http://patchwork.ozlabs.org/api/patches/808173/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-11-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170831103432.6007-11-marcandre.lureau@redhat.com>", "list_archive_url": null, "date": "2017-08-31T10:34:13", "name": "[PULL,10/29] vvfat: use DIV_ROUND_UP", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "270531ddef1f2db8bf57be3d45889db0733defc8", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170831103432.6007-11-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 788, "url": "http://patchwork.ozlabs.org/api/series/788/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=788", "date": "2017-08-31T10:34:03", "name": "[PULL,01/29] i386: use ROUND_UP macro", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/788/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808173/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcandre.lureau@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjf9p3MJCz9sQl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 20:43:42 +1000 (AEST)", "from localhost ([::1]:54902 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnMwm-0000C3-GC\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 06:43:40 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:41090)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1dnMor-00024E-7q\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:35:30 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <marcandre.lureau@redhat.com>) id 1dnMoo-0005cp-Dx\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 06:35:29 -0400", "from mx1.redhat.com ([209.132.183.28]:41062)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <marcandre.lureau@redhat.com>)\n\tid 1dnMom-0005az-4z; Thu, 31 Aug 2017 06:35:24 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4210E883AC;\n\tThu, 31 Aug 2017 10:35:23 +0000 (UTC)", "from localhost (ovpn-112-36.ams2.redhat.com [10.36.112.36])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id ADA4F92B93;\n\tThu, 31 Aug 2017 10:35:20 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 4210E883AC", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 31 Aug 2017 12:34:13 +0200", "Message-Id": "<20170831103432.6007-11-marcandre.lureau@redhat.com>", "In-Reply-To": "<20170831103432.6007-1-marcandre.lureau@redhat.com>", "References": "<20170831103432.6007-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 31 Aug 2017 10:35:23 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 10/29] vvfat: use DIV_ROUND_UP", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, peter.maydell@linaro.org, \"open\n\tlist:vvfat\" <qemu-block@nongnu.org>, qemu-trivial@nongnu.org,\n\tMax Reitz <mreitz@redhat.com>, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t<marcandre.lureau@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "I used the clang-tidy qemu-round check to generate the fix:\nhttps://github.com/elmarco/clang-tools-extra\n\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\nReviewed-by: Eric Blake <eblake@redhat.com>\nReviewed-by: Richard Henderson <rth@twiddle.net>\n---\n block/vvfat.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/block/vvfat.c b/block/vvfat.c\nindex a9e207f7f0..c54fa94651 100644\n--- a/block/vvfat.c\n+++ b/block/vvfat.c\n@@ -449,7 +449,7 @@ static direntry_t *create_long_filename(BDRVVVFATState *s, const char *filename)\n return NULL;\n }\n \n- number_of_entries = (length * 2 + 25) / 26;\n+ number_of_entries = DIV_ROUND_UP(length * 2, 26);\n \n for(i=0;i<number_of_entries;i++) {\n entry=array_get_next(&(s->directory));\n@@ -2554,7 +2554,7 @@ static int commit_one_file(BDRVVVFATState* s,\n (size > offset && c >=2 && !fat_eof(s, c)));\n \n ret = vvfat_read(s->bs, cluster2sector(s, c),\n- (uint8_t*)cluster, (rest_size + 0x1ff) / 0x200);\n+ (uint8_t*)cluster, DIV_ROUND_UP(rest_size, 0x200));\n \n if (ret < 0) {\n qemu_close(fd);\n", "prefixes": [ "PULL", "10/29" ] }