Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808079/?format=api
{ "id": 808079, "url": "http://patchwork.ozlabs.org/api/patches/808079/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1504163557-14432-5-git-send-email-cclaudio@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504163557-14432-5-git-send-email-cclaudio@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-31T07:12:36", "name": "[v2,4/5] hdata/i2c: ignore the secure window and physical presence i2c devs", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "fc9e491aaab2cf6b49e8336c7e53b27692b4ca43", "submitter": { "id": 69305, "url": "http://patchwork.ozlabs.org/api/people/69305/?format=api", "name": "Claudio Carvalho", "email": "cclaudio@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1504163557-14432-5-git-send-email-cclaudio@linux.vnet.ibm.com/mbox/", "series": [ { "id": 758, "url": "http://patchwork.ozlabs.org/api/series/758/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=758", "date": "2017-08-31T07:12:32", "name": "hdata/i2c: add support to i2c array version 2 in P9", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/758/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808079/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808079/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjYYz6X8Fz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 17:15:51 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjYYz5j15zDqkY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 17:15:51 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjYVd3HKYzDqZv\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 17:12:57 +1000 (AEST)", "from pps.filterd (m0098420.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7V79YuV046602\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 03:12:54 -0400", "from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cpdd6993k-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 03:12:54 -0400", "from localhost\n\tby e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <cclaudio@linux.vnet.ibm.com>;\n\tThu, 31 Aug 2017 03:12:54 -0400", "from b01cxnp22035.gho.pok.ibm.com (9.57.198.25)\n\tby e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 31 Aug 2017 03:12:52 -0400", "from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7V7Cq3K33292432; Thu, 31 Aug 2017 07:12:52 GMT", "from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8280AAE034;\n\tThu, 31 Aug 2017 03:13:16 -0400 (EDT)", "from legolas.ibm.com (unknown [9.85.193.48])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id D5DE1AE03C;\n\tThu, 31 Aug 2017 03:13:15 -0400 (EDT)" ], "From": "Claudio Carvalho <cclaudio@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Thu, 31 Aug 2017 04:12:36 -0300", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504163557-14432-1-git-send-email-cclaudio@linux.vnet.ibm.com>", "References": "<1504163557-14432-1-git-send-email-cclaudio@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17083107-0008-0000-0000-0000027738D2", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007640; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00910094; UDB=6.00456508;\n\tIPR=6.00690374; \n\tBA=6.00005562; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016938;\n\tXFM=3.00000015; UTC=2017-08-31 07:12:54", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17083107-0009-0000-0000-0000368BD400", "Message-Id": "<1504163557-14432-5-git-send-email-cclaudio@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-31_02:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310109", "Subject": "[Skiboot] [PATCH v2 4/5] hdata/i2c: ignore the secure window and\n\tphysical presence i2c devs", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "This ignores the secure window and physical presence i2c devices since\nthey are failing the HDAT parsing and they won't be used for now.\n\nIn P9, the secure window and physical presence are gpio pins in an i2c\ngpio expander. In the HDAT the secure window and physical presence are\nduplicates of the associated i2c gpio expander device, however\ndistinguished by the gpio port. That causes a failure when dt_new_addr()\nis called because skiboot is not able to distinguish nodes by port.\n\nSigned-off-by: Claudio Carvalho <cclaudio@linux.vnet.ibm.com>\n---\n hdata/i2c.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/hdata/i2c.c b/hdata/i2c.c\nindex 14650b6..8a2e392 100644\n--- a/hdata/i2c.c\n+++ b/hdata/i2c.c\n@@ -259,6 +259,20 @@ int parse_i2c_devs(const struct HDIF_common_hdr *hdr, int idata_index,\n \t\t\tcompat = NULL;\n \t\t}\n \n+\t\t/*\n+\t\t * TODO: Create devtree entries for the secure window and\n+\t\t * physical presence. In the hdat they are i2c gpio-expander\n+\t\t * devices distinguished only by the port property.\n+\t\t */\n+\t\tif (be32_to_cpu(dev->purpose) == 0xd ||\n+\t\t be32_to_cpu(dev->purpose) == 0xe) {\n+\t\t\tprlog(PR_INFO, \"HDAT I2C: ignoring e%dp%d - %s@%x \"\n+\t\t\t \"(port 0x%x) - %s\\n\", dev->i2cm_engine,\n+\t\t\t dev->i2cm_port, name, i2c_addr, dev->i2c_port,\n+\t\t\t label);\n+\t\t\tcontinue;\n+\t\t}\n+\n \t\tnode = dt_new_addr(bus, name, i2c_addr);\n \t\tif (!node)\n \t\t\tcontinue;\n", "prefixes": [ "v2", "4/5" ] }