Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808057/?format=api
{ "id": 808057, "url": "http://patchwork.ozlabs.org/api/patches/808057/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1504161961-12190-9-git-send-email-cclaudio@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504161961-12190-9-git-send-email-cclaudio@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-31T06:45:56", "name": "[08/13] libstb: clean up the force-secure-mode and force-trusted-mode from nvram", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1b3888df673ec248a978e6371e50912782803d6f", "submitter": { "id": 69305, "url": "http://patchwork.ozlabs.org/api/people/69305/?format=api", "name": "Claudio Carvalho", "email": "cclaudio@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1504161961-12190-9-git-send-email-cclaudio@linux.vnet.ibm.com/mbox/", "series": [ { "id": 754, "url": "http://patchwork.ozlabs.org/api/series/754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=754", "date": "2017-08-31T06:45:48", "name": "libstb: simplify the initialization of cvc drivers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/754/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808057/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808057/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjXy33tZtz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 16:48:11 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjXy32sCXzDqfn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 16:48:11 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjXw72ptnzDqTr\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 16:46:31 +1000 (AEST)", "from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7V6icGC006035\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 02:46:28 -0400", "from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cpar7b3bc-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 02:46:28 -0400", "from localhost\n\tby e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <cclaudio@linux.vnet.ibm.com>;\n\tThu, 31 Aug 2017 00:46:27 -0600", "from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 31 Aug 2017 00:46:25 -0600", "from b03ledav004.gho.boulder.ibm.com\n\t(b03ledav004.gho.boulder.ibm.com [9.17.130.235])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7V6kPBo32112798\n\tfor <skiboot@lists.ozlabs.org>; Wed, 30 Aug 2017 23:46:25 -0700", "from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 3625778043\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 00:46:25 -0600 (MDT)", "from legolas.ibm.com (unknown [9.85.193.48])\n\tby b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id 8F51C7803F\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 00:46:24 -0600 (MDT)" ], "From": "Claudio Carvalho <cclaudio@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Thu, 31 Aug 2017 03:45:56 -0300", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504161961-12190-1-git-send-email-cclaudio@linux.vnet.ibm.com>", "References": "<1504161961-12190-1-git-send-email-cclaudio@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17083106-0024-0000-0000-000017200F54", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007640; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00910085; UDB=6.00456503;\n\tIPR=6.00690365; \n\tBA=6.00005562; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016938;\n\tXFM=3.00000015; UTC=2017-08-31 06:46:26", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17083106-0025-0000-0000-00004C871193", "Message-Id": "<1504161961-12190-9-git-send-email-cclaudio@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-31_01:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708310102", "Subject": "[Skiboot] [PATCH 08/13] libstb: clean up the force-secure-mode and\n\tforce-trusted-mode from nvram", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "This just renames the ibm_secureboot variable to node and organize the\ncode that checks the force-secure-mode and force-trusted-mode from\nnvram.\n\nSigned-off-by: Claudio Carvalho <cclaudio@linux.vnet.ibm.com>\n---\n libstb/stb.c | 34 ++++++++++++++--------------------\n 1 file changed, 14 insertions(+), 20 deletions(-)", "diff": "diff --git a/libstb/stb.c b/libstb/stb.c\nindex eb77038..a238378 100644\n--- a/libstb/stb.c\n+++ b/libstb/stb.c\n@@ -90,41 +90,35 @@ static void sb_enforce(void)\n \n void stb_init(void)\n {\n-\tstruct dt_node *ibm_secureboot;\n-\t/*\n-\t * The ibm,secureboot device tree properties are documented in\n-\t * 'doc/device-tree/ibm,secureboot.rst'\n-\t */\n-\tibm_secureboot = dt_find_by_path(dt_root, \"/ibm,secureboot\");\n-\tif (ibm_secureboot == NULL) {\n+\tstruct dt_node *node;\n+\n+\tnode = dt_find_by_path(dt_root, \"/ibm,secureboot\");\n+\tif (!node) {\n \t\tprlog(PR_NOTICE,\"STB: secure and trusted boot not supported\\n\");\n \t\treturn;\n \t}\n \n-\tsecure_mode = dt_has_node_property(ibm_secureboot, \"secure-enabled\",\n-\t\t\t\t\t NULL);\n-\n \tif (nvram_query_eq(\"force-secure-mode\", \"always\")) {\n-\t\tprlog(PR_NOTICE, \"STB: secure mode on (FORCED by nvram)\\n\");\n \t\tsecure_mode = true;\n-\t} else if (secure_mode) {\n-\t\tprlog(PR_NOTICE, \"STB: secure mode on.\\n\");\n+\t\tprlog(PR_NOTICE, \"STB: secure mode on (FORCED by nvram)\\n\");\n \t} else {\n-\t\tprlog(PR_NOTICE, \"STB: secure mode off\\n\");\n+\t\tsecure_mode = dt_has_node_property(node, \"secure-enabled\", NULL);\n+\t\tprlog(PR_NOTICE, \"STB: secure mode %s\\n\",\n+\t\t secure_mode ? \"on\" : \"off\");\n \t}\n \n-\ttrusted_mode = dt_has_node_property(ibm_secureboot, \"trusted-enabled\",\n-\t\t\t\t\t NULL);\n \tif (nvram_query_eq(\"force-trusted-mode\", \"true\")) {\n-\t\tprlog(PR_NOTICE, \"STB: trusted mode ON (from NVRAM)\\n\");\n \t\ttrusted_mode = true;\n+\t\tprlog(PR_NOTICE, \"STB: trusted mode on (FORCED by nvram)\\n\");\n+\t} else {\n+\t\ttrusted_mode = dt_has_node_property(node, \"trusted-enabled\", NULL);\n+\t\tprlog(PR_NOTICE, \"STB: trusted mode %s\\n\",\n+\t\t trusted_mode ? \"on\" : \"off\");\n \t}\n-\tprlog(PR_NOTICE, \"STB: trusted mode %s\\n\",\n-\t trusted_mode ? \"on\" : \"off\");\n \n \tif (!secure_mode && !trusted_mode)\n \t\treturn;\n-\tc1vc = rom_init(ibm_secureboot);\n+\tc1vc = rom_init(node);\n \tif (secure_mode && !c1vc) {\n \t\tprlog(PR_EMERG, \"STB: compatible romcode driver not found\\n\");\n \t\tsb_enforce();\n", "prefixes": [ "08/13" ] }