Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808001/?format=api
{ "id": 808001, "url": "http://patchwork.ozlabs.org/api/patches/808001/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/20170831034850.2569-1-oohall@gmail.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170831034850.2569-1-oohall@gmail.com>", "list_archive_url": null, "date": "2017-08-31T03:48:50", "name": "platform/witherspoon: Remove PHB4_SHARED_SLOT_IDX_WITHERSPOON constant", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e042b5c9a3cda416b2d67e2ab0edd32b19ad31f4", "submitter": { "id": 68108, "url": "http://patchwork.ozlabs.org/api/people/68108/?format=api", "name": "Oliver O'Halloran", "email": "oohall@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/20170831034850.2569-1-oohall@gmail.com/mbox/", "series": [ { "id": 735, "url": "http://patchwork.ozlabs.org/api/series/735/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=735", "date": "2017-08-31T03:48:50", "name": "platform/witherspoon: Remove PHB4_SHARED_SLOT_IDX_WITHERSPOON constant", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/735/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808001/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808001/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjT0C0D39z9s2G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 13:49:47 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjT0B65KLzDqYG\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 13:49:46 +1000 (AEST)", "from mail-pg0-x242.google.com (mail-pg0-x242.google.com\n\t[IPv6:2607:f8b0:400e:c05::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjSzL5GrJzDqXn\n\tfor <skiboot@lists.ozlabs.org>; Thu, 31 Aug 2017 13:49:02 +1000 (AEST)", "by mail-pg0-x242.google.com with SMTP id r133so6442217pgr.2\n\tfor <skiboot@lists.ozlabs.org>; Wed, 30 Aug 2017 20:49:02 -0700 (PDT)", "from flat-canetoad.ozlabs.ibm.com ([122.99.82.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tm10sm11057663pgs.70.2017.08.30.20.48.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 20:49:00 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MMYRaiJG\"; dkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MMYRaiJG\"; dkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MMYRaiJG\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=VSQsk5vMTGQXq1ClA7S+cBqAELTsxXwJb/xduY5HJhY=;\n\tb=MMYRaiJGLDon3rtP443M2prJPrvssz13+QuZjVONK5lkBGG46x/1/RlRju8tzeHOVX\n\tpTSc+31pR1HCT4MRSpZVgv1kTRLlWpk2PLpO4dqsq4igcklsYQ+lqVBzFoCZwbpyfNVB\n\tRpnG5U8aWJXIeHhSZC9619+0UEr848d45ho7ppH0iIvXvFUKiueQe1us2hPreoLBT+5L\n\tCX8BC1RZCkVKUIVVTjRALX24kI3H+FKYFnz9MZSOuLoXmVxxoKqPLjrkk3vl4eZNo7df\n\tLCQk+43JlpbB0ltYfHkgSiCztaML37VfmfHdwHdBlHRJsBf5/atHdzRLIWvanufypZJg\n\tCWZw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=VSQsk5vMTGQXq1ClA7S+cBqAELTsxXwJb/xduY5HJhY=;\n\tb=PqBMlSeSgboBgUuzUJcvWz452iAq2F3r7aR/S50VkF5XinP9mwbarEtAmkKh+akDnk\n\tCIJYGeltCTaFfRzx9xb/zOQ26Zn174NQLy7h8/t1LCR8Aximh2Ijd9MuHaNKtpGDcz9K\n\tkTa2jeKcPK3+2mRzwakQ+TQ1Ef5xw4iATbdiJ2yocMa5j8VhQct8ArYb0TX2yDbLNwBD\n\tpXsOoFudyY8hmVy/0HEg8yEXRkuGm5kEahYU/k+BprPOcPzYhnYyikhKQ3jigfVlCqGb\n\tIOx6DJiXbavpRoTdYORB3TMY1WdPTHpBrlcPR9u7+g46BNaJ2jDERiqCTzySQ+p4Hw8l\n\tRUxg==", "X-Gm-Message-State": "AHYfb5io2S955ECeNWg747Wg3oILMYsap8TuaRqqnsUJPJnmR5V+FYio\n\trifJWIHQ1QLK6Q6i", "X-Received": "by 10.99.55.22 with SMTP id e22mr945240pga.101.1504151340710;\n\tWed, 30 Aug 2017 20:49:00 -0700 (PDT)", "From": "Oliver O'Halloran <oohall@gmail.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Thu, 31 Aug 2017 13:48:50 +1000", "Message-Id": "<20170831034850.2569-1-oohall@gmail.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[Skiboot] [PATCH] platform/witherspoon: Remove\n\tPHB4_SHARED_SLOT_IDX_WITHERSPOON constant", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "PHB4_SHARED_SLOT_IDX_WITHERSPOON is the index of the PHB which the\nshared slot is connected to rather than the index of the shared slot\nwhich the name suggests. This is confusing at best so this patch\nreplaces the only usages of this macro with just the PHB number\nand a comment.\n\nSigned-off-by: Oliver O'Halloran <oohall@gmail.com>\n---\n platforms/astbmc/witherspoon.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/platforms/astbmc/witherspoon.c b/platforms/astbmc/witherspoon.c\nindex 745f38018ce9..b40382810eaa 100644\n--- a/platforms/astbmc/witherspoon.c\n+++ b/platforms/astbmc/witherspoon.c\n@@ -333,8 +333,6 @@ static void dt_create_npu2(void)\n \t}\n }\n \n-#define PHB4_SHARED_SLOT_IDX_WITHERSPOON 3\n-\n static bool witherspoon_probe(void)\n {\n \tif (!dt_node_is_compatible(dt_root, \"ibm,witherspoon\"))\n@@ -420,10 +418,10 @@ static void phb4_pre_pci_fixup_witherspoon(void)\n \t\t\t\"Unexpected number of chips, skipping shared slot detection\\n\");\n \t\treturn;\n \t}\n-\tslot0 = pci_slot_find(phb4_get_opal_id(chip0->id,\n-\t\t\t\t\tPHB4_SHARED_SLOT_IDX_WITHERSPOON));\n-\tslot1 = pci_slot_find(phb4_get_opal_id(chip1->id,\n-\t\t\t\t\tPHB4_SHARED_SLOT_IDX_WITHERSPOON));\n+\n+\t/* the shared slot is connected to PHB3 on both chips */\n+\tslot0 = pci_slot_find(phb4_get_opal_id(chip0->id, 3));\n+\tslot1 = pci_slot_find(phb4_get_opal_id(chip1->id, 3));\n \tif (slot0 && slot1) {\n \t\tif (slot0->ops.get_presence_state)\n \t\t\tslot0->ops.get_presence_state(slot0, &p0);\n", "prefixes": [] }