Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807966/?format=api
{ "id": 807966, "url": "http://patchwork.ozlabs.org/api/patches/807966/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830225225.27925-8-f4bug@amsat.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170830225225.27925-8-f4bug@amsat.org>", "list_archive_url": null, "date": "2017-08-30T22:52:25", "name": "[v2,7/7] mips: update mips_cpu_list() to use object_class_get_list()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "57be1bfab508aefaa284da9d8012016878757b5f", "submitter": { "id": 70924, "url": "http://patchwork.ozlabs.org/api/people/70924/?format=api", "name": "Philippe Mathieu-Daudé", "email": "f4bug@amsat.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830225225.27925-8-f4bug@amsat.org/mbox/", "series": [ { "id": 718, "url": "http://patchwork.ozlabs.org/api/series/718/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=718", "date": "2017-08-30T22:52:19", "name": "[v2,1/7] mips: move hw/mips/cputimer.c to target/mips/", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/718/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807966/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807966/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"U0jpz0yX\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjLTZ4HYSz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 08:56:17 +1000 (AEST)", "from localhost ([::1]:53119 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnBuA-0005wz-VQ\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 18:56:15 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:34753)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnBr7-0003dC-H8\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 18:53:06 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnBr6-0002IU-Cm\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 18:53:05 -0400", "from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:35965)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)\n\tid 1dnBr6-0002IL-7j\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 18:53:04 -0400", "by mail-qt0-x242.google.com with SMTP id e2so6358782qta.3\n\tfor <qemu-devel@nongnu.org>; Wed, 30 Aug 2017 15:53:04 -0700 (PDT)", "from yoga.offpageads.com ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\t54sm4449874qts.31.2017.08.30.15.53.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 15:53:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mMpZCBUgNH1SciTDtmu+o8yxtDWeOJquCD6SOyNAQ6Y=;\n\tb=U0jpz0yXOr3CDTwBfn/yWLKIIv+T0Mv8iyYZ4gwbdADKw1VYMZsSmsN7Lw8jKgJxCj\n\tSX2AmxywX3c+VczomJix4yd+XMGf2lTk4lcP3x/JmADLEZScKLTsc54dzMHsubsnize1\n\tzSlLK3FcrbZ4Wb67nSC9ITSpO0HPNzDkaC8kqmnMu2RZph2IezLxtrPzsPJr7mICmdCn\n\t0Pp5DUP96U+ygvpvXTpsyxNdzvJCxZ99X6b7fO+ylb7JWBUrVNrQW3qqFQY87x+JKvSj\n\tKdMit6S9u3qrQfol4uk5cFldc6UpCBPl3zMuRqv9PaD5sJUngXGUyh7z2dUfQXMXzXVp\n\tqzlA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=mMpZCBUgNH1SciTDtmu+o8yxtDWeOJquCD6SOyNAQ6Y=;\n\tb=Do9a8Czx3jUD6bhQ6p9cInAYDkXv7uSGMNUBJROdzeHaO+bSJIfnygbnS97d4FeKIW\n\tmY0aCcLs2efiT9JU2tPVlfm2rjNt/BOPWGqY/WJZljf1EEF+aM6SeNibuIN8po7/kjp0\n\t109dwcUuh2tWoplvjh4DCLGavO9XFCSSGgSd3uwQnZrM+utau/xC144uMFGeyMMGvZQe\n\tuAC/jUhuwKGwjYZ6njgAeTgcUBRLJlIznAWK2Al+cTFhZx0evE54dijpxiHbKIGjQ8XT\n\tPt6TwETiT7PZ6HLE4D6WsZiiMMhWKpEttaisyo80KDBY4X0vyH7PufJ9sveNZ8eE6nD3\n\tD6xw==", "X-Gm-Message-State": "AHPjjUhXlH11oDX8s/ySAOBqoSisIi2JFlA62Dkz4S22nU9YSOc+zvzK\n\t5p9EnX8hIjWwuQ==", "X-Received": "by 10.200.11.73 with SMTP id m9mr4826373qti.229.1504133583676;\n\tWed, 30 Aug 2017 15:53:03 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>", "To": "Igor Mammedov <imammedo@redhat.com>, =?utf-8?q?Herv=C3=A9_Poussineau?=\n\t<hpoussin@reactos.org>, \tAurelien Jarno <aurelien@aurel32.net>,\n\tEduardo Habkost <ehabkost@redhat.com>, \n\tMarcel Apfelbaum <marcel@redhat.com>,\n\tJames Hogan <james.hogan@imgtec.com>, Yongbok Kim\n\t<yongbok.kim@imgtec.com>", "Date": "Wed, 30 Aug 2017 19:52:25 -0300", "Message-Id": "<20170830225225.27925-8-f4bug@amsat.org>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170830225225.27925-1-f4bug@amsat.org>", "References": "<20170830225225.27925-1-f4bug@amsat.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:400d:c0d::242", "Subject": "[Qemu-devel] [PATCH v2 7/7] mips: update mips_cpu_list() to use\n\tobject_class_get_list()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Thomas Huth <thuth@redhat.com>, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t<f4bug@amsat.org>, \tqemu-devel@nongnu.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "while here, move it from translate_init.c to helper.c\n\nSigned-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nTested-by: Igor Mammedov <imammedo@redhat.com>\nTested-by: James Hogan <james.hogan@imgtec.com>\n---\n target/mips/helper.c | 46 ++++++++++++++++++++++++++++++++++++++++++++\n target/mips/translate_init.c | 10 ----------\n 2 files changed, 46 insertions(+), 10 deletions(-)", "diff": "diff --git a/target/mips/helper.c b/target/mips/helper.c\nindex ea076261af..8d12b0088a 100644\n--- a/target/mips/helper.c\n+++ b/target/mips/helper.c\n@@ -1093,3 +1093,49 @@ void QEMU_NORETURN do_raise_exception_err(CPUMIPSState *env,\n \n cpu_loop_exit_restore(cs, pc);\n }\n+\n+/* Sort alphabetically by type name, except for \"any\". */\n+static gint mips_cpu_list_compare(gconstpointer a, gconstpointer b)\n+{\n+ ObjectClass *class_a = (ObjectClass *)a;\n+ ObjectClass *class_b = (ObjectClass *)b;\n+ const char *name_a, *name_b;\n+\n+ name_a = object_class_get_name(class_a);\n+ name_b = object_class_get_name(class_b);\n+ if (strcmp(name_a, \"any-\" TYPE_MIPS_CPU) == 0) {\n+ return 1;\n+ } else if (strcmp(name_b, \"any-\" TYPE_MIPS_CPU) == 0) {\n+ return -1;\n+ } else {\n+ return strcmp(name_a, name_b);\n+ }\n+}\n+\n+static void mips_cpu_list_entry(gpointer data, gpointer user_data)\n+{\n+ ObjectClass *oc = data;\n+ CPUListState *s = user_data;\n+ const char *typename;\n+ char *name;\n+\n+ typename = object_class_get_name(oc);\n+ name = g_strndup(typename, strlen(typename) - strlen(\"-\" TYPE_MIPS_CPU));\n+ (*s->cpu_fprintf)(s->file, \" %s\\n\", name);\n+ g_free(name);\n+}\n+\n+void mips_cpu_list(FILE *f, fprintf_function cpu_fprintf)\n+{\n+ CPUListState s = {\n+ .file = f,\n+ .cpu_fprintf = cpu_fprintf,\n+ };\n+ GSList *list;\n+\n+ list = object_class_get_list(TYPE_MIPS_CPU, false);\n+ list = g_slist_sort(list, mips_cpu_list_compare);\n+ (*cpu_fprintf)(f, \"Available CPUs:\\n\");\n+ g_slist_foreach(list, mips_cpu_list_entry, &s);\n+ g_slist_free(list);\n+}\ndiff --git a/target/mips/translate_init.c b/target/mips/translate_init.c\nindex 8bbded46c4..b75f4c9065 100644\n--- a/target/mips/translate_init.c\n+++ b/target/mips/translate_init.c\n@@ -767,16 +767,6 @@ static const mips_def_t *cpu_mips_find_by_name (const char *name)\n return NULL;\n }\n \n-void mips_cpu_list (FILE *f, fprintf_function cpu_fprintf)\n-{\n- int i;\n-\n- for (i = 0; i < ARRAY_SIZE(mips_defs); i++) {\n- (*cpu_fprintf)(f, \"MIPS '%s'\\n\",\n- mips_defs[i].name);\n- }\n-}\n-\n #ifndef CONFIG_USER_ONLY\n static void no_mmu_init (CPUMIPSState *env, const mips_def_t *def)\n {\n", "prefixes": [ "v2", "7/7" ] }