Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 807944,
    "url": "http://patchwork.ozlabs.org/api/patches/807944/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-7-saeedm@mellanox.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170830222110.15737-7-saeedm@mellanox.com>",
    "list_archive_url": null,
    "date": "2017-08-30T22:21:05",
    "name": "[net,06/11] net/mlx5e: Fix dangling page pointer on DMA mapping error",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6e911a557b9b79dac9621b040ffb27001f2816f7",
    "submitter": {
        "id": 65299,
        "url": "http://patchwork.ozlabs.org/api/people/65299/?format=api",
        "name": "Saeed Mahameed",
        "email": "saeedm@mellanox.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-7-saeedm@mellanox.com/mbox/",
    "series": [
        {
            "id": 707,
            "url": "http://patchwork.ozlabs.org/api/series/707/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=707",
            "date": "2017-08-30T22:21:00",
            "name": "[net,01/11] net/mlx5e: Check for qos capability in dcbnl_initialize",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/707/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/807944/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/807944/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjKkG3GVMz9s8w\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 08:22:14 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751456AbdH3WWM (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 30 Aug 2017 18:22:12 -0400",
            "from mail-il-dmz.mellanox.com ([193.47.165.129]:53240 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751323AbdH3WVd (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 30 Aug 2017 18:21:33 -0400",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 31 Aug 2017 01:21:29 +0300",
            "from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v7UMLSB3009018;\n\tThu, 31 Aug 2017 01:21:29 +0300"
        ],
        "From": "Saeed Mahameed <saeedm@mellanox.com>",
        "To": "\"David S. Miller\" <davem@davemloft.net>",
        "Cc": "netdev@vger.kernel.org, Eran Ben Elisha <eranbe@mellanox.com>,\n\tSaeed Mahameed <saeedm@mellanox.com>",
        "Subject": "[net 06/11] net/mlx5e: Fix dangling page pointer on DMA mapping\n\terror",
        "Date": "Thu, 31 Aug 2017 01:21:05 +0300",
        "Message-Id": "<20170830222110.15737-7-saeedm@mellanox.com>",
        "X-Mailer": "git-send-email 2.13.0",
        "In-Reply-To": "<20170830222110.15737-1-saeedm@mellanox.com>",
        "References": "<20170830222110.15737-1-saeedm@mellanox.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Eran Ben Elisha <eranbe@mellanox.com>\n\nFunction mlx5e_dealloc_rx_wqe is using page pointer value as an\nindication to valid DMA mapping. In case that the mapping failed, we\nreleased the page but kept the dangling pointer. Store the page pointer\nonly after the DMA mapping passed to avoid invalid page DMA unmap.\n\nFixes: bc77b240b3c5 (\"net/mlx5e: Add fragmented memory support for RX multi packet WQE\")\nSigned-off-by: Eran Ben Elisha <eranbe@mellanox.com>\nSigned-off-by: Saeed Mahameed <saeedm@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\nindex 325b2c8c1c6d..7344433259fc 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\n@@ -222,13 +222,13 @@ static inline int mlx5e_page_alloc_mapped(struct mlx5e_rq *rq,\n \tif (unlikely(!page))\n \t\treturn -ENOMEM;\n \n-\tdma_info->page = page;\n \tdma_info->addr = dma_map_page(rq->pdev, page, 0,\n \t\t\t\t      RQ_PAGE_SIZE(rq), rq->buff.map_dir);\n \tif (unlikely(dma_mapping_error(rq->pdev, dma_info->addr))) {\n \t\tput_page(page);\n \t\treturn -ENOMEM;\n \t}\n+\tdma_info->page = page;\n \n \treturn 0;\n }\n",
    "prefixes": [
        "net",
        "06/11"
    ]
}