Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807943/?format=api
{ "id": 807943, "url": "http://patchwork.ozlabs.org/api/patches/807943/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-10-saeedm@mellanox.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170830222110.15737-10-saeedm@mellanox.com>", "list_archive_url": null, "date": "2017-08-30T22:21:08", "name": "[net,09/11] net/mlx5: E-Switch, Unload the representors in the correct order", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0499b15bc4e40f869fa20b1be2a785970f487fb8", "submitter": { "id": 65299, "url": "http://patchwork.ozlabs.org/api/people/65299/?format=api", "name": "Saeed Mahameed", "email": "saeedm@mellanox.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170830222110.15737-10-saeedm@mellanox.com/mbox/", "series": [ { "id": 707, "url": "http://patchwork.ozlabs.org/api/series/707/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=707", "date": "2017-08-30T22:21:00", "name": "[net,01/11] net/mlx5e: Check for qos capability in dcbnl_initialize", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/707/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807943/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807943/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjKk9449Pz9s8w\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 08:22:09 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751417AbdH3WVk (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 30 Aug 2017 18:21:40 -0400", "from mail-il-dmz.mellanox.com ([193.47.165.129]:53280 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751382AbdH3WVd (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 30 Aug 2017 18:21:33 -0400", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 31 Aug 2017 01:21:29 +0300", "from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v7UMLSB6009018;\n\tThu, 31 Aug 2017 01:21:29 +0300" ], "From": "Saeed Mahameed <saeedm@mellanox.com>", "To": "\"David S. Miller\" <davem@davemloft.net>", "Cc": "netdev@vger.kernel.org, Shahar Klein <shahark@mellanox.com>,\n\tSaeed Mahameed <saeedm@mellanox.com>", "Subject": "[net 09/11] net/mlx5: E-Switch,\n\tUnload the representors in the correct order", "Date": "Thu, 31 Aug 2017 01:21:08 +0300", "Message-Id": "<20170830222110.15737-10-saeedm@mellanox.com>", "X-Mailer": "git-send-email 2.13.0", "In-Reply-To": "<20170830222110.15737-1-saeedm@mellanox.com>", "References": "<20170830222110.15737-1-saeedm@mellanox.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Shahar Klein <shahark@mellanox.com>\n\nWhen changing from switchdev to legacy mode, all the representor port\ndevices (uplink nic and reps) are cleaned up. Part of this cleaning\nprocess is removing the neigh entries and the hash table containing them.\nHowever, a representor neigh entry might be linked to the uplink port\nhash table and if the uplink nic is cleaned first the cleaning of the\nrepresentor will end up in null deref.\nFix that by unloading the representors in the opposite order of load.\n\nFixes: cb67b832921c (\"net/mlx5e: Introduce SRIOV VF representors\")\nSigned-off-by: Shahar Klein <shahark@mellanox.com>\nReviewed-by: Roi Dayan <roid@mellanox.com>\nSigned-off-by: Saeed Mahameed <saeedm@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c\nindex 95b64025ce36..5bc0593bd76e 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c\n@@ -815,7 +815,7 @@ void esw_offloads_cleanup(struct mlx5_eswitch *esw, int nvports)\n \tstruct mlx5_eswitch_rep *rep;\n \tint vport;\n \n-\tfor (vport = 0; vport < nvports; vport++) {\n+\tfor (vport = nvports - 1; vport >= 0; vport--) {\n \t\trep = &esw->offloads.vport_reps[vport];\n \t\tif (!rep->valid)\n \t\t\tcontinue;\n", "prefixes": [ "net", "09/11" ] }