Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807879/?format=api
{ "id": 807879, "url": "http://patchwork.ozlabs.org/api/patches/807879/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170830194617.26621-4-clg@kaod.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20170830194617.26621-4-clg@kaod.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20170830194617.26621-4-clg@kaod.org/", "date": "2017-08-30T19:46:12", "name": "[v3,3/8] powerpc/xive: rename xive_poke_esb() in xive_esb_read()", "commit_ref": "59fc2724e45dfea849336108c602e93ea880a18f", "pull_url": null, "state": "accepted", "archived": false, "hash": "677faac1313ab9af5ad0e8e396f9d65fa2f1b59d", "submitter": { "id": 68548, "url": "http://patchwork.ozlabs.org/api/people/68548/?format=api", "name": "Cédric Le Goater", "email": "clg@kaod.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170830194617.26621-4-clg@kaod.org/mbox/", "series": [ { "id": 695, "url": "http://patchwork.ozlabs.org/api/series/695/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=695", "date": "2017-08-30T19:46:17", "name": "guest exploitation of the XIVE interrupt controller", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/695/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807879/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807879/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjGY66JWyz9sN7\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 05:59:06 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjGY65Gs8zDqZx\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 05:59:06 +1000 (AEST)", "from 10.mo68.mail-out.ovh.net (10.mo68.mail-out.ovh.net\n\t[46.105.79.203])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjGTp32S1zDqNY\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu, 31 Aug 2017 05:56:14 +1000 (AEST)", "from player776.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo68.mail-out.ovh.net (Postfix) with ESMTP id 1D8AE76430\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 30 Aug 2017 21:46:52 +0200 (CEST)", "from zorba.kaod.org.com (LFbn-1-2231-173.w90-76.abo.wanadoo.fr\n\t[90.76.52.173]) (Authenticated sender: clg@kaod.org)\n\tby player776.ha.ovh.net (Postfix) with ESMTPSA id E58AE400077;\n\tWed, 30 Aug 2017 21:46:45 +0200 (CEST)" ], "X-Greylist": "delayed 559 seconds by postgrey-1.36 at bilbo;\n\tThu, 31 Aug 2017 05:56:14 AEST", "From": "=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>", "To": "linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH v3 3/8] powerpc/xive: rename xive_poke_esb() in\n\txive_esb_read()", "Date": "Wed, 30 Aug 2017 21:46:12 +0200", "Message-Id": "<20170830194617.26621-4-clg@kaod.org>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170830194617.26621-1-clg@kaod.org>", "References": "<20170830194617.26621-1-clg@kaod.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Ovh-Tracer-Id": "1597651968029920189", "X-VR-SPAMSTATE": "OK", "X-VR-SPAMSCORE": "-100", "X-VR-SPAMCAUSE": "gggruggvucftvghtrhhoucdtuddrfeelledrudeigddugedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "David Gibson <david@gibson.dropbear.id.au>, Paul Mackerras\n\t<paulus@samba.org>, =?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "xive_poke_esb() is performing a load/read so it is better named as\nxive_esb_read() as we will need to introduce a xive_esb_write()\nroutine. Also use the XIVE_ESB_LOAD_EOI offset when EOI'ing LSI\ninterrupts.\n\nSigned-off-by: Cédric Le Goater <clg@kaod.org>\nReviewed-by: David Gibson <david@gibson.dropbear.id.au>\n---\n\n Changes since v1:\n\n - fixed naming.\n\n arch/powerpc/sysdev/xive/common.c | 20 ++++++++++----------\n 1 file changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c\nindex 8774af7a4105..8a58662ed793 100644\n--- a/arch/powerpc/sysdev/xive/common.c\n+++ b/arch/powerpc/sysdev/xive/common.c\n@@ -190,7 +190,7 @@ static u32 xive_scan_interrupts(struct xive_cpu *xc, bool just_peek)\n * This is used to perform the magic loads from an ESB\n * described in xive.h\n */\n-static u8 xive_poke_esb(struct xive_irq_data *xd, u32 offset)\n+static u8 xive_esb_read(struct xive_irq_data *xd, u32 offset)\n {\n \tu64 val;\n \n@@ -227,7 +227,7 @@ void xmon_xive_do_dump(int cpu)\n \txive_dump_eq(\"IRQ\", &xc->queue[xive_irq_priority]);\n #ifdef CONFIG_SMP\n \t{\n-\t\tu64 val = xive_poke_esb(&xc->ipi_data, XIVE_ESB_GET);\n+\t\tu64 val = xive_esb_read(&xc->ipi_data, XIVE_ESB_GET);\n \t\txmon_printf(\" IPI state: %x:%c%c\\n\", xc->hw_ipi,\n \t\t\tval & XIVE_ESB_VAL_P ? 'P' : 'p',\n \t\t\tval & XIVE_ESB_VAL_P ? 'Q' : 'q');\n@@ -326,9 +326,9 @@ void xive_do_source_eoi(u32 hw_irq, struct xive_irq_data *xd)\n \t\t * properly.\n \t\t */\n \t\tif (xd->flags & XIVE_IRQ_FLAG_LSI)\n-\t\t\tin_be64(xd->eoi_mmio);\n+\t\t\txive_esb_read(xd, XIVE_ESB_LOAD_EOI);\n \t\telse {\n-\t\t\teoi_val = xive_poke_esb(xd, XIVE_ESB_SET_PQ_00);\n+\t\t\teoi_val = xive_esb_read(xd, XIVE_ESB_SET_PQ_00);\n \t\t\tDBG_VERBOSE(\"eoi_val=%x\\n\", offset, eoi_val);\n \n \t\t\t/* Re-trigger if needed */\n@@ -383,12 +383,12 @@ static void xive_do_source_set_mask(struct xive_irq_data *xd,\n \t * ESB accordingly on unmask.\n \t */\n \tif (mask) {\n-\t\tval = xive_poke_esb(xd, XIVE_ESB_SET_PQ_01);\n+\t\tval = xive_esb_read(xd, XIVE_ESB_SET_PQ_01);\n \t\txd->saved_p = !!(val & XIVE_ESB_VAL_P);\n \t} else if (xd->saved_p)\n-\t\txive_poke_esb(xd, XIVE_ESB_SET_PQ_10);\n+\t\txive_esb_read(xd, XIVE_ESB_SET_PQ_10);\n \telse\n-\t\txive_poke_esb(xd, XIVE_ESB_SET_PQ_00);\n+\t\txive_esb_read(xd, XIVE_ESB_SET_PQ_00);\n }\n \n /*\n@@ -768,7 +768,7 @@ static int xive_irq_retrigger(struct irq_data *d)\n \t * To perform a retrigger, we first set the PQ bits to\n \t * 11, then perform an EOI.\n \t */\n-\txive_poke_esb(xd, XIVE_ESB_SET_PQ_11);\n+\txive_esb_read(xd, XIVE_ESB_SET_PQ_11);\n \n \t/*\n \t * Note: We pass \"0\" to the hw_irq argument in order to\n@@ -803,7 +803,7 @@ static int xive_irq_set_vcpu_affinity(struct irq_data *d, void *state)\n \t\tirqd_set_forwarded_to_vcpu(d);\n \n \t\t/* Set it to PQ=10 state to prevent further sends */\n-\t\tpq = xive_poke_esb(xd, XIVE_ESB_SET_PQ_10);\n+\t\tpq = xive_esb_read(xd, XIVE_ESB_SET_PQ_10);\n \n \t\t/* No target ? nothing to do */\n \t\tif (xd->target == XIVE_INVALID_TARGET) {\n@@ -832,7 +832,7 @@ static int xive_irq_set_vcpu_affinity(struct irq_data *d, void *state)\n \t\t * for sure the queue slot is no longer in use.\n \t\t */\n \t\tif (pq & 2) {\n-\t\t\tpq = xive_poke_esb(xd, XIVE_ESB_SET_PQ_11);\n+\t\t\tpq = xive_esb_read(xd, XIVE_ESB_SET_PQ_11);\n \t\t\txd->saved_p = true;\n \n \t\t\t/*\n", "prefixes": [ "v3", "3/8" ] }