Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807837/?format=api
{ "id": 807837, "url": "http://patchwork.ozlabs.org/api/patches/807837/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830180711.7974-6-eblake@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170830180711.7974-6-eblake@redhat.com>", "list_archive_url": null, "date": "2017-08-30T18:07:05", "name": "[PULL,05/11] nbd/client: fix nbd_opt_go", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f66c7ec2c437467c4c3df161cc3159f20cc72d82", "submitter": { "id": 6591, "url": "http://patchwork.ozlabs.org/api/people/6591/?format=api", "name": "Eric Blake", "email": "eblake@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830180711.7974-6-eblake@redhat.com/mbox/", "series": [ { "id": 679, "url": "http://patchwork.ozlabs.org/api/series/679/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=679", "date": "2017-08-30T18:07:00", "name": "[PULL,01/11] qemu-iotests: Extend non-shared storage migration test (194)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/679/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807837/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807837/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjD5Z31ZXz9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 04:08:34 +1000 (AEST)", "from localhost ([::1]:52042 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn7Pk-0002CS-3v\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 14:08:32 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:53129)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dn7Ol-0001wE-Ol\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:07:32 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dn7Ok-0001cO-R0\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 14:07:31 -0400", "from mx1.redhat.com ([209.132.183.28]:56400)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>)\n\tid 1dn7Of-0001a4-9Z; Wed, 30 Aug 2017 14:07:25 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 51B6B5F7B4;\n\tWed, 30 Aug 2017 18:07:24 +0000 (UTC)", "from red.redhat.com (ovpn-122-186.rdu2.redhat.com [10.10.122.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9865017106;\n\tWed, 30 Aug 2017 18:07:23 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 51B6B5F7B4", "From": "Eric Blake <eblake@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 30 Aug 2017 13:07:05 -0500", "Message-Id": "<20170830180711.7974-6-eblake@redhat.com>", "In-Reply-To": "<20170830180711.7974-1-eblake@redhat.com>", "References": "<20170830180711.7974-1-eblake@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 30 Aug 2017 18:07:24 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 05/11] nbd/client: fix nbd_opt_go", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Paolo Bonzini <pbonzini@redhat.com>,\n\tVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,\n\t\"open list:Network Block Dev...\" <qemu-block@nongnu.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>\n\nDo not send NBD_OPT_ABORT to the broken server. After sending\nNBD_REP_ACK on NBD_OPT_GO server is most probably in transmission\nphase, when option sending is finished.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>\nMessage-Id: <20170804151440.320927-2-vsementsov@virtuozzo.com>\nSigned-off-by: Eric Blake <eblake@redhat.com>\n---\n nbd/client.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/nbd/client.c b/nbd/client.c\nindex 0a17de80b5..f1c16b588f 100644\n--- a/nbd/client.c\n+++ b/nbd/client.c\n@@ -399,12 +399,10 @@ static int nbd_opt_go(QIOChannel *ioc, const char *wantname,\n phase, but make sure it sent flags */\n if (len) {\n error_setg(errp, \"server sent invalid NBD_REP_ACK\");\n- nbd_send_opt_abort(ioc);\n return -1;\n }\n if (!info->flags) {\n error_setg(errp, \"broken server omitted NBD_INFO_EXPORT\");\n- nbd_send_opt_abort(ioc);\n return -1;\n }\n trace_nbd_opt_go_success();\n", "prefixes": [ "PULL", "05/11" ] }