Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807829/?format=api
{ "id": 807829, "url": "http://patchwork.ozlabs.org/api/patches/807829/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830170601.15855-12-david@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170830170601.15855-12-david@redhat.com>", "list_archive_url": null, "date": "2017-08-30T17:06:01", "name": "[v1,11/11] target/s390x: use program_interrupt() in per_check_exception()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e8e9888fb5467f01d771fa987add2f060c0b06a4", "submitter": { "id": 70402, "url": "http://patchwork.ozlabs.org/api/people/70402/?format=api", "name": "David Hildenbrand", "email": "david@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830170601.15855-12-david@redhat.com/mbox/", "series": [ { "id": 666, "url": "http://patchwork.ozlabs.org/api/series/666/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=666", "date": "2017-08-30T17:06:00", "name": "next round of s390x cleanups", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/666/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807829/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807829/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjCqZ2hKqz9s8w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 03:56:26 +1000 (AEST)", "from localhost ([::1]:51957 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn7Dz-00016m-Nk\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:56:23 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:33595)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dn6SA-000657-0Q\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 13:06:58 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dn6S6-0002cD-Mi\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 13:06:57 -0400", "from mx1.redhat.com ([209.132.183.28]:17738)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dn6S6-0002bb-GZ\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 13:06:54 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 880396F0;\n\tWed, 30 Aug 2017 17:06:53 +0000 (UTC)", "from t460s.redhat.com (ovpn-116-98.ams2.redhat.com [10.36.116.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 68EC580E72;\n\tWed, 30 Aug 2017 17:06:51 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 880396F0", "From": "David Hildenbrand <david@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 30 Aug 2017 19:06:01 +0200", "Message-Id": "<20170830170601.15855-12-david@redhat.com>", "In-Reply-To": "<20170830170601.15855-1-david@redhat.com>", "References": "<20170830170601.15855-1-david@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 30 Aug 2017 17:06:53 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v1 11/11] target/s390x: use program_interrupt()\n\tin per_check_exception()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "thuth@redhat.com, david@redhat.com, cohuck@redhat.com,\n\tRichard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>, borntraeger@de.ibm.com,\n\tAurelien Jarno <aurelien@aurel32.net>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "I am not sure if we are handling ilen the right way here. ilen should\nalways match the instruction triggering the exception. This is relevant\nfor per exceptions triggered via EXECUTE instructions. The ilen to be\nindicated has to match the EXECUTE instruction.\n\nClean it up for now but leave ilen as is, we can fix that later.\n\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n target/s390x/misc_helper.c | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)", "diff": "diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c\nindex eb7accc0ce..ac9657f23f 100644\n--- a/target/s390x/misc_helper.c\n+++ b/target/s390x/misc_helper.c\n@@ -445,14 +445,11 @@ void HELPER(chsc)(CPUS390XState *env, uint64_t inst)\n #ifndef CONFIG_USER_ONLY\n void HELPER(per_check_exception)(CPUS390XState *env)\n {\n- CPUState *cs = CPU(s390_env_get_cpu(env));\n+ uint32_t ilen;\n \n if (env->per_perc_atmid) {\n- env->int_pgm_code = PGM_PER;\n- env->int_pgm_ilen = get_ilen(cpu_ldub_code(env, env->per_address));\n-\n- cs->exception_index = EXCP_PGM;\n- cpu_loop_exit(cs);\n+ ilen = get_ilen(cpu_ldub_code(env, env->per_address));\n+ program_interrupt(env, PGM_PER, ilen);\n }\n }\n \n", "prefixes": [ "v1", "11/11" ] }