Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807758/?format=api
{ "id": 807758, "url": "http://patchwork.ozlabs.org/api/patches/807758/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-27-cohuck@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170830165252.13421-27-cohuck@redhat.com>", "list_archive_url": null, "date": "2017-08-30T16:52:34", "name": "[PULL,26/44] target/s390x: simplify gs_allowed()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3cfe59837039779ef202d7b724fafcbaada55681", "submitter": { "id": 71914, "url": "http://patchwork.ozlabs.org/api/people/71914/?format=api", "name": "Cornelia Huck", "email": "cohuck@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-27-cohuck@redhat.com/mbox/", "series": [ { "id": 656, "url": "http://patchwork.ozlabs.org/api/series/656/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656", "date": "2017-08-30T16:52:08", "name": "[PULL,01/44] s390x/css: use macro for event-information pending error recover code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/656/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807758/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807758/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjBts03Hzz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 03:14:13 +1000 (AEST)", "from localhost ([::1]:51707 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn6Z8-0003HW-LE\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:14:10 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:57396)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dn6GZ-0002y5-Dw\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:55:00 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dn6GV-0005cL-IJ\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:54:59 -0400", "from mx1.redhat.com ([209.132.183.28]:38724)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dn6GV-0005bp-BL\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:54:55 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 357015F798;\n\tWed, 30 Aug 2017 16:54:54 +0000 (UTC)", "from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 671C88F341;\n\tWed, 30 Aug 2017 16:54:53 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 357015F798", "From": "Cornelia Huck <cohuck@redhat.com>", "To": "peter.maydell@linaro.org", "Date": "Wed, 30 Aug 2017 18:52:34 +0200", "Message-Id": "<20170830165252.13421-27-cohuck@redhat.com>", "In-Reply-To": "<20170830165252.13421-1-cohuck@redhat.com>", "References": "<20170830165252.13421-1-cohuck@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 30 Aug 2017 16:54:54 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 26/44] target/s390x: simplify gs_allowed()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "thuth@redhat.com, david@redhat.com, Cornelia Huck <cohuck@redhat.com>,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\trth@twiddle.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: David Hildenbrand <david@redhat.com>\n\nNo need for kvm_enabled() as this function is only called from KVM and\nthere is no reason why it shouldn't be allowed for tcg. It is simply not\navailable under tcg.\n\nAlso, there is no need to check for the machine type anymore. Just like\nri_enabled(), we can directly use the stored flag, which results in\n\"true\" for the \"none\" machine.\n\nSigned-off-by: David Hildenbrand <david@redhat.com>\nMessage-Id: <20170818114353.13455-5-david@redhat.com>\nReviewed-by: Thomas Huth <thuth@redhat.com>\nSigned-off-by: Cornelia Huck <cohuck@redhat.com>\n---\n hw/s390x/s390-virtio-ccw.c | 14 ++------------\n 1 file changed, 2 insertions(+), 12 deletions(-)", "diff": "diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\nindex cdf7fa042b..3a718953a2 100644\n--- a/hw/s390x/s390-virtio-ccw.c\n+++ b/hw/s390x/s390-virtio-ccw.c\n@@ -290,18 +290,8 @@ bool cpu_model_allowed(void)\n \n bool gs_allowed(void)\n {\n- if (kvm_enabled()) {\n- MachineClass *mc = MACHINE_GET_CLASS(qdev_get_machine());\n- if (object_class_dynamic_cast(OBJECT_CLASS(mc),\n- TYPE_S390_CCW_MACHINE)) {\n- S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);\n-\n- return s390mc->gs_allowed;\n- }\n- /* Make sure the \"none\" machine can have gs */\n- return true;\n- }\n- return false;\n+ /* for \"none\" machine this results in true */\n+ return get_machine_class()->gs_allowed;\n }\n \n static char *machine_get_loadparm(Object *obj, Error **errp)\n", "prefixes": [ "PULL", "26/44" ] }