Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807733/?format=api
{ "id": 807733, "url": "http://patchwork.ozlabs.org/api/patches/807733/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-3-cohuck@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170830165252.13421-3-cohuck@redhat.com>", "list_archive_url": null, "date": "2017-08-30T16:52:10", "name": "[PULL,02/44] s390x/css: generate solicited crw for rchp completion signaling", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bbd7ca8ba9cebccf92030179dd611e229dbabaa1", "submitter": { "id": 71914, "url": "http://patchwork.ozlabs.org/api/people/71914/?format=api", "name": "Cornelia Huck", "email": "cohuck@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170830165252.13421-3-cohuck@redhat.com/mbox/", "series": [ { "id": 656, "url": "http://patchwork.ozlabs.org/api/series/656/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=656", "date": "2017-08-30T16:52:08", "name": "[PULL,01/44] s390x/css: use macro for event-information pending error recover code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/656/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807733/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807733/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjBcX5RtZz9sNn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 03:01:48 +1000 (AEST)", "from localhost ([::1]:51659 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dn6N8-0000lY-E7\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 13:01:46 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:56302)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dn6Ep-0001JT-3Q\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:12 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dn6En-0004wD-3B\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:11 -0400", "from mx1.redhat.com ([209.132.183.28]:43282)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dn6Em-0004vu-QV\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 12:53:09 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B1107C04B924;\n\tWed, 30 Aug 2017 16:53:07 +0000 (UTC)", "from localhost (ovpn-116-210.ams2.redhat.com [10.36.116.210])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3815A8D573;\n\tWed, 30 Aug 2017 16:53:05 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com B1107C04B924", "From": "Cornelia Huck <cohuck@redhat.com>", "To": "peter.maydell@linaro.org", "Date": "Wed, 30 Aug 2017 18:52:10 +0200", "Message-Id": "<20170830165252.13421-3-cohuck@redhat.com>", "In-Reply-To": "<20170830165252.13421-1-cohuck@redhat.com>", "References": "<20170830165252.13421-1-cohuck@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 30 Aug 2017 16:53:07 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 02/44] s390x/css: generate solicited crw for\n\trchp completion signaling", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "thuth@redhat.com, david@redhat.com, Cornelia Huck <cohuck@redhat.com>,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\tDong Jia Shi <bjsdjshi@linux.vnet.ibm.com>, rth@twiddle.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>\n\nA successful completion of rchp should signal a solicited channel path\ninitialized CRW (channel report word), while the current implementation\nalways generates an un-solicited one. Let's fix this.\n\nReported-by: Halil Pasic <pasic@linux.vnet.ibm.com>\nSigned-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>\nReviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>\nMessage-Id: <20170803003527.86979-3-bjsdjshi@linux.vnet.ibm.com>\nSigned-off-by: Cornelia Huck <cohuck@redhat.com>\n---\n hw/s390x/css.c | 16 ++++++++++------\n include/hw/s390x/css.h | 3 ++-\n 2 files changed, 12 insertions(+), 7 deletions(-)", "diff": "diff --git a/hw/s390x/css.c b/hw/s390x/css.c\nindex 0be4eb093d..901dc6a0f3 100644\n--- a/hw/s390x/css.c\n+++ b/hw/s390x/css.c\n@@ -1750,10 +1750,10 @@ int css_do_rchp(uint8_t cssid, uint8_t chpid)\n }\n \n /* We don't really use a channel path, so we're done here. */\n- css_queue_crw(CRW_RSC_CHP, CRW_ERC_INIT,\n+ css_queue_crw(CRW_RSC_CHP, CRW_ERC_INIT, 1,\n channel_subsys.max_cssid > 0 ? 1 : 0, chpid);\n if (channel_subsys.max_cssid > 0) {\n- css_queue_crw(CRW_RSC_CHP, CRW_ERC_INIT, 0, real_cssid << 8);\n+ css_queue_crw(CRW_RSC_CHP, CRW_ERC_INIT, 1, 0, real_cssid << 8);\n }\n return 0;\n }\n@@ -2033,7 +2033,8 @@ void css_subch_assign(uint8_t cssid, uint8_t ssid, uint16_t schid,\n }\n }\n \n-void css_queue_crw(uint8_t rsc, uint8_t erc, int chain, uint16_t rsid)\n+void css_queue_crw(uint8_t rsc, uint8_t erc, int solicited,\n+ int chain, uint16_t rsid)\n {\n CrwContainer *crw_cont;\n \n@@ -2045,6 +2046,9 @@ void css_queue_crw(uint8_t rsc, uint8_t erc, int chain, uint16_t rsid)\n return;\n }\n crw_cont->crw.flags = (rsc << 8) | erc;\n+ if (solicited) {\n+ crw_cont->crw.flags |= CRW_FLAGS_MASK_S;\n+ }\n if (chain) {\n crw_cont->crw.flags |= CRW_FLAGS_MASK_C;\n }\n@@ -2091,9 +2095,9 @@ void css_generate_sch_crws(uint8_t cssid, uint8_t ssid, uint16_t schid,\n }\n chain_crw = (channel_subsys.max_ssid > 0) ||\n (channel_subsys.max_cssid > 0);\n- css_queue_crw(CRW_RSC_SUBCH, CRW_ERC_IPI, chain_crw ? 1 : 0, schid);\n+ css_queue_crw(CRW_RSC_SUBCH, CRW_ERC_IPI, 0, chain_crw ? 1 : 0, schid);\n if (chain_crw) {\n- css_queue_crw(CRW_RSC_SUBCH, CRW_ERC_IPI, 0,\n+ css_queue_crw(CRW_RSC_SUBCH, CRW_ERC_IPI, 0, 0,\n (guest_cssid << 8) | (ssid << 4));\n }\n /* RW_ERC_IPI --> clear pending interrupts */\n@@ -2108,7 +2112,7 @@ void css_generate_chp_crws(uint8_t cssid, uint8_t chpid)\n void css_generate_css_crws(uint8_t cssid)\n {\n if (!channel_subsys.sei_pending) {\n- css_queue_crw(CRW_RSC_CSS, CRW_ERC_EVENT, 0, cssid);\n+ css_queue_crw(CRW_RSC_CSS, CRW_ERC_EVENT, 0, 0, cssid);\n }\n channel_subsys.sei_pending = true;\n }\ndiff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h\nindex 5c5fe6b202..5b017e1fc3 100644\n--- a/include/hw/s390x/css.h\n+++ b/include/hw/s390x/css.h\n@@ -150,7 +150,8 @@ void copy_scsw_to_guest(SCSW *dest, const SCSW *src);\n void css_inject_io_interrupt(SubchDev *sch);\n void css_reset(void);\n void css_reset_sch(SubchDev *sch);\n-void css_queue_crw(uint8_t rsc, uint8_t erc, int chain, uint16_t rsid);\n+void css_queue_crw(uint8_t rsc, uint8_t erc, int solicited,\n+ int chain, uint16_t rsid);\n void css_generate_sch_crws(uint8_t cssid, uint8_t ssid, uint16_t schid,\n int hotplugged, int add);\n void css_generate_chp_crws(uint8_t cssid, uint8_t chpid);\n", "prefixes": [ "PULL", "02/44" ] }