Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 807699,
    "url": "http://patchwork.ozlabs.org/api/patches/807699/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504110571.11498.120.camel@edumazet-glaptop3.roam.corp.google.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1504110571.11498.120.camel@edumazet-glaptop3.roam.corp.google.com>",
    "list_archive_url": null,
    "date": "2017-08-30T16:29:31",
    "name": "[net] kcm: do not attach PF_KCM sockets to avoid deadlock",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d443d022e1fd7011cf08c2892b028a05e48624b3",
    "submitter": {
        "id": 2404,
        "url": "http://patchwork.ozlabs.org/api/people/2404/?format=api",
        "name": "Eric Dumazet",
        "email": "eric.dumazet@gmail.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504110571.11498.120.camel@edumazet-glaptop3.roam.corp.google.com/mbox/",
    "series": [
        {
            "id": 646,
            "url": "http://patchwork.ozlabs.org/api/series/646/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=646",
            "date": "2017-08-30T16:29:31",
            "name": "[net] kcm: do not attach PF_KCM sockets to avoid deadlock",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/646/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/807699/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/807699/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EWa9D0dN\"; dkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj9vP3TyRz9sNn\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 31 Aug 2017 02:29:37 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751877AbdH3Q3f (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 30 Aug 2017 12:29:35 -0400",
            "from mail-pf0-f193.google.com ([209.85.192.193]:35059 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751416AbdH3Q3e (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 30 Aug 2017 12:29:34 -0400",
            "by mail-pf0-f193.google.com with SMTP id g13so4622435pfm.2\n\tfor <netdev@vger.kernel.org>; Wed, 30 Aug 2017 09:29:34 -0700 (PDT)",
            "from ?IPv6:2620:15c:2c1:100:dc1f:953d:4193:6c45?\n\t([2620:15c:2c1:100:dc1f:953d:4193:6c45])\n\tby smtp.googlemail.com with ESMTPSA id\n\tq66sm9710388pfb.132.2017.08.30.09.29.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 30 Aug 2017 09:29:32 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:mime-version\n\t:content-transfer-encoding;\n\tbh=KWSObgh4UFR0v0MlZVL+hGXpgziTJQsvg8kSh3k+mSk=;\n\tb=EWa9D0dNTxqalwzxJnwUd9AGPTm5kwuxiZovdLwunplsH1+blo7w+UtVapyEsNvOuF\n\tTeJ7kBlzIem3l1Xju6j2zUVrKs0dSkq5CqKKCsJuJ7POqOn3+Xs02UlJ+fOBNU/Glf1B\n\tjA4eVWpvfiX2BHxnlBKopnB1CwO/WsVi+04tOxjP1V8UcotRDl6IyO/gJVr47mtHbhrq\n\tEEdkY8b3BvHAOAX9Ms7iXRdba6qjiO0b6ISkb2Am5PCuidxtFEKKuyA6DxpBN+uxNM+2\n\t8ZtSGZXHEnPRl8DFsZGmKX4nhrAC9HcgoTe3f0ivAw/KXrjUs1MGKNLhzlQsiO0WivZ8\n\tmaaQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version\n\t:content-transfer-encoding;\n\tbh=KWSObgh4UFR0v0MlZVL+hGXpgziTJQsvg8kSh3k+mSk=;\n\tb=FEWYZWxE/xFDCzVTqKwvnFsGC03L7x6rK8z2CVnZ9m1HRhZpekyn7vnUyBi8R2vOjO\n\tKdsVp0eYb9quTjKOGdimdYdqmsHLa2Avebx255TgWATjigHn9cWg9S8OZkTFn8ygTle7\n\tj0F495iu+lw7yynJsW4gD3z9+Fh9BqY5d5j8ah9VqTf+6ZbJddOftfwL1lGHjeMrLY5l\n\tW/Tg43VzhOUurunkhAvM7MfF+V6iFhFJdcStKzbQjs779WoKEVUOn67+APBOs64uvGyE\n\t/cSfQvJKKtMMHu4ud/t0ViWLr2KESS+W6Nb+AQYrVbY4GJlQYpZ5PMrHW+P3ETrgFVaU\n\tdFJQ==",
        "X-Gm-Message-State": "AHYfb5iHLj8gVbovEY/Qez1GdkdWl3vd1zNVy7HYHDzsRxZMExx7zRL0\n\t8s1Uvk4wi0RNW86b",
        "X-Received": "by 10.84.236.2 with SMTP id q2mr2694253plk.317.1504110573591;\n\tWed, 30 Aug 2017 09:29:33 -0700 (PDT)",
        "Message-ID": "<1504110571.11498.120.camel@edumazet-glaptop3.roam.corp.google.com>",
        "Subject": "[PATCH net] kcm: do not attach PF_KCM sockets to avoid deadlock",
        "From": "Eric Dumazet <eric.dumazet@gmail.com>",
        "To": "David Miller <davem@davemloft.net>",
        "Cc": "netdev <netdev@vger.kernel.org>, Tom Herbert <tom@quantonium.net>",
        "Date": "Wed, 30 Aug 2017 09:29:31 -0700",
        "Content-Type": "text/plain; charset=\"UTF-8\"",
        "X-Mailer": "Evolution 3.10.4-0ubuntu2 ",
        "Mime-Version": "1.0",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Eric Dumazet <edumazet@google.com>\n\nsyzkaller had no problem to trigger a deadlock, attaching a KCM socket\nto another one (or itself). (original syzkaller report was a very\nconfusing lockdep splat during a sendmsg())\n\nIt seems KCM claims to only support TCP, but no enforcement is done,\nso we might need to add additional checks.\n\nFixes: ab7ac4eb9832 (\"kcm: Kernel Connection Multiplexor module\")\nSigned-off-by: Eric Dumazet <edumazet@google.com>\nReported-by: Dmitry Vyukov <dvyukov@google.com>\n---\n net/kcm/kcmsock.c |    4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c\nindex 48e993b2dbcf1afae04968ed840e2e98c2cf6772..af4e76ac88ff0817398d1d7460a41f0cd5fe6f30 100644\n--- a/net/kcm/kcmsock.c\n+++ b/net/kcm/kcmsock.c\n@@ -1387,6 +1387,10 @@ static int kcm_attach(struct socket *sock, struct socket *csock,\n \tif (!csk)\n \t\treturn -EINVAL;\n \n+\t/* We must prevent loops or risk deadlock ! */\n+\tif (csk->sk_family == PF_KCM)\n+\t\treturn -EOPNOTSUPP;\n+\n \tpsock = kmem_cache_zalloc(kcm_psockp, GFP_KERNEL);\n \tif (!psock)\n \t\treturn -ENOMEM;\n",
    "prefixes": [
        "net"
    ]
}