Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 807543,
    "url": "http://patchwork.ozlabs.org/api/patches/807543/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504086545-7777-8-git-send-email-nikolay@cumulusnetworks.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1504086545-7777-8-git-send-email-nikolay@cumulusnetworks.com>",
    "list_archive_url": null,
    "date": "2017-08-30T09:49:03",
    "name": "[net,7/9] sch_netem: avoid null pointer deref on init failure",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "115f0828fc136622cdc0e722b8b71a89daf835e9",
    "submitter": {
        "id": 66448,
        "url": "http://patchwork.ozlabs.org/api/people/66448/?format=api",
        "name": "Nikolay Aleksandrov",
        "email": "nikolay@cumulusnetworks.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504086545-7777-8-git-send-email-nikolay@cumulusnetworks.com/mbox/",
    "series": [
        {
            "id": 565,
            "url": "http://patchwork.ozlabs.org/api/series/565/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=565",
            "date": "2017-08-30T09:48:56",
            "name": "net/sched: init failure fixes",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/565/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/807543/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/807543/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"VeHA9oHI\"; \n\tdkim-atps=neutral"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xj1233P2vz9sNn\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 19:49:47 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751956AbdH3Jtp (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 30 Aug 2017 05:49:45 -0400",
            "from mail-wr0-f180.google.com ([209.85.128.180]:34888 \"EHLO\n\tmail-wr0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751319AbdH3Jtb (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 30 Aug 2017 05:49:31 -0400",
            "by mail-wr0-f180.google.com with SMTP id j29so16032099wre.2\n\tfor <netdev@vger.kernel.org>; Wed, 30 Aug 2017 02:49:30 -0700 (PDT)",
            "from debil.mediahub-bg.com (46-10-142-144.ip.btc-net.bg.\n\t[46.10.142.144]) by smtp.gmail.com with ESMTPSA id\n\to206sm1113294wmo.10.2017.08.30.02.49.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 30 Aug 2017 02:49:28 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=SEY7mujnVsGTXdMoxBrqwc6T8cgbW6SgmE71FvraVRI=;\n\tb=VeHA9oHIO0496fx8kDirU4VaRmRVWapUHeYi2lqT55px+4d3I01IT1N3YTz9o5ODZh\n\tzs9HumXAKr8NARaqQ+GzoYf1wa7LLA8Do+9mp0WJflXxqxpDw0x0SRZ/opLShvb1YwFh\n\tUzRgUHqqNSyuuW47N57Zc21Rk4h11VK1LzKaY=",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=SEY7mujnVsGTXdMoxBrqwc6T8cgbW6SgmE71FvraVRI=;\n\tb=nSYQQlAM08rYYFo/F6L+NtG6yaNksUGFnoLuLzeeXSdErtbJmoYNfWZ0YTw1dLNb7X\n\t0Ut5L5Ch72aLuSea9tTc6LhT1kvGh7uMb4uFh1r44601DDUfRkYVW+SbcvqogMVdMCeL\n\tWxRid7suI8it5zO+mZPkTKexMv6nlApj5Pu6i0WgVH5YX7fshnBzwJZA1c7jXFtniEJE\n\tQwJd87BWIKVVHM39J93oReQaoKBt8j0DfHM/gonBv4SZJOhDxbtzZ78ZVwBb1pTGujTe\n\tv44KbB5jw0EK5RI2Lr+gkqihLKggSLO0Dk/h0JW0fiZ+9KmUzKLSX0HlFVwIB0E1Qacl\n\tWAMQ==",
        "X-Gm-Message-State": "AHYfb5grOwb90dthybzxt/EXfBuDn3ZreM0euWkt/T7G3tVchwRSobVj\n\tI9mIv9iTDtPlQLZWoiw=",
        "X-Received": "by 10.223.161.143 with SMTP id u15mr654426wru.278.1504086569253; \n\tWed, 30 Aug 2017 02:49:29 -0700 (PDT)",
        "From": "Nikolay Aleksandrov <nikolay@cumulusnetworks.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "edumazet@google.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com,\n\tjiri@resnulli.us, roopa@cumulusnetworks.com,\n\tNikolay Aleksandrov <nikolay@cumulusnetworks.com>",
        "Subject": "[PATCH net 7/9] sch_netem: avoid null pointer deref on init failure",
        "Date": "Wed, 30 Aug 2017 12:49:03 +0300",
        "Message-Id": "<1504086545-7777-8-git-send-email-nikolay@cumulusnetworks.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<1504086545-7777-1-git-send-email-nikolay@cumulusnetworks.com>",
        "References": "<1504086545-7777-1-git-send-email-nikolay@cumulusnetworks.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "netem can fail in ->init due to missing options (either not supplied by\nuser-space or used as a default qdisc) causing a timer->base null\npointer deref in its ->destroy() and ->reset() callbacks.\n\nReproduce:\n$ sysctl net.core.default_qdisc=netem\n$ ip l set ethX up\n\nCrash log:\n[ 1814.846943] BUG: unable to handle kernel NULL pointer dereference at (null)\n[ 1814.847181] IP: hrtimer_active+0x17/0x8a\n[ 1814.847270] PGD 59c34067\n[ 1814.847271] P4D 59c34067\n[ 1814.847337] PUD 37374067\n[ 1814.847403] PMD 0\n[ 1814.847468]\n[ 1814.847582] Oops: 0000 [#1] SMP\n[ 1814.847655] Modules linked in: sch_netem(O) sch_fq_codel(O)\n[ 1814.847761] CPU: 3 PID: 1573 Comm: ip Tainted: G           O 4.13.0-rc6+ #62\n[ 1814.847884] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014\n[ 1814.848043] task: ffff88003723a700 task.stack: ffff88005adc8000\n[ 1814.848235] RIP: 0010:hrtimer_active+0x17/0x8a\n[ 1814.848407] RSP: 0018:ffff88005adcb590 EFLAGS: 00010246\n[ 1814.848590] RAX: 0000000000000000 RBX: ffff880058e359d8 RCX: 0000000000000000\n[ 1814.848793] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff880058e359d8\n[ 1814.848998] RBP: ffff88005adcb5b0 R08: 00000000014080c0 R09: 00000000ffffffff\n[ 1814.849204] R10: ffff88005adcb660 R11: 0000000000000020 R12: 0000000000000000\n[ 1814.849410] R13: ffff880058e359d8 R14: 00000000ffffffff R15: 0000000000000001\n[ 1814.849616] FS:  00007f733bbca740(0000) GS:ffff88005d980000(0000) knlGS:0000000000000000\n[ 1814.849919] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n[ 1814.850107] CR2: 0000000000000000 CR3: 0000000059f0d000 CR4: 00000000000406e0\n[ 1814.850313] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000\n[ 1814.850518] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400\n[ 1814.850723] Call Trace:\n[ 1814.850875]  hrtimer_try_to_cancel+0x1a/0x93\n[ 1814.851047]  hrtimer_cancel+0x15/0x20\n[ 1814.851211]  qdisc_watchdog_cancel+0x12/0x14\n[ 1814.851383]  netem_reset+0xe6/0xed [sch_netem]\n[ 1814.851561]  qdisc_destroy+0x8b/0xe5\n[ 1814.851723]  qdisc_create_dflt+0x86/0x94\n[ 1814.851890]  ? dev_activate+0x129/0x129\n[ 1814.852057]  attach_one_default_qdisc+0x36/0x63\n[ 1814.852232]  netdev_for_each_tx_queue+0x3d/0x48\n[ 1814.852406]  dev_activate+0x4b/0x129\n[ 1814.852569]  __dev_open+0xe7/0x104\n[ 1814.852730]  __dev_change_flags+0xc6/0x15c\n[ 1814.852899]  dev_change_flags+0x25/0x59\n[ 1814.853064]  do_setlink+0x30c/0xb3f\n[ 1814.853228]  ? check_chain_key+0xb0/0xfd\n[ 1814.853396]  ? check_chain_key+0xb0/0xfd\n[ 1814.853565]  rtnl_newlink+0x3a4/0x729\n[ 1814.853728]  ? rtnl_newlink+0x117/0x729\n[ 1814.853905]  ? ns_capable_common+0xd/0xb1\n[ 1814.854072]  ? ns_capable+0x13/0x15\n[ 1814.854234]  rtnetlink_rcv_msg+0x188/0x197\n[ 1814.854404]  ? rcu_read_unlock+0x3e/0x5f\n[ 1814.854572]  ? rtnl_newlink+0x729/0x729\n[ 1814.854737]  netlink_rcv_skb+0x6c/0xce\n[ 1814.854902]  rtnetlink_rcv+0x23/0x2a\n[ 1814.855064]  netlink_unicast+0x103/0x181\n[ 1814.855230]  netlink_sendmsg+0x326/0x337\n[ 1814.855398]  sock_sendmsg_nosec+0x14/0x3f\n[ 1814.855584]  sock_sendmsg+0x29/0x2e\n[ 1814.855747]  ___sys_sendmsg+0x209/0x28b\n[ 1814.855912]  ? do_raw_spin_unlock+0xcd/0xf8\n[ 1814.856082]  ? _raw_spin_unlock+0x27/0x31\n[ 1814.856251]  ? __handle_mm_fault+0x651/0xdb1\n[ 1814.856421]  ? check_chain_key+0xb0/0xfd\n[ 1814.856592]  __sys_sendmsg+0x45/0x63\n[ 1814.856755]  ? __sys_sendmsg+0x45/0x63\n[ 1814.856923]  SyS_sendmsg+0x19/0x1b\n[ 1814.857083]  entry_SYSCALL_64_fastpath+0x23/0xc2\n[ 1814.857256] RIP: 0033:0x7f733b2dd690\n[ 1814.857419] RSP: 002b:00007ffe1d3387d8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e\n[ 1814.858238] RAX: ffffffffffffffda RBX: ffffffff810d278c RCX: 00007f733b2dd690\n[ 1814.858445] RDX: 0000000000000000 RSI: 00007ffe1d338820 RDI: 0000000000000003\n[ 1814.858651] RBP: ffff88005adcbf98 R08: 0000000000000001 R09: 0000000000000003\n[ 1814.858856] R10: 00007ffe1d3385a0 R11: 0000000000000246 R12: 0000000000000002\n[ 1814.859060] R13: 000000000066f1a0 R14: 00007ffe1d3408d0 R15: 0000000000000000\n[ 1814.859267]  ? trace_hardirqs_off_caller+0xa7/0xcf\n[ 1814.859446] Code: 10 55 48 89 c7 48 89 e5 e8 45 a1 fb ff 31 c0 5d c3\n31 c0 c3 66 66 66 66 90 55 48 89 e5 41 56 41 55 41 54 53 49 89 fd 49 8b\n45 30 <4c> 8b 20 41 8b 5c 24 38 31 c9 31 d2 48 c7 c7 50 8e 1d 82 41 89\n[ 1814.860022] RIP: hrtimer_active+0x17/0x8a RSP: ffff88005adcb590\n[ 1814.860214] CR2: 0000000000000000\n\nFixes: 87b60cfacf9f (\"net_sched: fix error recovery at qdisc creation\")\nFixes: 0fbbeb1ba43b (\"[PKT_SCHED]: Fix missing qdisc_destroy() in qdisc_create_dflt()\")\nSigned-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>\n---\n net/sched/sch_netem.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c\nindex 1b3dd6190e93..14d1724e0dc4 100644\n--- a/net/sched/sch_netem.c\n+++ b/net/sched/sch_netem.c\n@@ -933,11 +933,11 @@ static int netem_init(struct Qdisc *sch, struct nlattr *opt)\n \tstruct netem_sched_data *q = qdisc_priv(sch);\n \tint ret;\n \n+\tqdisc_watchdog_init(&q->watchdog, sch);\n+\n \tif (!opt)\n \t\treturn -EINVAL;\n \n-\tqdisc_watchdog_init(&q->watchdog, sch);\n-\n \tq->loss_model = CLG_RANDOM;\n \tret = netem_change(sch, opt);\n \tif (ret)\n",
    "prefixes": [
        "net",
        "7/9"
    ]
}