Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807505/?format=api
{ "id": 807505, "url": "http://patchwork.ozlabs.org/api/patches/807505/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504081950-2528-19-git-send-email-peterx@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504081950-2528-19-git-send-email-peterx@redhat.com>", "list_archive_url": null, "date": "2017-08-30T08:32:15", "name": "[RFC,v2,18/33] migration: wakeup dst ram-load-thread for recover", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d9c4f84379601204694bf0212bb7dd23deefe9de", "submitter": { "id": 67717, "url": "http://patchwork.ozlabs.org/api/people/67717/?format=api", "name": "Peter Xu", "email": "peterx@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504081950-2528-19-git-send-email-peterx@redhat.com/mbox/", "series": [ { "id": 552, "url": "http://patchwork.ozlabs.org/api/series/552/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=552", "date": "2017-08-30T08:31:59", "name": "Migration: postcopy failure recovery", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/552/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807505/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807505/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhzdk5mT2z9t2Q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 18:47:06 +1000 (AEST)", "from localhost ([::1]:49076 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmyeO-0001wK-GI\n\tfor incoming@patchwork.ozlabs.org; Wed, 30 Aug 2017 04:47:04 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:34518)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dmyRy-0007uw-7Z\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:34:16 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dmyRt-0003dZ-5H\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:34:14 -0400", "from mx1.redhat.com ([209.132.183.28]:48830)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1dmyRs-0003dE-Vd\n\tfor qemu-devel@nongnu.org; Wed, 30 Aug 2017 04:34:09 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F1D497E433;\n\tWed, 30 Aug 2017 08:34:07 +0000 (UTC)", "from pxdev.xzpeter.org.com (dhcp-14-103.nay.redhat.com\n\t[10.66.14.103])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 82B4E84792;\n\tWed, 30 Aug 2017 08:34:03 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com F1D497E433", "From": "Peter Xu <peterx@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 30 Aug 2017 16:32:15 +0800", "Message-Id": "<1504081950-2528-19-git-send-email-peterx@redhat.com>", "In-Reply-To": "<1504081950-2528-1-git-send-email-peterx@redhat.com>", "References": "<1504081950-2528-1-git-send-email-peterx@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 30 Aug 2017 08:34:08 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [RFC v2 18/33] migration: wakeup dst ram-load-thread\n\tfor recover", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Laurent Vivier <lvivier@redhat.com>,\n\tAndrea Arcangeli <aarcange@redhat.com>, \n\tJuan Quintela <quintela@redhat.com>,\n\tAlexey Perevalov <a.perevalov@samsung.com>, peterx@redhat.com,\n\t\"Dr . David Alan Gilbert\" <dgilbert@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "On the destination side, we cannot wake up all the threads when we got\nreconnected. The first thing to do is to wake up the main load thread,\nso that we can continue to receive valid messages from source again and\nreply when needed.\n\nAt this point, we switch the destination VM state from postcopy-paused\nback to postcopy-recover.\n\nNow we are finally ready to do the resume logic.\n\nReviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nSigned-off-by: Peter Xu <peterx@redhat.com>\n---\n migration/migration.c | 33 ++++++++++++++++++++++++++++++---\n 1 file changed, 30 insertions(+), 3 deletions(-)", "diff": "diff --git a/migration/migration.c b/migration/migration.c\nindex 30dd566..1370c70 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -389,10 +389,37 @@ static void process_incoming_migration_co(void *opaque)\n \n void migration_fd_process_incoming(QEMUFile *f)\n {\n- Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, f);\n+ MigrationIncomingState *mis = migration_incoming_get_current();\n+ Coroutine *co;\n+\n+ mis->from_src_file = f;\n+\n+ if (mis->state == MIGRATION_STATUS_POSTCOPY_PAUSED) {\n+ /* Resumed from a paused postcopy migration */\n+\n+ /* Postcopy has standalone thread to do vm load */\n+ qemu_file_set_blocking(f, true);\n+\n+ /* Re-configure the return path */\n+ mis->to_src_file = qemu_file_get_return_path(f);\n \n- qemu_file_set_blocking(f, false);\n- qemu_coroutine_enter(co);\n+ migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_PAUSED,\n+ MIGRATION_STATUS_POSTCOPY_RECOVER);\n+\n+ /*\n+ * Here, we only wake up the main loading thread (while the\n+ * fault thread will still be waiting), so that we can receive\n+ * commands from source now, and answer it if needed. The\n+ * fault thread will be woken up afterwards until we are sure\n+ * that source is ready to reply to page requests.\n+ */\n+ qemu_sem_post(&mis->postcopy_pause_sem_dst);\n+ } else {\n+ /* New incoming migration */\n+ qemu_file_set_blocking(f, false);\n+ co = qemu_coroutine_create(process_incoming_migration_co, f);\n+ qemu_coroutine_enter(co);\n+ }\n }\n \n /*\n", "prefixes": [ "RFC", "v2", "18/33" ] }