Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807449/?format=api
{ "id": 807449, "url": "http://patchwork.ozlabs.org/api/patches/807449/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170830065847.2444-1-stefan.sorensen@spectralink.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170830065847.2444-1-stefan.sorensen@spectralink.com>", "list_archive_url": null, "date": "2017-08-30T06:58:47", "name": "[net-next] dp83640: don't hold spinlock while calling netif_rx_ni", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "085c753299fee4f24e7b153ef8469b4b0790254a", "submitter": { "id": 47916, "url": "http://patchwork.ozlabs.org/api/people/47916/?format=api", "name": "Sørensen, Stefan", "email": "stefan.sorensen@spectralink.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170830065847.2444-1-stefan.sorensen@spectralink.com/mbox/", "series": [ { "id": 536, "url": "http://patchwork.ozlabs.org/api/series/536/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=536", "date": "2017-08-30T06:58:47", "name": "[net-next] dp83640: don't hold spinlock while calling netif_rx_ni", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/536/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807449/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807449/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=spectralink.onmicrosoft.com\n\theader.i=@spectralink.onmicrosoft.com header.b=\"Y4iOgwXL\"; \n\tdkim-atps=neutral", "spf=none (sender IP is )\n\tsmtp.mailfrom=Stefan.Sorensen@spectralink.com; " ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhxFM5jzZz9sN5\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 16:59:19 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750998AbdH3G7Q (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 30 Aug 2017 02:59:16 -0400", "from mail-by2nam03on0118.outbound.protection.outlook.com\n\t([104.47.42.118]:23245\n\t\"EHLO NAM03-BY2-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750824AbdH3G7P (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tWed, 30 Aug 2017 02:59:15 -0400", "from e31020.spectralink.com (213.83.164.162) by\n\tDM5PR07MB3484.namprd07.prod.outlook.com (10.164.153.27) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1385.9; Wed, 30 Aug 2017 06:59:12 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=spectralink.onmicrosoft.com; s=selector1-spectralink-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=TYZw64HMntYcR9CnOXU7kLFuuDDAM/NmBzJwjHQ8aW0=;\n\tb=Y4iOgwXLRDzOh7lwRzgVSkIzFNPiyhgxzpI0Xug5kMgwjldi6MlkY8bRCfJeK4DZzVQpOGMYljvR/YCV5OYH7OvXY0Q0oNWucDFLE3Fsm03sahKzjY00XMVsrnoMmU2eyrsrcSGYbim17za3sfx2dRBrPI6FCNlVfe5fMNbbIXg=", "From": "=?utf-8?q?Stefan_S=C3=B8rensen?= <stefan.sorensen@spectralink.com>", "To": "richardcochran@gmail.com, netdev@vger.kernel.org, davem@davemloft.net", "Cc": "=?utf-8?q?Stefan_S=C3=B8rensen?= <stefan.sorensen@spectralink.com>", "Subject": "[PATCH net-next] dp83640: don't hold spinlock while calling\n\tnetif_rx_ni", "Date": "Wed, 30 Aug 2017 08:58:47 +0200", "Message-Id": "<20170830065847.2444-1-stefan.sorensen@spectralink.com>", "X-Mailer": "git-send-email 2.13.5", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Originating-IP": "[213.83.164.162]", "X-ClientProxiedBy": "HE1P189CA0028.EURP189.PROD.OUTLOOK.COM (10.160.72.41) To\n\tDM5PR07MB3484.namprd07.prod.outlook.com (10.164.153.27)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "28c4f2a2-bdf7-4555-12d7-08d4ef749f5a", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DM5PR07MB3484; ", "X-Microsoft-Exchange-Diagnostics": [ "1; DM5PR07MB3484;\n\t3:wJIXbRpiajbFaIUeSG5fh1dOOcTCXyyOe7/wvkf4GYvWYYdSCZXqhpH24ySa7qZI60XqNzsF8tQDFx/7Y73Hw3tQHRSbPP2+LNtX2GzDl/T+C+5jc2cxXMjoFanU5YNpXDKfCJgzqEajxxoNn1u2eeeBra/T+e71qWq7pcrL3Cvbiq2iwQjSLORsxJuYzIwG8HtcuAHsyBmogUAerwGRcHhRRdNPEEa+JAtTSMo040YODDt0malrJIXJ6MFhPtmi;\n\t25:AonDNefYfomgt0xiTtjGk/HFMun4cJ2DiNY2eUdRfhnFrkZ+nHW4vVKZje8aPsTKjRaI74tBgL8DZq0H8lPxImFdED2qZ2JrWZ+++P1FzB9fJ6K9bbbvq+vTot3aFE2c2KoMelOLrqY1lnEqinbmu2FvfVVVVYHiNkHBe8uV3onUzFqPfwKryMWhdpT9+ADSRz4NY3IEfz3Rev5BfaEuYJClQMfKEGX2v1hJnh2YEB+VIYCRPUEUQ3ww0buquL6/HSDb5yrcWCYaJXa1PKMYAf/iIVaqIWBo1Q21M6SlamWpUJXK0cLgEjYYadXxDS2mfHoUZXgFrDZ+m7aZWy5tFQ==;\n\t31:V+8Q/akh9SH/g4cP2yf1uB0mbz6xCkFPRaySzYd/bABNiRXb0/sSo3TA4EL0HkBRDYn01bzx6VrPlylfw/SfW7fyi+QTju73PCTlLrGOmVaaixmxyOo46a2JVAsRrOI2cllO40jTZgYHH5L5+4c9sET1CwJh/gRXk5V4khV8oX2n0J8y4gqIsU5NN3FHCsulrRBswaFoPzU20vjhTz+VsBuYp1Ioy7otJaTi6svCMDk=", "1; DM5PR07MB3484;\n\t20:7FXIbH/XcEcPdTr1C+VSTlxPxwUxTJjSjxsrv8H08FJFVsDCaiEhHeFLKwxJD26NO1KfPl65+NQDvcnTIEvwZe/kJlnLbaMUMfRxqQHA53uQnSF8YWg11yif57ahHmnPUpvzNDsLxslgz2q6oYN3BecZoog5X9jr/NV45AA75sIO7hj5KAnHUZiM73B6HvLPMpSBO3Y06ltCz1GK+6sy4W1of2D4dWuYIU+DTm5q8LpsWiZmvHLYTcsAh6XyC5Oa1UOl4tTpAqtnnN4mH13bktHM0URNa5CrMjS3s+3zRBnZAFO4gtQqBPcIgA4Vd3y5Z1/YpSNi+9duHC3ZK4W6x6Pz12mwHLTTHbU5FG4S8OKdizyaQHva3m5D/QIQogRcN45ZhNnyVB94Q5NSOaO8M2IMJBsuFvMt3KZXyIfy9+S/e5MavGd9F0bg8hNrpkql9XowJ+QNGDMhEULDaUExgNFA5AbTWOUostT5FS2V9T68fZ2kbKX6gOkI3RrQJr5eYNmmdlkJSWYjQJAjDsud4UZ2eRQIkIyCcxRf4avHStmqpuVq8/vr/qYbhU7mP/FxmItwGUmPXbjNYdZqrZ25WOCNm3mJisWeyrKjjTyG7Ps=;\n\t4:O0IZr1QMyg2b3kbbGYezVjp6KlZQwQtRwhEogOh8b8ynUuLAPbx8PykAtr7RiA+kmMuCasJxQBiW+Sb+rECleNGlZQ9ivvDnbw68XXvW8U4TbCYKH9GAsVFuPXVB6C37sZxOGX9M7Mhxu/nt3cVC5ZaQggfr+Szo78SnDfgmORCBf1N2cBGpJ5yG/YUTSNg2mZItm+KwYmsOvZmsYyS2vz2C45WTgPVtFb/V6qXZtWnkZfrFBULW29wPnW/ikbxN", "=?utf-8?q?1=3BDM5PR07MB3484=3B23=3AulHo?=\n\t=?utf-8?q?njr1J2TARszSSxlVg5Dg7vjF4vdE4Ngp6WBc3zN1uPg0qU6SzZeeAN6I?=\n\t=?utf-8?q?fvPfIjIauDv9tv63BkBuZsYdMg4J+Phe9dkhmUvtEiU4ulGIliI+v9Vs?=\n\t=?utf-8?q?VV7LWKoJQx8E9KtpM0rkeKKNQFABPBBT3flrFiDa1Dy8keOJtIDgmyAk?=\n\t=?utf-8?q?j0gvOZljxFvkoStjWlbQqWybnHRMdsbUyrTm4/ay97XAASWrdWrn4UW8?=\n\t=?utf-8?q?IYgvWFVKmVk0nn0L0EfRgTzMbdqSQWTekVpqIawyHaapHLHC4Qx1VNnl?=\n\t=?utf-8?q?oLNI/oQz5V/XfiDZbvFUmRpt4A2t1EXo63ANnVOr8YaIPiX/HWzminxS?=\n\t=?utf-8?q?oU8PRJUTOu41E5JJJEQobm6isyT3jEryUjNs4jFxi+hweIYjeJMKgWWG?=\n\t=?utf-8?q?ij9n2l/lFCoGd77MTLEc9hRYDsCEqZesVxoZLZ0nQPcSgtjSVwbkFmXN?=\n\t=?utf-8?q?vSx20/Kc1+wyefmqFNfEnrcCPJ3kQZuBtxhIqdb1UjkLJebY8+HsQ+HM?=\n\t=?utf-8?q?kHIWQ4fVkghmU39hc5vSbfMh+rIZLIr4xFSgHKlfy0mOpW0KxNGGk11G?=\n\t=?utf-8?q?kVx/d+E5Ja1AyyVmCUJmgwW7T9RBE1F5akA5cWDHZDID4eFIqt+ugqFd?=\n\t=?utf-8?q?VPxAAakmDRQXLAeMPatAPUp2vlSp6PijRSvlmrXzA9bm/cpHQWJySuXi?=\n\t=?utf-8?q?JbC4UbN1lbyIZHwTdg+mPkoQZ3paYt5Bp1XHwgATkuJZ/SIQFxFMUpV+?=\n\t=?utf-8?q?GGBF9X1/TwZYB2Nu/y01vVs/yStomsZ/49tf15Dthph0FAFs7TAwNbgR?=\n\t=?utf-8?q?FgvPYZpC/frxEfxbHTZZRs/ma6p2/e0DzzG6Y+bvcATmRGBzveJNcwUR?=\n\t=?utf-8?q?jJA6EGsEuR6HOr2hAtKS6fzo4wuvbNRzZhGWHOmj4gadmHLhuDK4UGEb?=\n\t=?utf-8?q?zU03M7swLK9EZkXQG4bznguFlyJZZ5atqJmLm4dwMWXbdDHeQTDmkcUH?=\n\t=?utf-8?q?xtvdhFZtg95Rikd1kNg6geBi04MOVf88Zsme6lL3r3Ctohp7xHyAG26R?=\n\t=?utf-8?q?Du+6ajEmrvBIZl2HpSFSE4ZUxGuHZ2nXOw=3D=3D?=", "1; DM5PR07MB3484;\n\t6:JA8emXN0Scwe6INcj0HXwiwY+/iHQmGqvBvhALNkb/YS7iX2q+131QofQql3Sq8h8DGZWfaJykNWdjJn9yanrjO9GJvcZgKhF4Ih2HzNFe9U0JJNN0DAYpSjKwdXZi3PckWzc3f2Q+25A0Wp3jQ9i4o9A9QXG1Dg4epPV4XbJvkv52onJ9yqDs6UOOpefB9ZvglwhPSaJ9BrjTaoiWcFMam1hkkdFIAr35YxUTFYr+S4RAKgbIbF9De/ozMscnCMfF5oDqXzQDbygNea/Ue7CQBhTFXN6dFsSUFTNG/atjwdKiddmT+6p6iMsuuOzTjxfL2P8EipzSWV4aho5IKL7w==;\n\t5:WQWXvtT8C6B6ftTzIk2ufMn+PCobk+TVkeQEeVH6GnvxG9IMDEOwZR/OWREUS5GxTgYEx2RFjKKXtLTvy6aVjooQhGy8oFu0TF2ntUT1Ymvk5LasqMcRRZtN0LkIRc8FdWBQqMVO+Xh18tz5hWqSEw==;\n\t24:Y7bgBhr7ZuXqmJN+XCxWTfsNS7JsvRHESugyO4mHHWwfu7wBkHJ2z1mK8NY8nnxdcXeeA8nGclSwFDlhtV05YrU7YjquWBp3Cfhby2Hb9XE=;\n\t7:ENzV531OBz3lz5RkiANnuAnKuTbGwGJwUK9zjhUopEucIkmNjE6zNo3nTBFf+/MNlObkQ3P0qAz9iOzSyNB/DZ0Ndrf+yo4jP+9lw8BdSLVS5VnhXXDZOBk5Z63XiPhuGQl9VhbrgS5T1ZlV9Ju4AB0wyFSkpOPYPvN2g/SERmggrYkvY1y8RhpCHRW3Q/3RefdyZypa8FynA3Y8riIJ9J7Wq5iskDcbXTstjIVfFm0=" ], "X-MS-TrafficTypeDiagnostic": "DM5PR07MB3484:", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-Microsoft-Antispam-PRVS": "<DM5PR07MB348400B7726BC53C9B1DE0CCEF9C0@DM5PR07MB3484.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DM5PR07MB3484; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DM5PR07MB3484; ", "X-Forefront-PRVS": "041517DFAB", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10019020)(6009001)(199003)(189002)(23676002)(5660300001)(36756003)(101416001)(2906002)(50986999)(6486002)(25786009)(97736004)(106356001)(478600001)(72206003)(66066001)(86362001)(4326008)(6666003)(47776003)(1076002)(8936002)(50226002)(50466002)(42186005)(7736002)(105586002)(110136004)(69596002)(53416004)(39060400002)(189998001)(305945005)(2870700001)(3846002)(68736007)(81166006)(6116002)(107886003)(8676002)(53936002)(81156014)(33646002);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR07MB3484;\n\tH:e31020.spectralink.com; FPR:; SPF:None; PTR:InfoNoRecords;\n\tA:1; MX:1; LANG:en; ", "Received-SPF": "None (protection.outlook.com: spectralink.com does not\n\tdesignate permitted sender hosts)", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "spectralink.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "30 Aug 2017 06:59:12.4495\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "c45ba920-5298-4256-8585-360096d02150", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM5PR07MB3484", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "We should not hold a spinlock while pushing the skb into the networking\nstack, so move the call to netif_rx_ni out of the critical region to where\nwe have dropped the spinlock.\n\nSigned-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>\n---\n drivers/net/phy/dp83640.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c\nindex c3065236ffcc..cbd629822f04 100644\n--- a/drivers/net/phy/dp83640.c\n+++ b/drivers/net/phy/dp83640.c\n@@ -874,7 +874,6 @@ static void decode_rxts(struct dp83640_private *dp83640,\n \t\t\tshhwtstamps = skb_hwtstamps(skb);\n \t\t\tmemset(shhwtstamps, 0, sizeof(*shhwtstamps));\n \t\t\tshhwtstamps->hwtstamp = ns_to_ktime(rxts->ns);\n-\t\t\tnetif_rx_ni(skb);\n \t\t\tlist_add(&rxts->list, &dp83640->rxpool);\n \t\t\tbreak;\n \t\t}\n@@ -885,6 +884,9 @@ static void decode_rxts(struct dp83640_private *dp83640,\n \t\tlist_add_tail(&rxts->list, &dp83640->rxts);\n out:\n \tspin_unlock_irqrestore(&dp83640->rx_lock, flags);\n+\n+\tif (shhwtstamps)\n+\t\tnetif_rx_ni(skb);\n }\n \n static void decode_txts(struct dp83640_private *dp83640,\n@@ -1425,7 +1427,6 @@ static bool dp83640_rxtstamp(struct phy_device *phydev,\n \t\t\tshhwtstamps = skb_hwtstamps(skb);\n \t\t\tmemset(shhwtstamps, 0, sizeof(*shhwtstamps));\n \t\t\tshhwtstamps->hwtstamp = ns_to_ktime(rxts->ns);\n-\t\t\tnetif_rx_ni(skb);\n \t\t\tlist_del_init(&rxts->list);\n \t\t\tlist_add(&rxts->list, &dp83640->rxpool);\n \t\t\tbreak;\n@@ -1438,6 +1439,8 @@ static bool dp83640_rxtstamp(struct phy_device *phydev,\n \t\tskb_info->tmo = jiffies + SKB_TIMESTAMP_TIMEOUT;\n \t\tskb_queue_tail(&dp83640->rx_queue, skb);\n \t\tschedule_delayed_work(&dp83640->ts_work, SKB_TIMESTAMP_TIMEOUT);\n+\t} else {\n+\t\tnetif_rx_ni(skb);\n \t}\n \n \treturn true;\n", "prefixes": [ "net-next" ] }