Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807396/?format=api
{ "id": 807396, "url": "http://patchwork.ozlabs.org/api/patches/807396/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504066360-30128-7-git-send-email-paulus@ozlabs.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1504066360-30128-7-git-send-email-paulus@ozlabs.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1504066360-30128-7-git-send-email-paulus@ozlabs.org/", "date": "2017-08-30T04:12:29", "name": "[v3,06/17] powerpc: Fix emulation of the isel instruction", "commit_ref": "f1bbb99f41e06d5ba93ea8eafacd96a7a71d0c7d", "pull_url": null, "state": "accepted", "archived": false, "hash": "7f2d3f93f3a1914c31f5ac22e2dfe95f597c02f1", "submitter": { "id": 67079, "url": "http://patchwork.ozlabs.org/api/people/67079/?format=api", "name": "Paul Mackerras", "email": "paulus@ozlabs.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1504066360-30128-7-git-send-email-paulus@ozlabs.org/mbox/", "series": [ { "id": 522, "url": "http://patchwork.ozlabs.org/api/series/522/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=522", "date": "2017-08-30T04:12:25", "name": "powerpc: Do alignment fixups using analyse_instr etc.", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/522/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807396/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhsqW1nFDz9s9Y\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 14:25:11 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xhsqW0f5QzDqGV\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 14:25:11 +1000 (AEST)", "from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xhsYH0T1LzDqGV\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 30 Aug 2017 14:12:51 +1000 (AEST)", "by ozlabs.org (Postfix)\n\tid 3xhsYG6Vqvz9sPt; Wed, 30 Aug 2017 14:12:50 +1000 (AEST)", "from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xhsYG5LZ5z9sP5\n\tfor <linuxppc-dev@ozlabs.org>; Wed, 30 Aug 2017 14:12:50 +1000 (AEST)" ], "Authentication-Results": [ "ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"pQ7USpaO\";\n\tdkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"pQ7USpaO\";\n\tdkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"pQ7USpaO\"; \n\tdkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; \n\tt=1504066370; bh=kVQkwquEfJOgD3FoSblILFLMOK9zl9oLnb2+e/wdJrA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=pQ7USpaO3/ptoktFT+UgKhlQdImgA3R/Os8zgv01rZm75wZYC0Q4stGkP2V1xH2iu\n\tDfomp+8+XHHJoQ4O5GgjauGdRhsgi/V3M2xSqAmYSh97B9u98K0a8bOgi5oaKeJQjh\n\tLofe5s2Vxoe/QIBsC4jwcidr/MC1weArTcJyDNB9Rj0kveq9s0S3CT9u5kkUFVWS75\n\txG4Jak0W54EyoYDJbLOUKDZ5i5dtpVvcnTmOxTUJjepCV7d01RYiK1WmB2rLEqnD6q\n\tAluq/OkQuMadBsdxqbJgUwtB03pymVDK4DLJmICL4R8K2FUrSIYK9dvZiYe99+oN82\n\tZOFQiiASvek6w==", "From": "Paul Mackerras <paulus@ozlabs.org>", "To": "linuxppc-dev@ozlabs.org", "Subject": "[PATCH v3 06/17] powerpc: Fix emulation of the isel instruction", "Date": "Wed, 30 Aug 2017 14:12:29 +1000", "Message-Id": "<1504066360-30128-7-git-send-email-paulus@ozlabs.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504066360-30128-1-git-send-email-paulus@ozlabs.org>", "References": "<1504066360-30128-1-git-send-email-paulus@ozlabs.org>", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "The case added for the isel instruction was added inside a switch\nstatement which uses the 10-bit minor opcode field in the 0x7fe\nbits of the instruction word. However, for the isel instruction,\nthe minor opcode field is only the 0x3e bits, and the 0x7c0 bits\nare used for the \"BC\" field, which indicates which CR bit to use\nto select the result.\n\nTherefore, for the isel emulation to work correctly when BC != 0,\nwe need to match on ((instr >> 1) & 0x1f) == 15). To do this, we\npull the isel case out of the switch statement and put it in an\nif statement of its own.\n\nFixes: e27f71e5ff3c (\"powerpc/lib/sstep: Add isel instruction emulation\")\nSigned-off-by: Paul Mackerras <paulus@ozlabs.org>\n---\n arch/powerpc/lib/sstep.c | 18 ++++++++++--------\n 1 file changed, 10 insertions(+), 8 deletions(-)", "diff": "diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c\nindex e20f2b4..522bc7b 100644\n--- a/arch/powerpc/lib/sstep.c\n+++ b/arch/powerpc/lib/sstep.c\n@@ -1216,6 +1216,16 @@ int analyse_instr(struct instruction_op *op, const struct pt_regs *regs,\n \t\treturn 0;\n \n \tcase 31:\n+\t\t/* isel occupies 32 minor opcodes */\n+\t\tif (((instr >> 1) & 0x1f) == 15) {\n+\t\t\tmb = (instr >> 6) & 0x1f; /* bc field */\n+\t\t\tval = (regs->ccr >> (31 - mb)) & 1;\n+\t\t\tval2 = (ra) ? regs->gpr[ra] : 0;\n+\n+\t\t\top->val = (val) ? val2 : regs->gpr[rb];\n+\t\t\tgoto compute_done;\n+\t\t}\n+\n \t\tswitch ((instr >> 1) & 0x3ff) {\n \t\tcase 4:\t\t/* tw */\n \t\t\tif (rd == 0x1f ||\n@@ -1441,14 +1451,6 @@ int analyse_instr(struct instruction_op *op, const struct pt_regs *regs,\n /*\n * Logical instructions\n */\n-\t\tcase 15:\t/* isel */\n-\t\t\tmb = (instr >> 6) & 0x1f; /* bc */\n-\t\t\tval = (regs->ccr >> (31 - mb)) & 1;\n-\t\t\tval2 = (ra) ? regs->gpr[ra] : 0;\n-\n-\t\t\top->val = (val) ? val2 : regs->gpr[rb];\n-\t\t\tgoto compute_done;\n-\n \t\tcase 26:\t/* cntlzw */\n \t\t\top->val = __builtin_clz((unsigned int) regs->gpr[rd]);\n \t\t\tgoto logical_done;\n", "prefixes": [ "v3", "06/17" ] }