Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807316/?format=api
{ "id": 807316, "url": "http://patchwork.ozlabs.org/api/patches/807316/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829212053.6003-1-ehabkost@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170829212053.6003-1-ehabkost@redhat.com>", "list_archive_url": null, "date": "2017-08-29T21:20:53", "name": "oslib-posix: Print errors before aborting on qemu_alloc_stack()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "22b752fd1265d55ebe3fe4f583b6b94bc56dc420", "submitter": { "id": 195, "url": "http://patchwork.ozlabs.org/api/people/195/?format=api", "name": "Eduardo Habkost", "email": "ehabkost@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829212053.6003-1-ehabkost@redhat.com/mbox/", "series": [ { "id": 480, "url": "http://patchwork.ozlabs.org/api/series/480/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=480", "date": "2017-08-29T21:20:53", "name": "oslib-posix: Print errors before aborting on qemu_alloc_stack()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/480/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807316/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807316/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhhQg0fQGz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 07:21:27 +1000 (AEST)", "from localhost ([::1]:47054 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmnwo-00073c-DD\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 17:21:22 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:56537)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <ehabkost@redhat.com>) id 1dmnwU-00073X-W4\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 17:21:04 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <ehabkost@redhat.com>) id 1dmnwR-0002kO-0H\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 17:21:02 -0400", "from mx1.redhat.com ([209.132.183.28]:55332)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <ehabkost@redhat.com>) id 1dmnwQ-0002jS-QN\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 17:20:58 -0400", "from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D78C2C0587D3\n\tfor <qemu-devel@nongnu.org>; Tue, 29 Aug 2017 21:20:57 +0000 (UTC)", "from localhost (ovpn-116-31.gru2.redhat.com [10.97.116.31])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A478F5D9C0;\n\tTue, 29 Aug 2017 21:20:55 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com D78C2C0587D3", "From": "Eduardo Habkost <ehabkost@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 29 Aug 2017 18:20:53 -0300", "Message-Id": "<20170829212053.6003-1-ehabkost@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 29 Aug 2017 21:20:58 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH] oslib-posix: Print errors before aborting on\n\tqemu_alloc_stack()", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "If QEMU is running on a system that's out of memory and mmap()\nfails, QEMU aborts with no error message at all, making it hard\nto debug the reason for the failure.\n\nAdd perror() calls that will print error information before\naborting.\n\nSigned-off-by: Eduardo Habkost <ehabkost@redhat.com>\n---\n util/oslib-posix.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/util/oslib-posix.c b/util/oslib-posix.c\nindex cacf0ef..80086c5 100644\n--- a/util/oslib-posix.c\n+++ b/util/oslib-posix.c\n@@ -530,6 +530,7 @@ void *qemu_alloc_stack(size_t *sz)\n ptr = mmap(NULL, *sz, PROT_READ | PROT_WRITE,\n MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);\n if (ptr == MAP_FAILED) {\n+ perror(\"failed to allocate memory for stack\");\n abort();\n }\n \n@@ -544,6 +545,7 @@ void *qemu_alloc_stack(size_t *sz)\n guardpage = ptr;\n #endif\n if (mprotect(guardpage, pagesz, PROT_NONE) != 0) {\n+ perror(\"failed to set up stack guard page\");\n abort();\n }\n \n", "prefixes": [] }