Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807288/?format=api
{ "id": 807288, "url": "http://patchwork.ozlabs.org/api/patches/807288/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170829201601.64312-14-sjg@chromium.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170829201601.64312-14-sjg@chromium.org>", "list_archive_url": null, "date": "2017-08-29T20:15:58", "name": "[U-Boot,v2,13/16] dtoc: Put phandle args in an array", "commit_ref": "bc79617fdfeb4afabb94774885447dd64d7bea6c", "pull_url": null, "state": "accepted", "archived": false, "hash": "e689979e1310076f48fd5084974babb83f36bcc1", "submitter": { "id": 6170, "url": "http://patchwork.ozlabs.org/api/people/6170/?format=api", "name": "Simon Glass", "email": "sjg@chromium.org" }, "delegate": { "id": 3184, "url": "http://patchwork.ozlabs.org/api/users/3184/?format=api", "username": "sjg", "first_name": "Simon", "last_name": "Glass", "email": "sjg@chromium.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170829201601.64312-14-sjg@chromium.org/mbox/", "series": [ { "id": 462, "url": "http://patchwork.ozlabs.org/api/series/462/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=462", "date": "2017-08-29T20:15:45", "name": "dtoc: Add support for 64-bit addresses", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/462/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807288/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807288/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"KSYycmd9\"; dkim-atps=neutral" ], "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhgHp1XnXz9sRV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 06:30:30 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid D3652C2263E; Tue, 29 Aug 2017 20:20:54 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 799E3C21DF8;\n\tTue, 29 Aug 2017 20:17:56 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 6DD8BC22542; Tue, 29 Aug 2017 20:16:29 +0000 (UTC)", "from mail-oi0-f53.google.com (mail-oi0-f53.google.com\n\t[209.85.218.53])\n\tby lists.denx.de (Postfix) with ESMTPS id 0627FC22600\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 20:16:26 +0000 (UTC)", "by mail-oi0-f53.google.com with SMTP id k77so36403535oib.2\n\tfor <u-boot@lists.denx.de>; Tue, 29 Aug 2017 13:16:25 -0700 (PDT)", "from kiwi.bld.corp.google.com ([2620:0:10f2:0:e46b:9284:3d4c:e46e])\n\tby smtp.gmail.com with ESMTPSA id\n\tm3sm3890238oif.17.2017.08.29.13.16.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 13:16:20 -0700 (PDT)", "by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 5B22513FAB7; Tue, 29 Aug 2017 14:16:20 -0600 (MDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=BwvucLNONeh6iRsxyX8hadD8szsAq3BsXaTETGD4fJI=;\n\tb=KSYycmd9YBT7ne1h4J3BStGSoaMMl7q9iPzLaWspr+yVysscYF92dlldp4WK5WsTL7\n\tKHFS14lZdcxyQe3Z7jofEn3qu710oyMvXtHEQ08Ciqy2BC50nbRxAI+fAxzzwAOv5v9Q\n\tZ51rjG9hOSCytaR/73OCkyrEsLnG8hE1oaBfG5hE7stBiN7twvoj9LXtc2JS+32NzvUn\n\tI+/DkEOH9uCYR3pwSLEnojRRVQQZ0LK1mThFW5qcIW9ZWXWwIGjKvXHzDdY/307EPtu2\n\ts/YulCLJ5iH1cgXUI/+8r//CnB1L2n9CFxjMVET2vvHObBuxkEJceQY8aPkbLy7tNNV+\n\tXzCw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=BwvucLNONeh6iRsxyX8hadD8szsAq3BsXaTETGD4fJI=;\n\tb=RTNb7wrmz7Ohfhnu/OxU6s3gBSNcGO8VI3FcTOPG4HWRzeKSJ31KS2nw6z+hbPf8p3\n\t4MlfmecQhb0BVDpeswXzwn7sdRnhg1kMbDgp/HkBWMFfBzND46Tsr8sfokx1ND0o2Lof\n\tBDPdlJBgC0gxQg5opaKj8ZoLS9VOhE8B6Ckj+pI16bi3VzikHN1dooxKIPOVOhxlfHnw\n\tcXEroq9oA1AcUDjBd+uvdFUrG6RV9qBfokLyngHO5Cdl5qSXR77ktvvKXqhq5nEtxsvt\n\t/MSB21UHz3l49TbhwIUSRDSmsqqWinLt+gG6zjiuC3wowTUbmPhNvclY4Uivy1PQQAoU\n\tpKOw==", "X-Gm-Message-State": "AHYfb5jjssKs9uLJeJvxnO61ePY1ecWFSsXeQrpNHTLNesVsGc1iViNz\n\tMeye5yv+KW4ix9Nu", "X-Google-Smtp-Source": "ADKCNb4ubzzFK3Xuubrj/Rst2MIqffx0gwp8Whvjw3c1fbRJlbVzoKY/6Eiyt2+bj9xI4u6c4wRyFQ==", "X-Received": "by 10.202.71.5 with SMTP id u5mr1393747oia.56.1504037784418;\n\tTue, 29 Aug 2017 13:16:24 -0700 (PDT)", "From": "Simon Glass <sjg@chromium.org>", "To": "U-Boot Mailing List <u-boot@lists.denx.de>", "Date": "Tue, 29 Aug 2017 14:15:58 -0600", "Message-Id": "<20170829201601.64312-14-sjg@chromium.org>", "X-Mailer": "git-send-email 2.14.1.342.g6490525c54-goog", "In-Reply-To": "<20170829201601.64312-1-sjg@chromium.org>", "References": "<20170829201601.64312-1-sjg@chromium.org>", "Cc": "Tom Rini <trini@konsulko.com>", "Subject": "[U-Boot] [PATCH v2 13/16] dtoc: Put phandle args in an array", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "We want to support more than one phandle argument. It makes sense to use\nan array for this rather than discrete struct members. Adjust the code to\nsupport this. Rename the member to 'arg' instead of 'id'.\n\nSigned-off-by: Simon Glass <sjg@chromium.org>\n---\n\nChanges in v2: None\n\n drivers/clk/clk-uclass.c | 2 +-\n include/dt-structs.h | 4 ++--\n tools/dtoc/dtb_platdata.py | 2 +-\n tools/dtoc/test_dtoc.py | 2 +-\n 4 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c\nindex 8b40326efa..83ba13374c 100644\n--- a/drivers/clk/clk-uclass.c\n+++ b/drivers/clk/clk-uclass.c\n@@ -32,7 +32,7 @@ int clk_get_by_index_platdata(struct udevice *dev, int index,\n \tret = uclass_get_device(UCLASS_CLK, 0, &clk->dev);\n \tif (ret)\n \t\treturn ret;\n-\tclk->id = cells[0].id;\n+\tclk->id = cells[0].arg[0];\n \n \treturn 0;\n }\ndiff --git a/include/dt-structs.h b/include/dt-structs.h\nindex 2ed997115a..9ab4e2524d 100644\n--- a/include/dt-structs.h\n+++ b/include/dt-structs.h\n@@ -11,12 +11,12 @@\n #if CONFIG_IS_ENABLED(OF_PLATDATA)\n struct phandle_0_arg {\n \tconst void *node;\n-\tint id[0];\n+\tint arg[0];\n };\n \n struct phandle_1_arg {\n \tconst void *node;\n-\tint id;\n+\tint arg[1];\n };\n #include <generated/dt-structs.h>\n #endif\ndiff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py\nindex c0a3ae692b..1920a59f82 100644\n--- a/tools/dtoc/dtb_platdata.py\n+++ b/tools/dtoc/dtb_platdata.py\n@@ -467,7 +467,7 @@ class DtbPlatdata(object):\n id_num = fdt_util.fdt32_to_cpu(id_cell)\n target_node = self._fdt.phandle_to_node[phandle]\n name = conv_name_to_c(target_node.name)\n- vals.append('{&%s%s, %d}' % (VAL_PREFIX, name, id_num))\n+ vals.append('{&%s%s, {%d}}' % (VAL_PREFIX, name, id_num))\n for val in vals:\n self.buf('\\n\\t\\t%s,' % val)\n else:\ndiff --git a/tools/dtoc/test_dtoc.py b/tools/dtoc/test_dtoc.py\nindex aa617a649c..fbae927cf8 100644\n--- a/tools/dtoc/test_dtoc.py\n+++ b/tools/dtoc/test_dtoc.py\n@@ -253,7 +253,7 @@ U_BOOT_DEVICE(phandle_target) = {\n \n static struct dtd_source dtv_phandle_source = {\n \\t.clocks\\t\\t\\t= {\n-\\t\\t{&dtv_phandle_target, 1},},\n+\\t\\t{&dtv_phandle_target, {1}},},\n };\n U_BOOT_DEVICE(phandle_source) = {\n \\t.name\\t\\t= \"source\",\n", "prefixes": [ "U-Boot", "v2", "13/16" ] }