Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807210/?format=api
{ "id": 807210, "url": "http://patchwork.ozlabs.org/api/patches/807210/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170829093242.41026-12-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170829093242.41026-12-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-08-29T09:32:41", "name": "[next,S79-V2,12/13] i40evf: enable support for VF VLAN tag stripping control", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b41c464fe3564081bc9466a03a6b8fca80730bc9", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170829093242.41026-12-alice.michael@intel.com/mbox/", "series": [ { "id": 423, "url": "http://patchwork.ozlabs.org/api/series/423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=423", "date": "2017-08-29T09:32:31", "name": "[next,S79-V2,01/13] i40e: add private flag to control source pruning", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/423/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807210/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807210/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhbST0pnbz9t3V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 03:37:45 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 43F3C86E97;\n\tTue, 29 Aug 2017 17:37:43 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zJwsks_6scs6; Tue, 29 Aug 2017 17:37:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B0B1687252;\n\tTue, 29 Aug 2017 17:37:41 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 762191C1F4F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Aug 2017 17:37:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6FD6A87E9B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Aug 2017 17:37:36 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dDIwETHDGKIA for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Aug 2017 17:37:35 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id EE73888581\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Aug 2017 17:37:34 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP; 29 Aug 2017 10:37:33 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga003.jf.intel.com with ESMTP; 29 Aug 2017 10:37:33 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.41,445,1498546800\"; d=\"scan'208\";\n\ta=\"1008934136\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 29 Aug 2017 05:32:41 -0400", "Message-Id": "<20170829093242.41026-12-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170829093242.41026-1-alice.michael@intel.com>", "References": "<20170829093242.41026-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S79-V2 12/13] i40evf: enable support\n\tfor VF VLAN tag stripping control", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nA recent commit 809481484e5d (\"i40e/i40evf: support for VF VLAN tag\nstripping control\") added support for VFs to negotiate the control of\nVLAN tag stripping. This should have allowed VFs to disable the feature.\nUnfortunately, the flag was set only in netdev->feature flags and not in\nnetdev->hw_features.\n\nThis ultimately causes the stack to assume that it cannot change the\nflag, so it was unchangeable and marked as [fixed] in the ethtool -k\noutput.\n\nFix this by setting the feature in hw_features first, just as we do for\nthe PF code. This enables ethtool -K to disable the feature correctly,\nand fully enables user control of the VLAN tag stripping feature.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 22 ++++++++++++++--------\n 1 file changed, 14 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 70a033c..5caa1bd 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -2425,10 +2425,6 @@ static netdev_features_t i40evf_features_check(struct sk_buff *skb,\n \treturn features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK);\n }\n \n-#define I40EVF_VLAN_FEATURES (NETIF_F_HW_VLAN_CTAG_TX |\\\n-\t\t\t NETIF_F_HW_VLAN_CTAG_RX |\\\n-\t\t\t NETIF_F_HW_VLAN_CTAG_FILTER)\n-\n /**\n * i40evf_fix_features - fix up the netdev feature bits\n * @netdev: our net device\n@@ -2441,9 +2437,11 @@ static netdev_features_t i40evf_fix_features(struct net_device *netdev,\n {\n \tstruct i40evf_adapter *adapter = netdev_priv(netdev);\n \n-\tfeatures &= ~I40EVF_VLAN_FEATURES;\n-\tif (adapter->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN)\n-\t\tfeatures |= I40EVF_VLAN_FEATURES;\n+\tif (!(adapter->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN))\n+\t\tfeatures &= ~(NETIF_F_HW_VLAN_CTAG_TX |\n+\t\t\t NETIF_F_HW_VLAN_CTAG_RX |\n+\t\t\t NETIF_F_HW_VLAN_CTAG_FILTER);\n+\n \treturn features;\n }\n \n@@ -2574,9 +2572,17 @@ int i40evf_process_config(struct i40evf_adapter *adapter)\n \t */\n \thw_features = hw_enc_features;\n \n+\t/* Enable VLAN features if supported */\n+\tif (vfres->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN)\n+\t\thw_features |= (NETIF_F_HW_VLAN_CTAG_TX |\n+\t\t\t\tNETIF_F_HW_VLAN_CTAG_RX);\n+\n \tnetdev->hw_features |= hw_features;\n \n-\tnetdev->features |= hw_features | I40EVF_VLAN_FEATURES;\n+\tnetdev->features |= hw_features;\n+\n+\tif (vfres->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_VLAN)\n+\t\tnetdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;\n \n \tadapter->vsi.id = adapter->vsi_res->vsi_id;\n \n", "prefixes": [ "next", "S79-V2", "12/13" ] }