Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807209/?format=api
{ "id": 807209, "url": "http://patchwork.ozlabs.org/api/patches/807209/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170829093242.41026-6-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170829093242.41026-6-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-08-29T09:32:35", "name": "[next,S79-V2,06/13] i40e/i40evf: use DECLARE_BITMAP for state", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9204ece19a4ba2d086e2288dc8a560a22af74b0c", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170829093242.41026-6-alice.michael@intel.com/mbox/", "series": [ { "id": 423, "url": "http://patchwork.ozlabs.org/api/series/423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=423", "date": "2017-08-29T09:32:31", "name": "[next,S79-V2,01/13] i40e: add private flag to control source pruning", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/423/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807209/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhbSS3Q84z9ryr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 03:37:44 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BB23087247;\n\tTue, 29 Aug 2017 17:37:42 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OvL_eDrgD_0N; Tue, 29 Aug 2017 17:37:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6BF5687220;\n\tTue, 29 Aug 2017 17:37:41 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E43841CEA20\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Aug 2017 17:37:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D93F988B00\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Aug 2017 17:37:35 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id IwMoZmPcBJvE for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Aug 2017 17:37:34 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 56DD5889C8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 29 Aug 2017 17:37:34 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP; 29 Aug 2017 10:37:33 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga003.jf.intel.com with ESMTP; 29 Aug 2017 10:37:33 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.41,445,1498546800\"; d=\"scan'208\";\n\ta=\"1008934117\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Tue, 29 Aug 2017 05:32:35 -0400", "Message-Id": "<20170829093242.41026-6-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170829093242.41026-1-alice.michael@intel.com>", "References": "<20170829093242.41026-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S79-V2 06/13] i40e/i40evf: use\n\tDECLARE_BITMAP for state", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nWhen using set_bit and friends, we should be using actual\nbitmaps, and fix all the locations where we might access\nit.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--\n drivers/net/ethernet/intel/i40e/i40e_txrx.h | 3 ++-\n drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 3 ++-\n 3 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex e9fc34c..1764fd2 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -2892,7 +2892,7 @@ static void i40e_config_xps_tx_ring(struct i40e_ring *ring)\n \t\treturn;\n \n \tif ((vsi->tc_config.numtc <= 1) &&\n-\t !test_and_set_bit(__I40E_TX_XPS_INIT_DONE, &ring->state)) {\n+\t !test_and_set_bit(__I40E_TX_XPS_INIT_DONE, ring->state)) {\n \t\tcpu = cpumask_local_spread(ring->q_vector->v_idx, -1);\n \t\tnetif_set_xps_queue(ring->netdev, get_cpu_mask(cpu),\n \t\t\t\t ring->queue_index);\n@@ -3011,7 +3011,7 @@ static int i40e_configure_rx_ring(struct i40e_ring *ring)\n \tstruct i40e_hmc_obj_rxq rx_ctx;\n \ti40e_status err = 0;\n \n-\tring->state = 0;\n+\tbitmap_zero(ring->state, __I40E_RING_STATE_NBITS);\n \n \t/* clear the context structure first */\n \tmemset(&rx_ctx, 0, sizeof(rx_ctx));\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\nindex 2f848bc..a4e3e66 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n@@ -342,6 +342,7 @@ struct i40e_rx_queue_stats {\n enum i40e_ring_state_t {\n \t__I40E_TX_FDIR_INIT_DONE,\n \t__I40E_TX_XPS_INIT_DONE,\n+\t__I40E_RING_STATE_NBITS /* must be last */\n };\n \n /* some useful defines for virtchannel interface, which\n@@ -366,7 +367,7 @@ struct i40e_ring {\n \t\tstruct i40e_tx_buffer *tx_bi;\n \t\tstruct i40e_rx_buffer *rx_bi;\n \t};\n-\tunsigned long state;\n+\tDECLARE_BITMAP(state, __I40E_RING_STATE_NBITS);\n \tu16 queue_index;\t\t/* Queue number of ring */\n \tu8 dcb_tc;\t\t\t/* Traffic class of ring */\n \tu8 __iomem *tail;\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\nindex 0d9f98b..d8ca802 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n@@ -325,6 +325,7 @@ struct i40e_rx_queue_stats {\n enum i40e_ring_state_t {\n \t__I40E_TX_FDIR_INIT_DONE,\n \t__I40E_TX_XPS_INIT_DONE,\n+\t__I40E_RING_STATE_NBITS /* must be last */\n };\n \n /* some useful defines for virtchannel interface, which\n@@ -348,7 +349,7 @@ struct i40e_ring {\n \t\tstruct i40e_tx_buffer *tx_bi;\n \t\tstruct i40e_rx_buffer *rx_bi;\n \t};\n-\tunsigned long state;\n+\tDECLARE_BITMAP(state, __I40E_RING_STATE_NBITS);\n \tu16 queue_index;\t\t/* Queue number of ring */\n \tu8 dcb_tc;\t\t\t/* Traffic class of ring */\n \tu8 __iomem *tail;\n", "prefixes": [ "next", "S79-V2", "06/13" ] }