Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807168/?format=api
{ "id": 807168, "url": "http://patchwork.ozlabs.org/api/patches/807168/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829164017.14178-1-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170829164017.14178-1-berrange@redhat.com>", "list_archive_url": null, "date": "2017-08-29T16:40:17", "name": "io: fix check for handshake completion in TLS test", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "59fb7180fa137f5d9dac1d36f44fed058cb981d0", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829164017.14178-1-berrange@redhat.com/mbox/", "series": [ { "id": 405, "url": "http://patchwork.ozlabs.org/api/series/405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=405", "date": "2017-08-29T16:40:17", "name": "io: fix check for handshake completion in TLS test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/405/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807168/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807168/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhZC12NWlz9t38\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 02:41:00 +1000 (AEST)", "from localhost ([::1]:46052 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmjZR-0005zL-2A\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 12:40:57 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:45002)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dmjYw-0005xR-8Y\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 12:40:27 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dmjYs-0004af-3z\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 12:40:26 -0400", "from mx1.redhat.com ([209.132.183.28]:33402)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <berrange@redhat.com>) id 1dmjYr-0004ZD-Se\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 12:40:22 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DC1BD4ACBD\n\tfor <qemu-devel@nongnu.org>; Tue, 29 Aug 2017 16:40:20 +0000 (UTC)", "from t460.redhat.com (unknown [10.33.36.95])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0CC1E18B37;\n\tTue, 29 Aug 2017 16:40:19 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com DC1BD4ACBD", "From": "\"Daniel P. Berrange\" <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 29 Aug 2017 17:40:17 +0100", "Message-Id": "<20170829164017.14178-1-berrange@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 29 Aug 2017 16:40:21 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH] io: fix check for handshake completion in TLS\n\ttest", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The TLS I/O channel test had mistakenly used && instead\nof || when checking for handshake completion. As a\nresult it could terminate the handshake process before\nit had actually completed. This was harmless before but\nchanges in GNUTLS 3.6.0 exposed this bug and caused the\ntest suite to fail.\n\nSigned-off-by: Daniel P. Berrange <berrange@redhat.com>\n---\n tests/test-io-channel-tls.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/tests/test-io-channel-tls.c b/tests/test-io-channel-tls.c\nindex 8eaa208e1b..e7c80f46cf 100644\n--- a/tests/test-io-channel-tls.c\n+++ b/tests/test-io-channel-tls.c\n@@ -218,7 +218,7 @@ static void test_io_channel_tls(const void *opaque)\n mainloop = g_main_context_default();\n do {\n g_main_context_iteration(mainloop, TRUE);\n- } while (!clientHandshake.finished &&\n+ } while (!clientHandshake.finished ||\n !serverHandshake.finished);\n \n g_assert(clientHandshake.failed == data->expectClientFail);\n", "prefixes": [] }