Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807147/?format=api
{ "id": 807147, "url": "http://patchwork.ozlabs.org/api/patches/807147/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/patch/20170829150426.5935-1-colin.king@canonical.com/", "project": { "id": 24, "url": "http://patchwork.ozlabs.org/api/projects/24/?format=api", "name": "Firmware Test Suite development", "link_name": "fwts", "list_id": "fwts-devel.lists.ubuntu.com", "list_email": "fwts-devel@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170829150426.5935-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-08-29T15:04:26", "name": "acpica: fwts_acpica: fix linker issues on Fedora (LP: #1712572)", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0a5ef4da4870d8cc42d970337f785d1c4b20f769", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/fwts/patch/20170829150426.5935-1-colin.king@canonical.com/mbox/", "series": [ { "id": 390, "url": "http://patchwork.ozlabs.org/api/series/390/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/list/?series=390", "date": "2017-08-29T15:04:26", "name": "acpica: fwts_acpica: fix linker issues on Fedora (LP: #1712572)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/390/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807147/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<fwts-devel-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)", "Received": [ "from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhX3j2gRYz9sRV;\n\tWed, 30 Aug 2017 01:04:33 +1000 (AEST)", "from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.76)\n\t(envelope-from <fwts-devel-bounces@lists.ubuntu.com>)\n\tid 1dmi47-0008Qc-T1; Tue, 29 Aug 2017 15:04:31 +0000", "from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1dmi43-0008Pv-5o\n\tfor fwts-devel@lists.ubuntu.com; Tue, 29 Aug 2017 15:04:27 +0000", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1dmi42-000777-RU; Tue, 29 Aug 2017 15:04:26 +0000" ], "From": "Colin King <colin.king@canonical.com>", "To": "fwts-devel@lists.ubuntu.com", "Subject": "[PATCH] acpica: fwts_acpica: fix linker issues on Fedora (LP:\n\t#1712572)", "Date": "Tue, 29 Aug 2017 16:04:26 +0100", "Message-Id": "<20170829150426.5935-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.14.1", "MIME-Version": "1.0", "X-BeenThere": "fwts-devel@lists.ubuntu.com", "X-Mailman-Version": "2.1.14", "Precedence": "list", "List-Id": "Firmware Test Suite Development <fwts-devel.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/fwts-devel>,\n\t<mailto:fwts-devel-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/fwts-devel>", "List-Post": "<mailto:fwts-devel@lists.ubuntu.com>", "List-Help": "<mailto:fwts-devel-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/fwts-devel>,\n\t<mailto:fwts-devel-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "fwts-devel-bounces@lists.ubuntu.com", "Sender": "fwts-devel-bounces@lists.ubuntu.com" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nWhen building for ppcC64el on Fedora we get linker issues with\nundefined symbols. It seems that while this is not an issue on\nDebian systems, the linker seems to require these sysbols to be\ndefined even if we don't actually use them. Make these functions\nvoid no-ops that throw warnings if they are used. This has been\ntested on Fedora 25 and also Ubuntu and is able to build and\npass the regression tests.\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n src/acpica/fwts_acpica.c | 36 ++++++++++++++++++++++++++++++++++++\n 1 file changed, 36 insertions(+)", "diff": "diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c\nindex b85e18d6..b0cefe73 100644\n--- a/src/acpica/fwts_acpica.c\n+++ b/src/acpica/fwts_acpica.c\n@@ -1326,4 +1326,40 @@ fwts_list *fwts_acpica_get_object_names(int type)\n \treturn list;\n }\n \n+#else\n+\n+static void __void_func(const char *funcname)\n+{\n+\tfprintf(stderr, \"fwts ACPICA library: unexpected call to %s()\\n\", funcname);\n+\texit(EXIT_FAILURE);\n+}\n+\n+#define VOID_FUNC(name) void name(void) { __void_func(#name); }\n+\n+/*\n+ * With ACPI disabled, these functions should never\n+ * be called. We should defined this otherwise we will\n+ * get linker errors with some autotools/linker combos\n+ */\n+VOID_FUNC(AcpiGbl_IgnoreErrors)\n+VOID_FUNC(AcpiGbl_RegionFillValue)\n+\n+VOID_FUNC(AcpiOsCreateSemaphore)\n+VOID_FUNC(AcpiOsDeleteSemaphore)\n+VOID_FUNC(AcpiOsExecute)\n+VOID_FUNC(AcpiOsGetRootPointer)\n+VOID_FUNC(AcpiOsPrintf)\n+VOID_FUNC(AcpiOsReadPciConfiguration)\n+VOID_FUNC(AcpiOsReadPort)\n+VOID_FUNC(AcpiOsSignal)\n+VOID_FUNC(AcpiOsSignalSemaphore)\n+VOID_FUNC(AcpiOsSleep)\n+VOID_FUNC(AcpiOsVprintf)\n+VOID_FUNC(AcpiOsWaitSemaphore)\n+\n+VOID_FUNC(AeTableOverride)\n+\n+VOID_FUNC(MpSaveGpioInfo)\n+VOID_FUNC(MpSaveSerialInfo)\n+\n #endif\n", "prefixes": [] }