Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807127/?format=api
{ "id": 807127, "url": "http://patchwork.ozlabs.org/api/patches/807127/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/150401748121.16384.7676807301169759129.stgit@firesoul/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<150401748121.16384.7676807301169759129.stgit@firesoul>", "list_archive_url": null, "date": "2017-08-29T14:38:01", "name": "[net-next,5/7] xdp: separate xdp_redirect tracepoint in map case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a20f2cd4575dd6949dbcfebb4decfc30a4c57c93", "submitter": { "id": 13625, "url": "http://patchwork.ozlabs.org/api/people/13625/?format=api", "name": "Jesper Dangaard Brouer", "email": "brouer@redhat.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/150401748121.16384.7676807301169759129.stgit@firesoul/mbox/", "series": [ { "id": 382, "url": "http://patchwork.ozlabs.org/api/series/382/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=382", "date": "2017-08-29T14:37:35", "name": "XDP redirect tracepoints", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/382/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807127/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807127/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=brouer@redhat.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhWTJ75Kyz9s7f\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 00:38:12 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754555AbdH2OiJ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 10:38:09 -0400", "from mx1.redhat.com ([209.132.183.28]:49858 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932066AbdH2OiD (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 29 Aug 2017 10:38:03 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D7EC8267DF;\n\tTue, 29 Aug 2017 14:38:02 +0000 (UTC)", "from firesoul.localdomain (ovpn-200-32.brq.redhat.com\n\t[10.40.200.32])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1D93C6BF9C;\n\tTue, 29 Aug 2017 14:38:02 +0000 (UTC)", "from [192.168.5.1] (localhost [IPv6:::1])\n\tby firesoul.localdomain (Postfix) with ESMTP id 4896F30F12C9F;\n\tTue, 29 Aug 2017 16:38:01 +0200 (CEST)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com D7EC8267DF", "Subject": "[PATCH net-next 5/7] xdp: separate xdp_redirect tracepoint in map\n\tcase", "From": "Jesper Dangaard Brouer <brouer@redhat.com>", "To": "netdev@vger.kernel.org", "Cc": "John Fastabend <john.fastabend@gmail.com>,\n\tJesper Dangaard Brouer <brouer@redhat.com>", "Date": "Tue, 29 Aug 2017 16:38:01 +0200", "Message-ID": "<150401748121.16384.7676807301169759129.stgit@firesoul>", "In-Reply-To": "<150401743083.16384.15778781741742858567.stgit@firesoul>", "References": "<150401743083.16384.15778781741742858567.stgit@firesoul>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 29 Aug 2017 14:38:03 +0000 (UTC)", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Creating as specific xdp_redirect_map variant of the xdp tracepoints\nallow users to write simpler/faster BPF progs that get attached to\nthese tracepoints.\n\nGoal is to still keep the tracepoints in xdp_redirect and xdp_redirect_map\nsimilar enough, that a tool can read the top part of the TP_STRUCT and\nproduce similar monitor statistics.\n\nSigned-off-by: Jesper Dangaard Brouer <brouer@redhat.com>\n---\n include/trace/events/xdp.h | 46 ++++++++++++++++++++++++++++++++++++--------\n net/core/filter.c | 4 ++--\n 2 files changed, 40 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h\nindex 1eebad55ebd4..862575ac8da9 100644\n--- a/include/trace/events/xdp.h\n+++ b/include/trace/events/xdp.h\n@@ -77,13 +77,11 @@ DECLARE_EVENT_CLASS(xdp_redirect_template,\n \t\t__entry->map_index\t= map_index;\n \t),\n \n-\tTP_printk(\"prog_id=%d action=%s ifindex=%d to_ifindex=%d err=%d\"\n-\t\t \" map_id=%d map_index=%d\",\n+\tTP_printk(\"prog_id=%d action=%s ifindex=%d to_ifindex=%d err=%d\",\n \t\t __entry->prog_id,\n \t\t __print_symbolic(__entry->act, __XDP_ACT_SYM_TAB),\n \t\t __entry->ifindex, __entry->to_ifindex,\n-\t\t __entry->err,\n-\t\t __entry->map_id, __entry->map_index)\n+\t\t __entry->err)\n );\n \n DEFINE_EVENT(xdp_redirect_template, xdp_redirect,\n@@ -108,11 +106,43 @@ DEFINE_EVENT(xdp_redirect_template, xdp_redirect_err,\n #define _trace_xdp_redirect_err(dev, xdp, to, err)\t\\\n \t trace_xdp_redirect_err(dev, xdp, to, err, NULL, 0);\n \n-#define trace_xdp_redirect_map(dev, xdp, fwd, map, idx)\t\\\n-\ttrace_xdp_redirect(dev, xdp, fwd ? fwd->ifindex : 0, 0, map, idx);\n+DEFINE_EVENT_PRINT(xdp_redirect_template, xdp_redirect_map,\n+\tTP_PROTO(const struct net_device *dev,\n+\t\t const struct bpf_prog *xdp,\n+\t\t int to_ifindex, int err,\n+\t\t const struct bpf_map *map, u32 map_index),\n+\tTP_ARGS(dev, xdp, to_ifindex, err, map, map_index),\n+\tTP_printk(\"prog_id=%d action=%s ifindex=%d to_ifindex=%d err=%d\"\n+\t\t \" map_id=%d map_index=%d\",\n+\t\t __entry->prog_id,\n+\t\t __print_symbolic(__entry->act, __XDP_ACT_SYM_TAB),\n+\t\t __entry->ifindex, __entry->to_ifindex,\n+\t\t __entry->err,\n+\t\t __entry->map_id, __entry->map_index)\n+);\n+\n+DEFINE_EVENT_PRINT(xdp_redirect_template, xdp_redirect_map_err,\n+\tTP_PROTO(const struct net_device *dev,\n+\t\t const struct bpf_prog *xdp,\n+\t\t int to_ifindex, int err,\n+\t\t const struct bpf_map *map, u32 map_index),\n+\tTP_ARGS(dev, xdp, to_ifindex, err, map, map_index),\n+\tTP_printk(\"prog_id=%d action=%s ifindex=%d to_ifindex=%d err=%d\"\n+\t\t \" map_id=%d map_index=%d\",\n+\t\t __entry->prog_id,\n+\t\t __print_symbolic(__entry->act, __XDP_ACT_SYM_TAB),\n+\t\t __entry->ifindex, __entry->to_ifindex,\n+\t\t __entry->err,\n+\t\t __entry->map_id, __entry->map_index)\n+);\n+\n+#define _trace_xdp_redirect_map(dev, xdp, fwd, map, idx)\t\t\\\n+\t trace_xdp_redirect_map(dev, xdp, fwd ? fwd->ifindex : 0,\t\\\n+\t\t\t\t0, map, idx);\n \n-#define trace_xdp_redirect_map_err(dev, xdp, fwd, map, idx, err)\t\\\n-\ttrace_xdp_redirect_err(dev, xdp, fwd ? fwd->ifindex : 0, err, map, idx);\n+#define _trace_xdp_redirect_map_err(dev, xdp, fwd, map, idx, err)\t\\\n+\t trace_xdp_redirect_map_err(dev, xdp, fwd ? fwd->ifindex : 0,\t\\\n+\t\t\t\t err, map, idx);\n \n #endif /* _TRACE_XDP_H */\n \ndiff --git a/net/core/filter.c b/net/core/filter.c\nindex 096e78de0b97..c6a37fe0285b 100644\n--- a/net/core/filter.c\n+++ b/net/core/filter.c\n@@ -2525,10 +2525,10 @@ static int xdp_do_redirect_map(struct net_device *dev, struct xdp_buff *xdp,\n \t\tgoto err;\n \n \tri->map_to_flush = map;\n-\ttrace_xdp_redirect_map(dev, xdp_prog, fwd, map, index);\n+\t_trace_xdp_redirect_map(dev, xdp_prog, fwd, map, index);\n \treturn 0;\n err:\n-\ttrace_xdp_redirect_map_err(dev, xdp_prog, fwd, map, index, err);\n+\t_trace_xdp_redirect_map_err(dev, xdp_prog, fwd, map, index, err);\n \treturn err;\n }\n \n", "prefixes": [ "net-next", "5/7" ] }