Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/807125/?format=api
{ "id": 807125, "url": "http://patchwork.ozlabs.org/api/patches/807125/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/150401747100.16384.15817946207152599341.stgit@firesoul/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<150401747100.16384.15817946207152599341.stgit@firesoul>", "list_archive_url": null, "date": "2017-08-29T14:37:51", "name": "[net-next,3/7] xdp: make xdp tracepoints report bpf prog id instead of prog_tag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a3e5cf4f17ff8211f042348818cb0cb789da142f", "submitter": { "id": 13625, "url": "http://patchwork.ozlabs.org/api/people/13625/?format=api", "name": "Jesper Dangaard Brouer", "email": "brouer@redhat.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/150401747100.16384.15817946207152599341.stgit@firesoul/mbox/", "series": [ { "id": 382, "url": "http://patchwork.ozlabs.org/api/series/382/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=382", "date": "2017-08-29T14:37:35", "name": "XDP redirect tracepoints", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/382/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/807125/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/807125/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=brouer@redhat.com" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhWT166pBz9s7f\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 30 Aug 2017 00:37:57 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932065AbdH2Oh4 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 10:37:56 -0400", "from mx1.redhat.com ([209.132.183.28]:57306 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752746AbdH2Ohz (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 29 Aug 2017 10:37:55 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D2B4BC047B81;\n\tTue, 29 Aug 2017 14:37:54 +0000 (UTC)", "from firesoul.localdomain (ovpn-200-32.brq.redhat.com\n\t[10.40.200.32])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DFDFD17574;\n\tTue, 29 Aug 2017 14:37:51 +0000 (UTC)", "from [192.168.5.1] (localhost [IPv6:::1])\n\tby firesoul.localdomain (Postfix) with ESMTP id 18C2030F12C9F;\n\tTue, 29 Aug 2017 16:37:51 +0200 (CEST)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com D2B4BC047B81", "Subject": "[PATCH net-next 3/7] xdp: make xdp tracepoints report bpf prog id\n\tinstead of prog_tag", "From": "Jesper Dangaard Brouer <brouer@redhat.com>", "To": "netdev@vger.kernel.org", "Cc": "John Fastabend <john.fastabend@gmail.com>,\n\tJesper Dangaard Brouer <brouer@redhat.com>", "Date": "Tue, 29 Aug 2017 16:37:51 +0200", "Message-ID": "<150401747100.16384.15817946207152599341.stgit@firesoul>", "In-Reply-To": "<150401743083.16384.15778781741742858567.stgit@firesoul>", "References": "<150401743083.16384.15778781741742858567.stgit@firesoul>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 29 Aug 2017 14:37:55 +0000 (UTC)", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Given previous patch expose the map_id, it seems natural to also\nreport the bpf prog id.\n\nSigned-off-by: Jesper Dangaard Brouer <brouer@redhat.com>\n---\n include/trace/events/xdp.h | 18 ++++++++----------\n 1 file changed, 8 insertions(+), 10 deletions(-)", "diff": "diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h\nindex 573dcfa1aeaa..89eba564e199 100644\n--- a/include/trace/events/xdp.h\n+++ b/include/trace/events/xdp.h\n@@ -31,20 +31,19 @@ TRACE_EVENT(xdp_exception,\n \tTP_ARGS(dev, xdp, act),\n \n \tTP_STRUCT__entry(\n-\t\t__array(u8, prog_tag, 8)\n+\t\t__field(int, prog_id)\n \t\t__field(u32, act)\n \t\t__field(int, ifindex)\n \t),\n \n \tTP_fast_assign(\n-\t\tBUILD_BUG_ON(sizeof(__entry->prog_tag) != sizeof(xdp->tag));\n-\t\tmemcpy(__entry->prog_tag, xdp->tag, sizeof(xdp->tag));\n+\t\t__entry->prog_id\t= xdp->aux->id;\n \t\t__entry->act\t\t= act;\n \t\t__entry->ifindex\t= dev->ifindex;\n \t),\n \n-\tTP_printk(\"prog=%s action=%s ifindex=%d\",\n-\t\t __print_hex_str(__entry->prog_tag, 8),\n+\tTP_printk(\"prog_id=%d action=%s ifindex=%d\",\n+\t\t __entry->prog_id,\n \t\t __print_symbolic(__entry->act, __XDP_ACT_SYM_TAB),\n \t\t __entry->ifindex)\n );\n@@ -59,7 +58,7 @@ DECLARE_EVENT_CLASS(xdp_redirect_template,\n \tTP_ARGS(dev, xdp, to_ifindex, err, map, map_index),\n \n \tTP_STRUCT__entry(\n-\t\t__array(u8, prog_tag, 8)\n+\t\t__field(int, prog_id)\n \t\t__field(u32, act)\n \t\t__field(int, ifindex)\n \t\t__field(int, err)\n@@ -69,8 +68,7 @@ DECLARE_EVENT_CLASS(xdp_redirect_template,\n \t),\n \n \tTP_fast_assign(\n-\t\tBUILD_BUG_ON(sizeof(__entry->prog_tag) != sizeof(xdp->tag));\n-\t\tmemcpy(__entry->prog_tag, xdp->tag, sizeof(xdp->tag));\n+\t\t__entry->prog_id\t= xdp->aux->id;\n \t\t__entry->act\t\t= XDP_REDIRECT;\n \t\t__entry->ifindex\t= dev->ifindex;\n \t\t__entry->err\t\t= err;\n@@ -79,9 +77,9 @@ DECLARE_EVENT_CLASS(xdp_redirect_template,\n \t\t__entry->map_index\t= map_index;\n \t),\n \n-\tTP_printk(\"prog=%s action=%s ifindex=%d to_ifindex=%d err=%d\"\n+\tTP_printk(\"prog_id=%d action=%s ifindex=%d to_ifindex=%d err=%d\"\n \t\t \" map_id=%d map_index=%d\",\n-\t\t __print_hex_str(__entry->prog_tag, 8),\n+\t\t __entry->prog_id,\n \t\t __print_symbolic(__entry->act, __XDP_ACT_SYM_TAB),\n \t\t __entry->ifindex, __entry->to_ifindex,\n \t\t __entry->err,\n", "prefixes": [ "net-next", "3/7" ] }