Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 807069,
    "url": "http://patchwork.ozlabs.org/api/patches/807069/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/150400963459.21371.7226405489572080523.stgit@warthog.procyon.org.uk/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<150400963459.21371.7226405489572080523.stgit@warthog.procyon.org.uk>",
    "list_archive_url": null,
    "date": "2017-08-29T12:27:14",
    "name": "[net-next,4/7] rxrpc: Don't negate call->error before returning it",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "32e1272e901bd478ddae20f3189730bae8e45569",
    "submitter": {
        "id": 59,
        "url": "http://patchwork.ozlabs.org/api/people/59/?format=api",
        "name": "David Howells",
        "email": "dhowells@redhat.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/150400963459.21371.7226405489572080523.stgit@warthog.procyon.org.uk/mbox/",
    "series": [
        {
            "id": 358,
            "url": "http://patchwork.ozlabs.org/api/series/358/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=358",
            "date": "2017-08-29T12:27:14",
            "name": "rxrpc: Miscellany",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/358/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/807069/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/807069/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": [
            "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
            "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com",
            "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dhowells@redhat.com"
        ],
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhSZR3VtNz9t2Q\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 22:27:27 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753907AbdH2M1S (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 08:27:18 -0400",
            "from mx1.redhat.com ([209.132.183.28]:41809 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751795AbdH2M1Q (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 29 Aug 2017 08:27:16 -0400",
            "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 09CAD81DF8;\n\tTue, 29 Aug 2017 12:27:16 +0000 (UTC)",
            "from warthog.procyon.org.uk (ovpn-120-50.rdu2.redhat.com\n\t[10.10.120.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 438937FB5B;\n\tTue, 29 Aug 2017 12:27:15 +0000 (UTC)"
        ],
        "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 09CAD81DF8",
        "Organization": "Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley\n\tPlace, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United\n\tKingdom.\n\tRegistered in England and Wales under Company Registration No.\n\t3798903",
        "Subject": "[PATCH net-next 4/7] rxrpc: Don't negate call->error before\n\treturning it",
        "From": "David Howells <dhowells@redhat.com>",
        "To": "netdev@vger.kernel.org",
        "Cc": "dhowells@redhat.com, linux-afs@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org",
        "Date": "Tue, 29 Aug 2017 13:27:14 +0100",
        "Message-ID": "<150400963459.21371.7226405489572080523.stgit@warthog.procyon.org.uk>",
        "In-Reply-To": "<150400960745.21371.15455867950162722742.stgit@warthog.procyon.org.uk>",
        "References": "<150400960745.21371.15455867950162722742.stgit@warthog.procyon.org.uk>",
        "User-Agent": "StGit/0.17.1-dirty",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "7bit",
        "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11",
        "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 29 Aug 2017 12:27:16 +0000 (UTC)",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "call->error is stored as 0 or a negative error code.  Don't negate this\nvalue (ie. make it positive) before returning it from a kernel function\n(though it should still be negated before passing to userspace through a\ncontrol message).\n\nSigned-off-by: David Howells <dhowells@redhat.com>\n---\n\n net/rxrpc/sendmsg.c |    8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/net/rxrpc/sendmsg.c b/net/rxrpc/sendmsg.c\nindex b0d2cda6ec0a..bc7f0241d92b 100644\n--- a/net/rxrpc/sendmsg.c\n+++ b/net/rxrpc/sendmsg.c\n@@ -61,7 +61,7 @@ static int rxrpc_wait_for_tx_window(struct rxrpc_sock *rx,\n \t\t\t  call->cong_cwnd + call->cong_extra))\n \t\t\tbreak;\n \t\tif (call->state >= RXRPC_CALL_COMPLETE) {\n-\t\t\tret = -call->error;\n+\t\t\tret = call->error;\n \t\t\tbreak;\n \t\t}\n \t\tif (signal_pending(current)) {\n@@ -364,8 +364,8 @@ static int rxrpc_send_data(struct rxrpc_sock *rx,\n \n call_terminated:\n \trxrpc_free_skb(skb, rxrpc_skb_tx_freed);\n-\t_leave(\" = %d\", -call->error);\n-\treturn -call->error;\n+\t_leave(\" = %d\", call->error);\n+\treturn call->error;\n \n maybe_error:\n \tif (copied)\n@@ -660,7 +660,7 @@ int rxrpc_kernel_send_data(struct socket *sock, struct rxrpc_call *call,\n \t\tbreak;\n \tcase RXRPC_CALL_COMPLETE:\n \t\tread_lock_bh(&call->state_lock);\n-\t\tret = -call->error;\n+\t\tret = call->error;\n \t\tread_unlock_bh(&call->state_lock);\n \t\tbreak;\n \tdefault:\n",
    "prefixes": [
        "net-next",
        "4/7"
    ]
}