Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806935/?format=api
{ "id": 806935, "url": "http://patchwork.ozlabs.org/api/patches/806935/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>", "list_archive_url": null, "date": "2017-08-29T04:22:48", "name": "[net-next,v2] bridge: fdb add and delete tracepoints", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "87bfc8fff6b1fe308666692bed1d66e237788daf", "submitter": { "id": 23500, "url": "http://patchwork.ozlabs.org/api/people/23500/?format=api", "name": "Roopa Prabhu", "email": "roopa@cumulusnetworks.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com/mbox/", "series": [ { "id": 298, "url": "http://patchwork.ozlabs.org/api/series/298/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=298", "date": "2017-08-29T04:22:48", "name": "[net-next,v2] bridge: fdb add and delete tracepoints", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/298/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806935/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806935/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"WKd1kW0n\"; \n\tdkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhFqf2swfz9t2x\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 29 Aug 2017 14:23:10 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751263AbdH2EWz (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 29 Aug 2017 00:22:55 -0400", "from mail-pg0-f49.google.com ([74.125.83.49]:33436 \"EHLO\n\tmail-pg0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750796AbdH2EWx (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 29 Aug 2017 00:22:53 -0400", "by mail-pg0-f49.google.com with SMTP id t3so7501825pgt.0\n\tfor <netdev@vger.kernel.org>; Mon, 28 Aug 2017 21:22:53 -0700 (PDT)", "from monster-08.mvlab.cumulusnetworks.com.\n\t(fw.cumulusnetworks.com. [216.129.126.126])\n\tby smtp.googlemail.com with ESMTPSA id\n\tg68sm3234810pfj.33.2017.08.28.21.22.51\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 28 Aug 2017 21:22:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=from:to:cc:subject:date:message-id;\n\tbh=KaFf49pXn8K1d9xy7nOOWMeN24IWf5X7vZwhp29Fvh0=;\n\tb=WKd1kW0nvKhtzBBz0l0iMDrV9qTL2G/9nkYk9JNopKn7zwUp5xE0iwdUu2Xnh3ti2x\n\tDt+kBWxLqeOUQzbLsBqe2EJDGcof9zwCVhvdiadNTYQrqXvklpGf1hxUrTdohAcUIzq4\n\txOPol/JlpYFA85p1kjGVStnQtVL9W+1zq4hzQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=KaFf49pXn8K1d9xy7nOOWMeN24IWf5X7vZwhp29Fvh0=;\n\tb=oJz9wBYPORIeYurpl2+3rhBXmUIT5LnfztFDUWJwtzqwxz3PkLKYy1MB2XGv4otk1+\n\twNcprb2EQ3tOADEx8Zuh8nfO7W9+1VIzzUlwJFb/vP3OcuawfAHAQZPxDcJCWrudX9yp\n\tMZDF7HTtLlrYOL8z0jse+WBP6d6X9tDhX5WdU3wcRUxnK5/0kODNtlcU1CrLzQHKvEtF\n\ts7ksuk6zArZ8/Jbn5fdawmw4g1zEQ4pD4bke2ZCR9JgFGZR+IRzjkorcXmvmWj+yNF+3\n\tF7nRE3jU6TxUT5XST2iw9RN0ja6AoVH8R+b3Nw6jof4rcwwl2aCidrlEltg5K+rS2qoP\n\t7F5g==", "X-Gm-Message-State": "AHYfb5gq42iplcm+2Y3wJ0u5bs93NgA0YR15vgqNLStjT1imF11umfZb\n\tMyUxdFQsaxSZz4oHW1o=", "X-Received": "by 10.84.194.228 with SMTP id h91mr3362725pld.397.1503980572856; \n\tMon, 28 Aug 2017 21:22:52 -0700 (PDT)", "From": "Roopa Prabhu <roopa@cumulusnetworks.com>", "X-Google-Original-From": "Roopa Prabhu", "To": "davem@davemloft.net", "Cc": "netdev@vger.kernel.org, nikolay@cumulusnetworks.com,\n\tf.fainelli@gmail.com, bridge@lists.linux-foundation.org", "Subject": "[PATCH net-next v2] bridge: fdb add and delete tracepoints", "Date": "Mon, 28 Aug 2017 21:22:48 -0700", "Message-Id": "<1503980568-35240-1-git-send-email-roopa@cumulusnetworks.com>", "X-Mailer": "git-send-email 2.1.4", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Roopa Prabhu <roopa@cumulusnetworks.com>\n\nA few useful tracepoints to trace bridge forwarding\ndatabase updates.\n\nSigned-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>\n---\nv2 - address comments from Florian\n\n include/trace/events/bridge.h | 98 +++++++++++++++++++++++++++++++++++++++++\n net/bridge/br_fdb.c | 7 +++\n net/core/net-traces.c | 6 +++\n 3 files changed, 111 insertions(+)\n create mode 100644 include/trace/events/bridge.h", "diff": "diff --git a/include/trace/events/bridge.h b/include/trace/events/bridge.h\nnew file mode 100644\nindex 0000000..3a4ecc3\n--- /dev/null\n+++ b/include/trace/events/bridge.h\n@@ -0,0 +1,98 @@\n+#undef TRACE_SYSTEM\n+#define TRACE_SYSTEM bridge\n+\n+#if !defined(_TRACE_BRIDGE_H) || defined(TRACE_HEADER_MULTI_READ)\n+#define _TRACE_BRIDGE_H\n+\n+#include <linux/netdevice.h>\n+#include <linux/tracepoint.h>\n+\n+#include \"../../../net/bridge/br_private.h\"\n+\n+TRACE_EVENT(br_fdb_add,\n+\n+\tTP_PROTO(struct ndmsg *ndm, struct net_device *dev,\n+\t\t const unsigned char *addr, u16 vid, u16 nlh_flags),\n+\n+\tTP_ARGS(ndm, dev, addr, vid, nlh_flags),\n+\n+\tTP_STRUCT__entry(\n+\t\t__field(u8, ndm_flags)\n+\t\t__string(dev, dev->name)\n+\t\t__array(unsigned char, addr, ETH_ALEN)\n+\t\t__field(u16, vid)\n+\t\t__field(u16, nlh_flags)\n+\t),\n+\n+\tTP_fast_assign(\n+\t\t__assign_str(dev, dev->name);\n+\t\tmemcpy(__entry->addr, addr, ETH_ALEN);\n+\t\t__entry->vid = vid;\n+\t\t__entry->nlh_flags = nlh_flags;\n+\t\t__entry->ndm_flags = ndm->ndm_flags;\n+\t),\n+\n+\tTP_printk(\"dev %s addr %02x:%02x:%02x:%02x:%02x:%02x vid %u nlh_flags %04x ndm_flags = %02x\",\n+\t\t __get_str(dev), __entry->addr[0], __entry->addr[1],\n+\t\t __entry->addr[2], __entry->addr[3], __entry->addr[4],\n+\t\t __entry->addr[5], __entry->vid,\n+\t\t __entry->nlh_flags, __entry->ndm_flags)\n+);\n+\n+TRACE_EVENT(br_fdb_external_learn_add,\n+\n+\tTP_PROTO(struct net_bridge *br, struct net_bridge_port *p,\n+\t\t const unsigned char *addr, u16 vid),\n+\n+\tTP_ARGS(br, p, addr, vid),\n+\n+\tTP_STRUCT__entry(\n+\t\t__string(br_dev, br->dev->name)\n+\t\t__string(dev, p->dev->name)\n+\t\t__array(unsigned char, addr, ETH_ALEN)\n+\t\t__field(u16, vid)\n+\t),\n+\n+\tTP_fast_assign(\n+\t\t__assign_str(br_dev, br ? br->dev->name : \"null\");\n+\t\t__assign_str(dev, p ? p->dev->name : \"null\");\n+\t\tmemcpy(__entry->addr, addr, ETH_ALEN);\n+\t\t__entry->vid = vid;\n+\t),\n+\n+\tTP_printk(\"br_dev %s port %s addr %02x:%02x:%02x:%02x:%02x:%02x vid %u\",\n+\t\t __get_str(br_dev), __get_str(dev), __entry->addr[0],\n+\t\t __entry->addr[1], __entry->addr[2], __entry->addr[3],\n+\t\t __entry->addr[4], __entry->addr[5], __entry->vid)\n+);\n+\n+TRACE_EVENT(fdb_delete,\n+\n+\tTP_PROTO(struct net_bridge *br, struct net_bridge_fdb_entry *f),\n+\n+\tTP_ARGS(br, f),\n+\n+\tTP_STRUCT__entry(\n+\t\t__string(br_dev, br->dev->name)\n+\t\t__string(dev, f->dst ? f->dst->dev->name : \"null\")\n+\t\t__array(unsigned char, addr, ETH_ALEN)\n+\t\t__field(u16, vid)\n+\t),\n+\n+\tTP_fast_assign(\n+\t\t__assign_str(br_dev, br ? br->dev->name : \"null\");\n+\t\t__assign_str(dev, f->dst ? f->dst->dev->name : \"null\");\n+\t\tmemcpy(__entry->addr, f->addr.addr, ETH_ALEN);\n+\t\t__entry->vid = f->vlan_id;\n+\t),\n+\n+\tTP_printk(\"br_dev %s dev %s addr %02x:%02x:%02x:%02x:%02x:%02x vid %u\",\n+\t\t __get_str(br_dev), __get_str(dev), __entry->addr[0],\n+\t\t __entry->addr[1], __entry->addr[2], __entry->addr[3],\n+\t\t __entry->addr[4], __entry->addr[5], __entry->vid)\n+);\n+\n+#endif /* _TRACE_BRIDGE_H */\n+\n+/* This part must be outside protection */\n+#include <trace/define_trace.h>\ndiff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c\nindex a79b648..be5e1da 100644\n--- a/net/bridge/br_fdb.c\n+++ b/net/bridge/br_fdb.c\n@@ -25,6 +25,7 @@\n #include <asm/unaligned.h>\n #include <linux/if_vlan.h>\n #include <net/switchdev.h>\n+#include <trace/events/bridge.h>\n #include \"br_private.h\"\n \n static struct kmem_cache *br_fdb_cache __read_mostly;\n@@ -171,6 +172,8 @@ static void fdb_del_hw_addr(struct net_bridge *br, const unsigned char *addr)\n \n static void fdb_delete(struct net_bridge *br, struct net_bridge_fdb_entry *f)\n {\n+\ttrace_fdb_delete(br, f);\n+\n \tif (f->is_static)\n \t\tfdb_del_hw_addr(br, f->addr.addr);\n \n@@ -870,6 +873,8 @@ int br_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],\n \tstruct net_bridge *br = NULL;\n \tint err = 0;\n \n+\ttrace_br_fdb_add(ndm, dev, addr, vid, nlh_flags);\n+\n \tif (!(ndm->ndm_state & (NUD_PERMANENT|NUD_NOARP|NUD_REACHABLE))) {\n \t\tpr_info(\"bridge: RTM_NEWNEIGH with invalid state %#x\\n\", ndm->ndm_state);\n \t\treturn -EINVAL;\n@@ -1066,6 +1071,8 @@ int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,\n \tbool modified = false;\n \tint err = 0;\n \n+\ttrace_br_fdb_external_learn_add(br, p, addr, vid);\n+\n \tspin_lock_bh(&br->hash_lock);\n \n \thead = &br->hash[br_mac_hash(addr, vid)];\ndiff --git a/net/core/net-traces.c b/net/core/net-traces.c\nindex 4f1468c..4a0292c 100644\n--- a/net/core/net-traces.c\n+++ b/net/core/net-traces.c\n@@ -37,6 +37,12 @@\n #include <trace/events/fib6.h>\n EXPORT_TRACEPOINT_SYMBOL_GPL(fib6_table_lookup);\n #endif\n+#if IS_ENABLED(CONFIG_BRIDGE)\n+#include <trace/events/bridge.h>\n+EXPORT_TRACEPOINT_SYMBOL_GPL(br_fdb_add);\n+EXPORT_TRACEPOINT_SYMBOL_GPL(br_fdb_external_learn_add);\n+EXPORT_TRACEPOINT_SYMBOL_GPL(fdb_delete);\n+#endif\n \n EXPORT_TRACEPOINT_SYMBOL_GPL(kfree_skb);\n \n", "prefixes": [ "net-next", "v2" ] }