Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806889/?format=api
{ "id": 806889, "url": "http://patchwork.ozlabs.org/api/patches/806889/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-75-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-75-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:14:49", "name": "[74/79] qemu-iotests: Test automatic commit job cancel on hot unplug", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "62db1ad6819057aff94978671f7e663c53b78f21", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-75-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806889/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh9bs2C4Tz9sP5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 11:12:41 +1000 (AEST)", "from localhost ([::1]:42206 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmV55-00014b-3P\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 21:12:39 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:49027)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCv-0001s8-TO\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:45 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCu-0006K8-4q\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:41 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42917\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUCt-0006Jg-V5\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:40 -0400", "from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0EAbU019556\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:39 -0400", "from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmsfn2wwu-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:39 -0400", "from localhost\n\tby e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 18:16:38 -0600", "from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:16:35 -0600", "from b03ledav001.gho.boulder.ibm.com\n\t(b03ledav001.gho.boulder.ibm.com [9.17.130.232])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7T0GZii4456708; Mon, 28 Aug 2017 17:16:35 -0700", "from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 13AB46E038;\n\tMon, 28 Aug 2017 18:16:35 -0600 (MDT)", "from localhost (unknown [9.80.85.217])\n\tby b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id D56996E035;\n\tMon, 28 Aug 2017 18:16:34 -0600 (MDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:14:49 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-0028-0000-0000-00000846DB56", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:37", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-0029-0000-0000-00003755319A", "Message-Id": "<1503965694-10794-75-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.158.5", "Subject": "[Qemu-devel] [PATCH 74/79] qemu-iotests: Test automatic commit job\n\tcancel on hot unplug", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Kevin Wolf <kwolf@redhat.com>, qemu-stable@nongnu.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Kevin Wolf <kwolf@redhat.com>\n\nSigned-off-by: Kevin Wolf <kwolf@redhat.com>\nReviewed-by: John Snow <jsnow@redhat.com>\n(cherry picked from commit c3971b883a596abc6af45f53d2f43fb2f59ccd3b)\n*prereq for d3c8c674\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n tests/qemu-iotests/040 | 35 +++++++++++++++++++++++++++++++++--\n tests/qemu-iotests/040.out | 4 ++--\n 2 files changed, 35 insertions(+), 4 deletions(-)", "diff": "diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040\nindex 5bdaf3d..9d381d9 100755\n--- a/tests/qemu-iotests/040\n+++ b/tests/qemu-iotests/040\n@@ -70,7 +70,9 @@ class ImageCommitTestCase(iotests.QMPTestCase):\n self.wait_for_complete()\n \n class TestSingleDrive(ImageCommitTestCase):\n- image_len = 1 * 1024 * 1024\n+ # Need some space after the copied data so that throttling is effective in\n+ # tests that use it rather than just completing the job immediately\n+ image_len = 2 * 1024 * 1024\n test_len = 1 * 1024 * 256\n \n def setUp(self):\n@@ -79,7 +81,9 @@ class TestSingleDrive(ImageCommitTestCase):\n qemu_img('create', '-f', iotests.imgfmt, '-o', 'backing_file=%s' % mid_img, test_img)\n qemu_io('-f', 'raw', '-c', 'write -P 0xab 0 524288', backing_img)\n qemu_io('-f', iotests.imgfmt, '-c', 'write -P 0xef 524288 524288', mid_img)\n- self.vm = iotests.VM().add_drive(test_img)\n+ self.vm = iotests.VM().add_drive(test_img, interface=\"none\")\n+ self.vm.add_device(\"virtio-scsi-pci\")\n+ self.vm.add_device(\"scsi-hd,id=scsi0,drive=drive0\")\n self.vm.launch()\n \n def tearDown(self):\n@@ -131,6 +135,33 @@ class TestSingleDrive(ImageCommitTestCase):\n self.assert_qmp(result, 'error/class', 'GenericError')\n self.assert_qmp(result, 'error/desc', 'Base \\'%s\\' not found' % mid_img)\n \n+ # When the job is running on a BB that is automatically deleted on hot\n+ # unplug, the job is cancelled when the device disappears\n+ def test_hot_unplug(self):\n+ if self.image_len == 0:\n+ return\n+\n+ self.assert_no_active_block_jobs()\n+ result = self.vm.qmp('block-commit', device='drive0', top=mid_img,\n+ base=backing_img, speed=(self.image_len / 4))\n+ self.assert_qmp(result, 'return', {})\n+ result = self.vm.qmp('device_del', id='scsi0')\n+ self.assert_qmp(result, 'return', {})\n+\n+ cancelled = False\n+ deleted = False\n+ while not cancelled or not deleted:\n+ for event in self.vm.get_qmp_events(wait=True):\n+ if event['event'] == 'DEVICE_DELETED':\n+ self.assert_qmp(event, 'data/device', 'scsi0')\n+ deleted = True\n+ elif event['event'] == 'BLOCK_JOB_CANCELLED':\n+ self.assert_qmp(event, 'data/device', 'drive0')\n+ cancelled = True\n+ else:\n+ self.fail(\"Unexpected event %s\" % (event['event']))\n+\n+ self.assert_no_active_block_jobs()\n \n class TestRelativePaths(ImageCommitTestCase):\n image_len = 1 * 1024 * 1024\ndiff --git a/tests/qemu-iotests/040.out b/tests/qemu-iotests/040.out\nindex 4fd1c2d..6d9bee1 100644\n--- a/tests/qemu-iotests/040.out\n+++ b/tests/qemu-iotests/040.out\n@@ -1,5 +1,5 @@\n-.........................\n+...........................\n ----------------------------------------------------------------------\n-Ran 25 tests\n+Ran 27 tests\n \n OK\n", "prefixes": [ "74/79" ] }