Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806872/?format=api
{ "id": 806872, "url": "http://patchwork.ozlabs.org/api/patches/806872/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-65-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-65-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:14:39", "name": "[64/79] block: Do not strcmp() with NULL uri->scheme", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9bbce6cb5998df0e6b0890245c9a177a4db80751", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-65-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806872/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806872/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh9MK03jPz9s7h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 11:01:49 +1000 (AEST)", "from localhost ([::1]:42145 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUuY-00089Y-RW\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 21:01:46 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:48765)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCn-0001fP-SJ\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:37 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCk-000644-Lc\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:33 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38913\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUCk-00062v-Ev\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:30 -0400", "from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0EWxq065758\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:30 -0400", "from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmq0jb031-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:29 -0400", "from localhost\n\tby e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 20:16:29 -0400", "from b01cxnp23034.gho.pok.ibm.com (9.57.198.29)\n\tby e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 20:16:27 -0400", "from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7T0GQ8v24903800; Tue, 29 Aug 2017 00:16:26 GMT", "from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 6DB34AE04E;\n\tMon, 28 Aug 2017 20:16:50 -0400 (EDT)", "from localhost (unknown [9.80.85.217])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id 3B59EAE03C;\n\tMon, 28 Aug 2017 20:16:50 -0400 (EDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:14:39 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-0024-0000-0000-000002C6D2D1", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:28", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-0025-0000-0000-0000453E636E", "Message-Id": "<1503965694-10794-65-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.158.5", "Subject": "[Qemu-devel] [PATCH 64/79] block: Do not strcmp() with NULL\n\turi->scheme", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-stable@nongnu.org, Max Reitz <mreitz@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Max Reitz <mreitz@redhat.com>\n\nuri_parse(...)->scheme may be NULL. In fact, probably every field may be\nNULL, and the callers do test this for all of the other fields but not\nfor scheme (except for block/gluster.c; block/vxhs.c does not access\nthat field at all).\n\nWe can easily fix this by using g_strcmp0() instead of strcmp().\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Max Reitz <mreitz@redhat.com>\nMessage-id: 20170613205726.13544-1-mreitz@redhat.com\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\nSigned-off-by: Max Reitz <mreitz@redhat.com>\n(cherry picked from commit f69165a8feca055cf4a37d13ab0fc5beec3cb372)\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n block/nbd.c | 6 +++---\n block/nfs.c | 2 +-\n block/sheepdog.c | 6 +++---\n block/ssh.c | 2 +-\n 4 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/block/nbd.c b/block/nbd.c\nindex b3545f5..9a54edf 100644\n--- a/block/nbd.c\n+++ b/block/nbd.c\n@@ -65,11 +65,11 @@ static int nbd_parse_uri(const char *filename, QDict *options)\n }\n \n /* transport */\n- if (!strcmp(uri->scheme, \"nbd\")) {\n+ if (!g_strcmp0(uri->scheme, \"nbd\")) {\n is_unix = false;\n- } else if (!strcmp(uri->scheme, \"nbd+tcp\")) {\n+ } else if (!g_strcmp0(uri->scheme, \"nbd+tcp\")) {\n is_unix = false;\n- } else if (!strcmp(uri->scheme, \"nbd+unix\")) {\n+ } else if (!g_strcmp0(uri->scheme, \"nbd+unix\")) {\n is_unix = true;\n } else {\n ret = -EINVAL;\ndiff --git a/block/nfs.c b/block/nfs.c\nindex bfeebc1..344186f 100644\n--- a/block/nfs.c\n+++ b/block/nfs.c\n@@ -83,7 +83,7 @@ static int nfs_parse_uri(const char *filename, QDict *options, Error **errp)\n error_setg(errp, \"Invalid URI specified\");\n goto out;\n }\n- if (strcmp(uri->scheme, \"nfs\") != 0) {\n+ if (g_strcmp0(uri->scheme, \"nfs\") != 0) {\n error_setg(errp, \"URI scheme must be 'nfs'\");\n goto out;\n }\ndiff --git a/block/sheepdog.c b/block/sheepdog.c\nindex fb9203e..2d8d8c8 100644\n--- a/block/sheepdog.c\n+++ b/block/sheepdog.c\n@@ -1052,11 +1052,11 @@ static void sd_parse_uri(SheepdogConfig *cfg, const char *filename,\n }\n \n /* transport */\n- if (!strcmp(uri->scheme, \"sheepdog\")) {\n+ if (!g_strcmp0(uri->scheme, \"sheepdog\")) {\n is_unix = false;\n- } else if (!strcmp(uri->scheme, \"sheepdog+tcp\")) {\n+ } else if (!g_strcmp0(uri->scheme, \"sheepdog+tcp\")) {\n is_unix = false;\n- } else if (!strcmp(uri->scheme, \"sheepdog+unix\")) {\n+ } else if (!g_strcmp0(uri->scheme, \"sheepdog+unix\")) {\n is_unix = true;\n } else {\n error_setg(&err, \"URI scheme must be 'sheepdog', 'sheepdog+tcp',\"\ndiff --git a/block/ssh.c b/block/ssh.c\nindex 34a2f79..139b05d 100644\n--- a/block/ssh.c\n+++ b/block/ssh.c\n@@ -205,7 +205,7 @@ static int parse_uri(const char *filename, QDict *options, Error **errp)\n return -EINVAL;\n }\n \n- if (strcmp(uri->scheme, \"ssh\") != 0) {\n+ if (g_strcmp0(uri->scheme, \"ssh\") != 0) {\n error_setg(errp, \"URI scheme must be 'ssh'\");\n goto err;\n }\n", "prefixes": [ "64/79" ] }