Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806863/?format=api
{ "id": 806863, "url": "http://patchwork.ozlabs.org/api/patches/806863/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-57-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-57-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:14:31", "name": "[56/79] target/xtensa: handle unknown registers in gdbstub", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d26c14313e3f6577cc72ce3076a7338bc7e757ad", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-57-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806863/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh9CB52GZz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 10:54:46 +1000 (AEST)", "from localhost ([::1]:42098 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUnk-0001h1-Ey\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:54:44 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:48523)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCh-0001YO-Aq\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:31 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCe-0005oO-2M\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:27 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39029)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUCd-0005mC-Mf\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:23 -0400", "from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0E70K090091\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:22 -0400", "from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmvyehksk-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:22 -0400", "from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 18:16:21 -0600", "from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:16:20 -0600", "from b03ledav001.gho.boulder.ibm.com\n\t(b03ledav001.gho.boulder.ibm.com [9.17.130.232])\n\tby b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7T0GJsq63438938; Mon, 28 Aug 2017 17:16:19 -0700", "from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A2EC36E045;\n\tMon, 28 Aug 2017 18:16:19 -0600 (MDT)", "from localhost (unknown [9.80.85.217])\n\tby b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id 7A5FA6E041;\n\tMon, 28 Aug 2017 18:16:19 -0600 (MDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:14:31 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-0020-0000-0000-00000CA0E9D9", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:21", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-0021-0000-0000-00005DE891D5", "Message-Id": "<1503965694-10794-57-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.156.1", "Subject": "[Qemu-devel] [PATCH 56/79] target/xtensa: handle unknown registers\n\tin gdbstub", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Max Filippov <jcmvbkbc@gmail.com>, qemu-stable@nongnu.org", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Max Filippov <jcmvbkbc@gmail.com>\n\nXtensa cores may have registers of types/sizes not supported by the\ngdbstub accessors. Ignore writes to such registers and return zero on\nread, but always return correct register size, so that gdb on the other\nside is able to access all registers in the packet holding unsupported\nregisters in the middle. This fixes gdb interaction with cores that have\nvector/custom TIE registers.\n\nCc: qemu-stable@nongnu.org\nSigned-off-by: Max Filippov <jcmvbkbc@gmail.com>\n(cherry picked from commit dd7b952b793e341c905355581a21cdbaa8b13c31)\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n target/xtensa/gdbstub.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/target/xtensa/gdbstub.c b/target/xtensa/gdbstub.c\nindex fa5469a..da131ae 100644\n--- a/target/xtensa/gdbstub.c\n+++ b/target/xtensa/gdbstub.c\n@@ -58,7 +58,10 @@ int xtensa_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)\n case 8:\n return gdb_get_reg64(mem_buf, float64_val(env->fregs[i].f64));\n default:\n- return 0;\n+ qemu_log_mask(LOG_UNIMP, \"%s from reg %d of unsupported size %d\\n\",\n+ __func__, n, reg->size);\n+ memset(mem_buf, 0, reg->size);\n+ return reg->size;\n }\n \n case 8: /*a*/\n@@ -67,6 +70,8 @@ int xtensa_cpu_gdb_read_register(CPUState *cs, uint8_t *mem_buf, int n)\n default:\n qemu_log_mask(LOG_UNIMP, \"%s from reg %d of unsupported type %d\\n\",\n __func__, n, reg->type);\n+ memset(mem_buf, 0, reg->size);\n+ return reg->size;\n return 0;\n }\n }\n@@ -111,7 +116,9 @@ int xtensa_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n env->fregs[reg->targno & 0x0f].f64 = make_float64(tmp);\n return 8;\n default:\n- return 0;\n+ qemu_log_mask(LOG_UNIMP, \"%s to reg %d of unsupported size %d\\n\",\n+ __func__, n, reg->size);\n+ return reg->size;\n }\n \n case 8: /*a*/\n@@ -121,7 +128,7 @@ int xtensa_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)\n default:\n qemu_log_mask(LOG_UNIMP, \"%s to reg %d of unsupported type %d\\n\",\n __func__, n, reg->type);\n- return 0;\n+ return reg->size;\n }\n \n return 4;\n", "prefixes": [ "56/79" ] }