Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806851/?format=api
{ "id": 806851, "url": "http://patchwork.ozlabs.org/api/patches/806851/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-5-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-5-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:13:39", "name": "[04/79] qemu-img/convert: Use @opts for one thing only", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a04df8143738ab24d6058f8bc9aa0ec8a5e6f57b", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-5-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806851/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806851/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh90W0Z0pz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 10:45:31 +1000 (AEST)", "from localhost ([::1]:42044 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUem-00023U-Uv\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:45:28 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:48422)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCe-0001Ul-MW\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:28 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCb-0005kg-Fw\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:24 -0400", "from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34977)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUCb-0005jC-6o\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:21 -0400", "from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0F3Fr052211\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:20 -0400", "from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cmwga06ku-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:20 -0400", "from localhost\n\tby e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 20:16:18 -0400", "from b01cxnp23033.gho.pok.ibm.com (9.57.198.28)\n\tby e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 20:16:16 -0400", "from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com\n\t[9.57.199.106])\n\tby b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v7T0GFar55116004; Tue, 29 Aug 2017 00:16:15 GMT", "from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 1991928046;\n\tMon, 28 Aug 2017 20:16:09 -0400 (EDT)", "from localhost (unknown [9.80.85.217])\n\tby b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP id D6C6D2804A;\n\tMon, 28 Aug 2017 20:16:08 -0400 (EDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:13:39 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-0052-0000-0000-000002573367", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:17", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-0053-0000-0000-000051D1D987", "Message-Id": "<1503965694-10794-5-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.156.1", "Subject": "[Qemu-devel] [PATCH 04/79] qemu-img/convert: Use @opts for one\n\tthing only", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "qemu-stable@nongnu.org, Max Reitz <mreitz@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Max Reitz <mreitz@redhat.com>\n\nAfter storing the creation options for the new image into @opts, we\nfetch some things for our own information, like the backing file name,\nor whether to use encryption or preallocation.\n\nWith the -n parameter, there will not be any creation options; this is\nnot too bad because this just means that querying a NULL @opts will\nalways return the default value.\n\nHowever, we also use @opts for the --object options. Therefore, @opts is\nnot necessarily NULL if -n was specified; instead, it may contain those\noptions. In practice, this probably does not cause any problems because\nthere most likely is no object that supports any of the parameters we\nquery here, but this is neither something we should rely on nor does\nthis variable reuse make the code very nice to read.\n\nTherefore, just use an own variable for the --object options.\n\nCc: qemu-stable <qemu-stable@nongnu.org>\nSigned-off-by: Max Reitz <mreitz@redhat.com>\nReviewed-by: Eric Blake <eblake@redhat.com>\n* applied patch from v1 of series as suggested by author\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n qemu-img.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/qemu-img.c b/qemu-img.c\nindex 9aa7823..cfc3bc3 100644\n--- a/qemu-img.c\n+++ b/qemu-img.c\n@@ -2065,14 +2065,16 @@ static int img_convert(int argc, char **argv)\n case 'W':\n wr_in_order = false;\n break;\n- case OPTION_OBJECT:\n- opts = qemu_opts_parse_noisily(&qemu_object_opts,\n- optarg, true);\n- if (!opts) {\n+ case OPTION_OBJECT: {\n+ QemuOpts *object_opts;\n+ object_opts = qemu_opts_parse_noisily(&qemu_object_opts,\n+ optarg, true);\n+ if (!object_opts) {\n ret = -1;\n goto fail_getopt;\n }\n break;\n+ }\n case OPTION_IMAGE_OPTS:\n image_opts = true;\n break;\n", "prefixes": [ "04/79" ] }