Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/806849/?format=api
{ "id": 806849, "url": "http://patchwork.ozlabs.org/api/patches/806849/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-51-git-send-email-mdroth@linux.vnet.ibm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1503965694-10794-51-git-send-email-mdroth@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2017-08-29T00:14:25", "name": "[50/79] monitor: fix object_del for command-line-created objects", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e54a78d157081054bd05945a97c1c736cbb61a8d", "submitter": { "id": 5549, "url": "http://patchwork.ozlabs.org/api/people/5549/?format=api", "name": "Michael Roth", "email": "mdroth@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1503965694-10794-51-git-send-email-mdroth@linux.vnet.ibm.com/mbox/", "series": [ { "id": 281, "url": "http://patchwork.ozlabs.org/api/series/281/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=281", "date": "2017-08-29T00:13:45", "name": "Patch Round-up for stable 2.9.1, freeze on 2017-09-04", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/281/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/806849/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/806849/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xh8zR0qvQz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 29 Aug 2017 10:44:35 +1000 (AEST)", "from localhost ([::1]:42039 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dmUdt-0001Il-0m\n\tfor incoming@patchwork.ozlabs.org; Mon, 28 Aug 2017 20:44:33 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:48367)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCc-0001Sx-Tu\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:26 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <mdroth@linux.vnet.ibm.com>) id 1dmUCZ-0005hh-P7\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:22 -0400", "from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55491\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <mdroth@linux.vnet.ibm.com>)\n\tid 1dmUCZ-0005h1-K6\n\tfor qemu-devel@nongnu.org; Mon, 28 Aug 2017 20:16:19 -0400", "from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv7T0EUPM087789\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:19 -0400", "from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cmvhgar8s-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Mon, 28 Aug 2017 20:16:18 -0400", "from localhost\n\tby e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;\n\tMon, 28 Aug 2017 18:16:18 -0600", "from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 28 Aug 2017 18:16:15 -0600", "from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v7T0GFBE31391998; Mon, 28 Aug 2017 17:16:15 -0700", "from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id E8167C603C;\n\tMon, 28 Aug 2017 18:16:14 -0600 (MDT)", "from localhost (unknown [9.80.85.217])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id B49B6C603E;\n\tMon, 28 Aug 2017 18:16:14 -0600 (MDT)" ], "From": "Michael Roth <mdroth@linux.vnet.ibm.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 28 Aug 2017 19:14:25 -0500", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "References": "<1503965694-10794-1-git-send-email-mdroth@linux.vnet.ibm.com>", "X-TM-AS-GCONF": "00", "x-cbid": "17082900-0016-0000-0000-0000076EE821", "X-IBM-SpamModules-Scores": "", "X-IBM-SpamModules-Versions": "BY=3.00007630; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00909028; UDB=6.00455849;\n\tIPR=6.00689279; \n\tBA=6.00005557; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016909;\n\tXFM=3.00000015; UTC=2017-08-29 00:16:17", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "17082900-0017-0000-0000-00003B3F1B2F", "Message-Id": "<1503965694-10794-51-git-send-email-mdroth@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-28_13:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1708290001", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]", "X-Received-From": "148.163.158.5", "Subject": "[Qemu-devel] [PATCH 50/79] monitor: fix object_del for\n\tcommand-line-created objects", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Markus Armbruster <armbru@redhat.com>, qemu-stable@nongnu.org,\n\t\"Dr. David Alan Gilbert\" <dgilbert@redhat.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Currently objects specified on the command-line are only partially\ncleaned up when 'object_del' is issued in either HMP or QMP: the\nobject itself is fully finalized, but the QemuOpts are not removed.\nThis results in the following behavior:\n\n x86_64-softmmu/qemu-system-x86_64 -monitor stdio \\\n -object memory-backend-ram,id=ram1,size=256M\n\n QEMU 2.7.91 monitor - type 'help' for more information\n (qemu) object_del ram1\n (qemu) object_del ram1\n object 'ram1' not found\n (qemu) object_add memory-backend-ram,id=ram1,size=256M\n Duplicate ID 'ram1' for object\n Try \"help object_add\" for more information\n\nwhich can be an issue for use-cases like memory hotplug.\n\nThis happens on the HMP side because hmp_object_add() attempts to\ncreate a temporary QemuOpts entry with ID 'ram1', which ends up\nconflicting with the command-line-created entry, since it was never\ncleaned up during the previous hmp_object_del() call.\n\nWe address this by adding a check in user_creatable_del(), which\nis called by both qmp_object_del() and hmp_object_del() to handle\nthe actual object cleanup, to determine whether an option group entry\nmatching the object's ID is present and removing it if it is.\n\nNote that qmp_object_add() never attempts to create a temporary\nQemuOpts entry, so it does not encounter the duplicate ID error,\nwhich is why this isn't generally visible in libvirt.\n\nCc: \"Dr. David Alan Gilbert\" <dgilbert@redhat.com>\nCc: Markus Armbruster <armbru@redhat.com>\nCc: Eric Blake <eblake@redhat.com>\nCc: Daniel Berrange <berrange@redhat.com>\nCc: qemu-stable@nongnu.org\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\nReviewed-by: Daniel P. Berrange <berrange@redhat.com>\nReviewed-by: Markus Armbruster <armbru@redhat.com>\nMessage-Id: <1496531612-22166-3-git-send-email-mdroth@linux.vnet.ibm.com>\nSigned-off-by: Markus Armbruster <armbru@redhat.com>\n(cherry picked from commit c645d5acee0ae022534cb609184277ec2b4a8577)\nSigned-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>\n---\n qom/object_interfaces.c | 9 +++++++++\n tests/check-qom-proplist.c | 4 ++--\n 2 files changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c\nindex d4253a8..ff27e06 100644\n--- a/qom/object_interfaces.c\n+++ b/qom/object_interfaces.c\n@@ -4,6 +4,7 @@\n #include \"qemu/module.h\"\n #include \"qapi-visit.h\"\n #include \"qapi/opts-visitor.h\"\n+#include \"qemu/config-file.h\"\n \n void user_creatable_complete(Object *obj, Error **errp)\n {\n@@ -181,6 +182,14 @@ void user_creatable_del(const char *id, Error **errp)\n error_setg(errp, \"object '%s' is in use, can not be deleted\", id);\n return;\n }\n+\n+ /*\n+ * if object was defined on the command-line, remove its corresponding\n+ * option group entry\n+ */\n+ qemu_opts_del(qemu_opts_find(qemu_find_opts_err(\"object\", &error_abort),\n+ id));\n+\n object_unparent(obj);\n }\n \ndiff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c\nindex e3b3ae4..8e432e9 100644\n--- a/tests/check-qom-proplist.c\n+++ b/tests/check-qom-proplist.c\n@@ -438,9 +438,9 @@ static void test_dummy_createcmdl(void)\n * check for this in user_creatable_del() and remove the QemuOpts if\n * it is present.\n *\n- * FIXME: add an assert to verify that the QemuOpts is cleaned up\n- * once the corresponding cleanup code is added.\n+ * The below check ensures this works as expected.\n */\n+ g_assert_null(qemu_opts_find(&qemu_object_opts, \"dev0\"));\n }\n \n static void test_dummy_badenum(void)\n", "prefixes": [ "50/79" ] }